From nobody Tue Feb 06 02:02:37 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TTRN130PZz59WRw; Tue, 6 Feb 2024 02:02:41 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TTRN11tkBz4Nqx; Tue, 6 Feb 2024 02:02:41 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707184961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dmA0I8mqMnA9FVxDALX6TEuSo04BboqJdoHitt+3hlg=; b=Ui1Mh9rTlIDOrer8AMG2YWYv8Q3zuiHPvQ/ehpoWbI92SJ+yQhLMwtVh4mo//Tb2o7iclJ DOs90TTHtgY6o2laiUxDQeqDylkPwdwFCNKhKrz7EY+nr5XDrKvycQ8KXE2qveSD8Z0l3A sgwuMnRatLXYUOWJE+lco/DDcI11ZdtsBcSwh3xnrvHgpSKcw8xzzolaJLAwzyBw8EBSuD i5fGuA1YkHlMJcL/Sl3HR4/GLpFDW7Q/h6NVILQ9vEyrYY+uhHzxq6CTQQuZ6uIcEMAfEy 5ppKFHDjS0r+Y+GYYwHb6tgd6RWMYjX0OHQLbGHtLg1cQmKmmaGx0gKOLdU3Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707184961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dmA0I8mqMnA9FVxDALX6TEuSo04BboqJdoHitt+3hlg=; b=XgAaQxS/BCOjaTIYMh8tl4CGRnmeORVPx6lh55BpA7kIDtPJhlyfOjGgJMrJYifFp9WlCE TY8dyzfcOoUUag4Ioi3RcbPX+RT856WmaXwlFFN3T0a4LeojoQr0iY/mVn1a6iKZCHvxl4 LserMgRM5wmDSOvcUmn6nIvAnNYimuIyOJFIS92AP9K9OSawQPr/1crkG2/MT/8h44j+PI g+oNUaJcpfrxWfX+JE00/wONKScgIxMoq72npPZn1eR88rwsK/tDxfpCOptBY2Zh5ebWEC /cIlolvw5/uIbx+LBXF99V+Duj8RwhVPAyWq23eSN6qrQmpgpEpHdbJO0YZNxA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707184961; a=rsa-sha256; cv=none; b=JqaeIa9EBy6qhr5h5qxkMGw781cpMZ49seNbokii5a/apY8rN+FLezdwWMhMVA2Nevm2QL w3huRUy5/7dSGftOOe9Jw3Tmwe8nmhn5zMV7nNS/c8m8aQYTOYGVunipBWUSE7B2z8od6M 3dMOL7ToSI/COr5kUGYB3B7owmEyDiJ9P4zckhsqhIjfNP+znpudB1H5Xy3i9zr9ATizec o5LwQ7wYx0t6XKb4OBIKjb3Zxc+mr5RHdS8gIcsWpiqOWfWtSqL4606MVDm0etDJwZ7/VH IHmqksJI39X7zy0dzOngQUVQ2HenOl1/4r9xmw5jEENyscNYI0dHPd3ynvaW+w== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TTRN00Y2FzJ1s; Tue, 6 Feb 2024 02:02:39 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Mon, 5 Feb 2024 18:02:37 -0800 From: Gleb Smirnoff To: Kristof Provost Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6d4a140acfdf - main - pf: Ensure that st->kif is obtained in a way which respects the r->rpool->mtx mutex Message-ID: References: <202402052119.415LJKSN037380@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202402052119.415LJKSN037380@gitrepo.freebsd.org> On Mon, Feb 05, 2024 at 09:19:20PM +0000, Kristof Provost wrote: K> The branch main has been updated by kp: K> K> URL: https://cgit.FreeBSD.org/src/commit/?id=6d4a140acfdf637bb559d371c583e4db478e1549 K> K> commit 6d4a140acfdf637bb559d371c583e4db478e1549 K> Author: Igor Ostapenko K> AuthorDate: 2024-02-05 16:22:31 +0000 K> Commit: Kristof Provost K> CommitDate: 2024-02-05 21:18:11 +0000 The author should be Kajetan :( I guess you were working on several reviews at a time and had name in paste buffer. :( K> pf: Ensure that st->kif is obtained in a way which respects the r->rpool->mtx mutex K> K> The redirection pool stored in r->rpool.cur is used for loadbalancing K> and cur can change whenever loadbalancing happens, which is for every K> new connection. Therefore it can't be trusted outside of pf_map_addr() K> and the r->rpool->mtx mutex. After evaluating the ruleset, loadbalancing K> decission is made in pf_map_addr() called from within pf_create_state() K> and stored in the state itself. K> K> This patch modifies BOUND_IFACE() so that it only uses the information K> already stored in the state which has been obtained in a way which K> respects the r->rpool->mtx mutex. K> K> Reviewed by: kp K> Differential Revision: https://reviews.freebsd.org/D43741 -- Gleb Smirnoff