From nobody Mon Feb 05 15:55:42 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TT9vs5vjVz58Rxn for ; Mon, 5 Feb 2024 15:55:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TT9vs1Hdrz4JMC for ; Mon, 5 Feb 2024 15:55:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20230601.gappssmtp.com header.s=20230601 header.b=vksZoPep; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::22c) smtp.mailfrom=wlosh@bsdimp.com Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2d0a4e8444dso16266761fa.2 for ; Mon, 05 Feb 2024 07:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1707148551; x=1707753351; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=361e9qjHbvPOF9/mSOAcwasPKrcOQ3yyKtPtrT/mG8I=; b=vksZoPeptqYjnkV5LNoXpapotHtMGAoGU+JT8j3XTUgQ1R4R5WX2PxvkXHCId5w29A S/RCwfcEl8jt6HvSNZ9qv85Sfr+1EVtf8JhkOT4OF2Ev709y2QXy+3j5ql8GrUzUhO39 NzoQ4Q9gSn86qeHzrDFqbBexeN/sipDt3E9CnzbwDbtDFFPevbBsnzr4dIlzNvtkW8Rj OaMRo62WHeaZsp+dkJ/14chgTXrRERauq7uhyDoa/96MEVGyxfbb7nePBZy5Ls6V6B7H ZgqKs57FSpP5EDk80fc7Ozf9t1uGQjC6dEWagmSALiuTMhCiVjkH8vcZv4HFgsM9cfpC HHsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707148551; x=1707753351; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=361e9qjHbvPOF9/mSOAcwasPKrcOQ3yyKtPtrT/mG8I=; b=vJo+V2RPQCzmDSXFulN1drNvX0kewqTi+VQxn7C8Jcx2OshPQDNfPDVCmb5BBEgVby IjjKaR/dwAhiRra3KzYtdsoYWuKr1dDPByn0wgsELmOn3paQRlhmNHDI8XalzaN4gyGL wZ+3CkLCL9o8fmiRRqLf5HnMlsItURSCN2l/X9kOo+YRPGmkaLaHBFFApkrJUNhUdh+F PR/4XWGrsFmGtWSQRdYZg2wouQ+UlumD8MxN4tvwi8U/7K2Hv7MCIGbtabCHqhdHlhWT gozOUN6B6TrpxmmZ+DCxZPPoXn4wWP9EVG9FdFQydgHUoBc/Sx9hPUVloaAkGUYaYzrE yQRg== X-Gm-Message-State: AOJu0YxrMFeOCPsB7E71a+ZNAMwYTDu1bfI7Qn6pLmcfSUul2yTbABjw XtejmGrp2kU27gdz3OM7qh/et3uT/1mZmNTRK88h1YD96AB2wUNBON+dMcD2AUpTFXGdMsnmBxc opfW01kKB7RXTvY9jOzX7yACavZL9ykvh4IELgQ== X-Google-Smtp-Source: AGHT+IHQeIF3EpEmZon/+Q3kckQT4H0EjFeisyLgHsdtC1i8j3OuGsbhEsEiyq7aUlmr/KpFO9Xlq2QG6fmQDoXH7R8= X-Received: by 2002:a2e:9890:0:b0:2d0:b2cd:2791 with SMTP id b16-20020a2e9890000000b002d0b2cd2791mr65420ljj.46.1707148551332; Mon, 05 Feb 2024 07:55:51 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org> <20240131204355.9EA2B19F@slippy.cwsent.com> In-Reply-To: From: Warner Losh Date: Mon, 5 Feb 2024 08:55:42 -0700 Message-ID: Subject: Re: git: 07c64d74917e - main - acpica: Import ACPICA 20230628 To: Cy Schubert Cc: Andriy Gapon , Jung-uk Kim , Baptiste Daroussin , src-committers , "" , "" , Dmitry Salychev Content-Type: multipart/alternative; boundary="000000000000fb3f010610a47ee2" X-Spamd-Bar: -- X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20230601.gappssmtp.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; R_SPF_NA(0.00)[no SPF record]; RCVD_COUNT_ONE(0.00)[1]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_TLS_LAST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::22c:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; DKIM_TRACE(0.00)[bsdimp-com.20230601.gappssmtp.com:+] X-Rspamd-Queue-Id: 4TT9vs1Hdrz4JMC --000000000000fb3f010610a47ee2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 5, 2024 at 8:34=E2=80=AFAM Warner Losh wrote: > > > On Wed, Jan 31, 2024 at 1:59=E2=80=AFPM Warner Losh wrot= e: > >> >> >> On Wed, Jan 31, 2024, 1:44=E2=80=AFPM Cy Schubert >> wrote: >> >>> In message <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org>, Andriy >>> Gapon >>> wri >>> tes: >>> > On 31/01/2024 19:40, Cy Schubert wrote: >>> > > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org>, >>> Jung-uk Kim >>> > > writ >>> > > es: >>> > >> On 24. 1. 31., Baptiste Daroussin wrote: >>> > >>> Hello, >>> > >>> >>> > >>> Either this one or the previous import is breaking arm64 build >>> > >>> >>> > >>> --- acpi_iort.o --- >>> > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:103:4: >>> error: fiel >>> > d >>> > >>> 'data' with variable sized type 'union (unnamed union at >>> > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98:2 >>> > >>> )' not at the end of a struct or class is a GNU extension >>> > >>> [-Werror,-Wgnu-variable-sized-type-not-at-end] >>> > >>> 103 | } data; >>> > >>> | ^ >>> > >> >>> > >> Sorry for the breakage. I will fix it soon. >>> > >> >>> > >> BTW, this code was added by this: >>> > >> >>> > >> https://reviews.freebsd.org/D31267 >>> > >> >>> > >> It seems struct iort_named_component was a hack, which duplicated >>> > >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field >>> DeviceName[32]. >>> > >> Is it really necessary? >>> > > >>> > > Though they incorporated the WOL patch I've been using, they've >>> broken >>> > > poweroff. >>> > >>> > The poweroff issue could be because of 9cdf326b4f >>> >>> Thanks. I clued into that a while ago after taking a break to read the >>> ML. >>> >>> This smelled of the original WOL problem I had last year that required >>> pulling the plug to allow the NIC to see the magic packet, but worse. >>> Hence >>> I was barking up the wrong tree. >>> >> >> On an semi-related issue... mind if I do a proper merge commit to catch >> up and not leave hidden landmines for the future? >> > > OK. I'll do a proper merge commit. We've accumulated a few dozen conflict= s > I'll have to sort out (though I think they > are all in files we don't user or have deleted). > After resolving the conflicts, it's one file (limts.h) that's now included where it wasn't before. Once I make sure that world and kernel still build, I'll push the change since limits.h isn't going to affect any functionality and I may need to ifdef it for the kernel anyay... Many of the conflicts could be avoided if we didn't modify the files like we do. I'll see about working up a patch, either myself or someone else who has interest, and submitting it for review. This would make future merges even easier since the changes we've made are all build-system related and need manual intervention today. Warner > Warner > > >> Warner >> >>> >>> -- >>> Cheers, >>> Cy Schubert >>> FreeBSD UNIX: Web: https://FreeBSD.org >>> NTP: Web: https://nwtime.org >>> >>> e^(i*pi)+1=3D0 >>> >>> >>> --000000000000fb3f010610a47ee2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Feb 5, 2024 at 8:34=E2=80=AFA= M Warner Losh <imp@bsdimp.com> = wrote:


On Wed, Jan 31, 2024 at 1:59=E2=80=AFPM Warne= r Losh <imp@bsdimp.c= om> wrote:


On Wed, Jan 31, 2024, 1:44=E2=80=AFPM Cy Schubert &l= t;Cy.Schuber= t@cschubert.com> wrote:
In message <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.= org>, Andriy Gapon
wri
tes:
> On 31/01/2024 19:40, Cy Schubert wrote:
> > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org&g= t;, Jung-uk Kim
> > writ
> > es:
> >> On 24. 1. 31., Baptiste Daroussin wrote:
> >>> Hello,
> >>>
> >>> Either this one or the previous import is breaking arm64 = build
> >>>
> >>> --- acpi_iort.o ---
> >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:10= 3:4: error: fiel
> d
> >>> 'data' with variable sized type 'union (unnam= ed union at
> >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98= :2
> >>> )' not at the end of a struct or class is a GNU exten= sion
> >>> [-Werror,-Wgnu-variable-sized-type-not-at-end]
> >>>=C2=A0 =C2=A0 =C2=A0103 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0} data;
> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0^
> >>
> >> Sorry for the breakage.=C2=A0 I will fix it soon.
> >>
> >> BTW, this code was added by this:
> >>
> >> https://reviews.freebsd.org/D31267 > >>
> >> It seems struct iort_named_component was a hack, which duplic= ated
> >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field Devic= eName[32].
> >> Is it really necessary?
> >
> > Though they incorporated the WOL patch I've been using, they&= #39;ve broken
> > poweroff.
>
> The poweroff issue could be because of 9cdf326b4f

Thanks. I clued into that a while ago after taking a break to read the ML.<= br>
This smelled of the original WOL problem I had last year that required
pulling the plug to allow the NIC to see the magic packet, but worse. Hence=
I was barking up the wrong tree.

On an semi-related issue... mind if I do a = proper merge commit to catch up and not leave hidden landmines for the futu= re?

OK. I'll do a proper me= rge commit. We've accumulated a few dozen conflicts I'll have to so= rt out (though I think they
are all in files we don't user or= have deleted).

After res= olving the conflicts, it's one file (limts.h) that's now included w= here it wasn't before. Once I make sure that world and kernel still bui= ld, I'll push the change since limits.h isn't going to affect any f= unctionality and I may need to ifdef it for the kernel anyay...

Many of the conflicts could be avoided if we didn't m= odify the files like we do. I'll see about working up a patch, either m= yself or someone else who has interest, and submitting it for review. This = would make future merges even easier since the changes we've made are a= ll build-system related and need manual intervention today.
<= br>
Warner
=C2=A0
Warn= er
=C2=A0
Warner

--
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 ht= tps://FreeBSD.org
NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<cy@nwtime.org>=C2=A0 =C2= =A0 Web:=C2=A0 https://nwtime.org

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 e^(i*pi)+1=3D0


--000000000000fb3f010610a47ee2--