From nobody Fri Feb 02 16:55:42 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TRMNG6cw8z595k2; Fri, 2 Feb 2024 16:55:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TRMNG5Lptz4VBH; Fri, 2 Feb 2024 16:55:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706892942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qIO4aeBWqWJq41vJQ3f/Io5XBDM8g+SqCHXGlcW3FdU=; b=fOn1tYGQhfIAiutQcRTpn0z+GHaKSpTMlpK9Hc7t4yg85smT3lEvo0sLDOULDQ19HwSMD2 BIvN91ajpg0bJN7nM5BAwPMhRWMRa5R2i2XAsMZmvS9l4b+KBc5ALSnTuc84d5cKRY1k6Y Uc8mCulu/wLIDuVs/ousKOwCfOsEDlUMR1vIT4t3XYHthyiWKAYx70svqyfw/QjtdcgE9b wOSaOP+eGE8xyo5H0olIQVFiTP8zX7W+67LMIfLrjh+PWs6oYRk7rse4TCjCEkXLmkJ713 VwuXRu3s3rEJwcfDYjHveti/kGqrzZMuad4OOxe2G8PpUMUVvHNczQACm2KeHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706892942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qIO4aeBWqWJq41vJQ3f/Io5XBDM8g+SqCHXGlcW3FdU=; b=EgL+rndrbQ7wjNwZJpBQUE9uMmpTwz2tGJXkC2WSLaSiRu7fbdnz0f+ME2GZBg4wcfcXc7 Lpu1cDT2AHa9jZd2qKsfotY69afMmtjkJe7oUMXJ6xHAc/MQLhNrHJzxRssLq4fTOVhYLK e6qyL0b07RH6qhn8wlwsFIVXDZn/K9bkZJfBz3Ksso6VgJ9C6wvcPHxzDlPNrZi0pP41P+ 4f7FIw0ilCOBQJV0ED4iKBY+QUTe92yfxOCHctX+Bj+G+DLn5gFL/facLLuKk76W7J++z1 XzEF+CbNqiL1IsO2Fl4UrNMNoQUiFIp9n6hlmmJizxD2ROdt1HjeUy9QtNfmrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706892942; a=rsa-sha256; cv=none; b=hrBxmB80SVE3L8Y/Tp0GjepX9sfyujT3AoVmK052hezcvOe/x6VIfTrTbB+gyFv7eMNrv2 5AGKtSBpVra+x9xkgdlSuV61YBh3UnxNOGM8D6XNqoMLUjgF18HV8iTXniA+a2TwBMLCxa X8+jLEBc6oCYSunS8lHAi+Tetnrfp6lvhFQKf5xFFXr6jyipGJNJv2FPJDKxOwEyVrxlqq YWmfcHmfQIlgGLbJIf0Y5TGBzSZ4P+ScoajFZTBwnhpuom7eOC6jwfgl7bgSpUPyGYYZdb ooeWWazBHuvmRma5UFpTbD9B6p3c1LMs9zjsqr2qPXAGkZnmUEo7m2Cf1va8zQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TRMNG4DQMzdsb; Fri, 2 Feb 2024 16:55:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 412GtgDj034663; Fri, 2 Feb 2024 16:55:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 412GtgmU034660; Fri, 2 Feb 2024 16:55:42 GMT (envelope-from git) Date: Fri, 2 Feb 2024 16:55:42 GMT Message-Id: <202402021655.412GtgmU034660@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 306d3fb23d7c - main - libpfct: fix incorrect array check List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 306d3fb23d7ccbc327b6038df2088629daff87b4 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=306d3fb23d7ccbc327b6038df2088629daff87b4 commit 306d3fb23d7ccbc327b6038df2088629daff87b4 Author: Kristof Provost AuthorDate: 2024-02-01 21:32:32 +0000 Commit: Kristof Provost CommitDate: 2024-02-02 16:55:16 +0000 libpfct: fix incorrect array check Reported by: Coverity Scan CID: 1523771 Sponsored by: Rubicon Communications, LLC ("Netgate") --- lib/libpfctl/libpfctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libpfctl/libpfctl.c b/lib/libpfctl/libpfctl.c index cb9b377f7b6c..71546c4709c2 100644 --- a/lib/libpfctl/libpfctl.c +++ b/lib/libpfctl/libpfctl.c @@ -965,8 +965,8 @@ snl_add_msg_attr_rule_labels(struct snl_writer *nw, uint32_t type, const char la off = snl_add_msg_attr_nested(nw, type); - while (labels[i][0] != 0 && - i < PF_RULE_MAX_LABEL_COUNT) { + while (i < PF_RULE_MAX_LABEL_COUNT && + labels[i][0] != 0) { snl_add_msg_attr_string(nw, PF_LT_LABEL, labels[i]); i++; }