From nobody Thu Feb 01 21:44:46 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TQsrH37Ppz58kl7; Thu, 1 Feb 2024 21:44:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TQsrH0kydz4jYH; Thu, 1 Feb 2024 21:44:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706823887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pLxh92dolyFtHQkW4h4vEfNH5C0YPHbVqjBIzar+gyM=; b=H+oL/TwV2TefZ3Tn1gAA0MCTn7zKZdwN8/ewOonNA+gjytYqlrEAP0XNjEHKzDSpPsNL9B gcdFzHSthwc/agaTU5f1YeVYweDJcrezFjr4NZs0LvG5BXX2+B0cBcL1DukxvvlHT8+1g2 kYGuO6wLvn6jFq1W/qjIGLKtnH6gKnkBMHqp8mwLOwVXWXr851HboY9GVP30zq31IUaQ9f 0H1y2XAPsy0YNNxU3LWuxWvlzqRgctgo0PNT1MAMKoq/ZTLuOrBX7GGTXejl/U/oWD7/95 cIITV6x6clgbf9URETiCJzFh+P7G5+hWgoP7e/Ibk6Gg6awa4zlzuL/jiHQLWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706823887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pLxh92dolyFtHQkW4h4vEfNH5C0YPHbVqjBIzar+gyM=; b=FXVek166128+4QCBm0UGEpCYZz06caKLdbQHUDZb2egVobWmUU06wzjqcAW7APJiDVLRET fIijnvOLvpBKj3fusmqR3eEFRXoy8p84PYxdAC2L4nWfAUt/6wiTQWGl+rNCFKSdY6mIWD c6kInQQknQfjSYX3/Cuj0YRBG3BxL92zJPeO8Pvzvbf5qrDF+M4lEuFD7E6aNAI1gdJrXS 2+TC2bb/xlUEInz05HZLaA9/ZE0WwuPayZ+btw5++lxMpfxTtv2sG4WhTpYKFpgaoFBGlb ovBdK1XluXem1VSeIymmOrWmXIC3U5r8DSy2o5jTyD+uUIEVTYGIJyNpVMEWVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706823887; a=rsa-sha256; cv=none; b=sOv97jXrJhbKKpKn4lrAAIi15ml/HKh1uqRkxgSK6rs5U13tw4PX+vwCqRxLp43NtMZzsR qwrfVoU5OBwKiliLYgetwnBM97zOuvQOXIwV2YxaNBQA3+6daz/BkzeNB7fqrePhf+elDt VmfdeXFjyGmXMti1RvXRGNu74UhGNytXU2I4/8Y6P3QrYxltR9t3jNrUSyRNxShq4ULTOc rgibdfe17Qk4yE7G75IvqqxklaTJypomEzLaUlfSjFGVzJz7QY4jbiGaP58m05trcwlc5z efgvE1LM5NTzWF4PtqANaSnRgcPd34wpgvcFQuT+zOs+zZyomI+hOY2uM0XcsA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TQsrG6fvJz1J8H; Thu, 1 Feb 2024 21:44:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 411LikSV004736; Thu, 1 Feb 2024 21:44:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 411LikWU004733; Thu, 1 Feb 2024 21:44:46 GMT (envelope-from git) Date: Thu, 1 Feb 2024 21:44:46 GMT Message-Id: <202402012144.411LikWU004733@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 861274c9f8cf - main - tests/netinet: add a demo of TCP implied connect List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 861274c9f8cf2a5c00ded9580ea91b22def683f7 Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=861274c9f8cf2a5c00ded9580ea91b22def683f7 commit 861274c9f8cf2a5c00ded9580ea91b22def683f7 Author: Gleb Smirnoff AuthorDate: 2024-02-01 21:37:26 +0000 Commit: Gleb Smirnoff CommitDate: 2024-02-01 21:43:36 +0000 tests/netinet: add a demo of TCP implied connect The TCP implied connect is an artifact left after T/TCP. To my surprise it still works, hence the existence of this test. Please read this email first: https://lists.freebsd.org/pipermail/freebsd-net/2010-August/026311.html An interesting fact that this test takes 220 - 240 milliseconds to execute on my Threadripper PRO. Flipping the '#if 0' to '#if 1' in the test, thus bringing it back to normal connect(2), would speed the test up a hundred times and I guess all this time is fork+exec of the test. --- tests/sys/netinet/Makefile | 1 + tests/sys/netinet/tcp_implied_connect.c | 81 +++++++++++++++++++++++++++++++++ 2 files changed, 82 insertions(+) diff --git a/tests/sys/netinet/Makefile b/tests/sys/netinet/Makefile index 434aadc87f46..b86457c2d723 100644 --- a/tests/sys/netinet/Makefile +++ b/tests/sys/netinet/Makefile @@ -11,6 +11,7 @@ ATF_TESTS_C= ip_reass_test \ so_reuseport_lb_test \ socket_afinet \ tcp_connect_port_test \ + tcp_implied_connect \ tcp_md5_getsockopt ATF_TESTS_SH= arp \ diff --git a/tests/sys/netinet/tcp_implied_connect.c b/tests/sys/netinet/tcp_implied_connect.c new file mode 100644 index 000000000000..2961626d5e5b --- /dev/null +++ b/tests/sys/netinet/tcp_implied_connect.c @@ -0,0 +1,81 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright (c) 2024 Gleb Smirnoff + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +#include +#include +#include +#include +#include + +#include + +static struct sockaddr_in sin = { + .sin_family = AF_INET, + .sin_len = sizeof(sin), +}; + +static const char buf[] = "hello"; +static char repl[sizeof(buf)]; + +ATF_TC_WITHOUT_HEAD(tcp_implied_connect); +ATF_TC_BODY(tcp_implied_connect, tc) +{ + socklen_t len; + int s, c, a; + + ATF_REQUIRE(s = socket(PF_INET, SOCK_STREAM, 0)); + ATF_REQUIRE(c = socket(PF_INET, SOCK_STREAM, 0)); + + ATF_REQUIRE(bind(s, (struct sockaddr *)&sin, sizeof(sin)) == 0); + len = sizeof(sin); + ATF_REQUIRE(getsockname(s, (struct sockaddr *)&sin, &len) == 0); + ATF_REQUIRE(listen(s, -1) == 0); +#if 0 + /* + * The disabled code is that you would normally do. + */ + ATF_REQUIRE(connect(c, (struct sockaddr *)&sin, sizeof(sin)) == 0); + ATF_REQUIRE(send(c, &buf, sizeof(buf), 0) == sizeof(buf)); +#else + /* + * And this is implied connect. + */ + ATF_REQUIRE(sendto(c, &buf, sizeof(buf), 0, (struct sockaddr *)&sin, + sizeof(sin)) == sizeof(buf)); +#endif + + ATF_REQUIRE((a = accept(s, NULL, NULL)) != 1); + ATF_REQUIRE(recv(a, &repl, sizeof(repl), 0) == sizeof(buf)); + ATF_REQUIRE(strcmp(buf, repl) == 0); +} + +ATF_TP_ADD_TCS(tp) +{ + ATF_TP_ADD_TC(tp, tcp_implied_connect); + + return (atf_no_error()); +}