From nobody Thu Feb 01 01:53:49 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TQMQM36Tgz58lcV; Thu, 1 Feb 2024 01:54:03 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TQMQM0mFFz4Wtr; Thu, 1 Feb 2024 01:54:03 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-50eabbc3dccso475614e87.2; Wed, 31 Jan 2024 17:54:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706752441; x=1707357241; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fo+UDuMTLZffJhlyJJP0V3FlWmmsm+ca213Vt7uBP6o=; b=X4BBpIbJvJEqAXo0VIr2EoM7VkJYa3LlQxRgKTicdE9GpNEFGHWprSCDIYouVjJ73U CVfCr9nKaWG8cftNJq8BLlo2xjuHF97KFNYMl3xnoZPn9Tq4hyPqE/2fnkgKNUgL8tIX ioxoZ1i1ysY5R3eqGRqwHz1r0rMipUIhNtWmw/4Zk70YFo3rJdDse3OkgSbZhVXBiPLO IIucq0JdQhTaUoH/qZTDskDV7XUPK0Q8HNvHHB3v55tOacKvIsuDIGuF6s4bA6EC57Lc zK4+/a4O9rDUXBIkUeJ5NH4O5//ZF+8KZD/+bpc4e9MURcXD0EpAUNkJhAy5AmZT/5On t6tQ== X-Gm-Message-State: AOJu0YytfpAVD5TnZu+gLxrF6pdN43wwI1jdw8IvVsY87qRzq+P7FK6t MVeHiO+0WhUk8yOZeB2piWxB6fzGAL3Sw9BJjMroxtHo4d97T2j5KTrwDK+L6vNZjM4mRLDAji0 ncRGDqy0GGwhUiau2m028Jn6icpga2n5D X-Google-Smtp-Source: AGHT+IGjJeSVRCBkAQs4lX2OGITIoLvcsH/KYRvtW7+iGrWC+DFrEu1bdzitttmOzJtUfjOlet2IZHlv1PxSK5W2+XY= X-Received: by 2002:ac2:4c06:0:b0:50e:4a61:c369 with SMTP id t6-20020ac24c06000000b0050e4a61c369mr801785lfq.46.1706752440918; Wed, 31 Jan 2024 17:54:00 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202401312041.40VKfgE0080600@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Wed, 31 Jan 2024 20:53:49 -0500 Message-ID: Subject: Re: git: ed3563b0ac31 - main - csu: add crtbrand.o dependency on sys/param.h To: Warner Losh Cc: src-committers , "" , "" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4TQMQM0mFFz4Wtr X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On Wed, 31 Jan 2024 at 15:57, Warner Losh wrote: > >> commit ed3563b0ac31d854bf907d4d847ac0195ec9637b >> Author: Ed Maste >> AuthorDate: 2024-01-12 15:01:49 +0000 >> Commit: Ed Maste >> CommitDate: 2024-01-31 20:40:27 +0000 >> >> csu: add crtbrand.o dependency on sys/param.h >> >> __FreeBSD_version is recorded in *crt1.o and crti.o via crtbrand.o. Add >> an explicit dependency to pick up __FreeBSD_version bumps. >> >> Additional changes are required to fully plumb *crt1.o dependencies >> through the build. > > So a kernel bump now rebuilds (or at least relinks) everything? Or soon will? Right now no, because of the second point in the commit message - we don't currently record the dependency on *crt*.o files. We should do that though; clean and NO_CLEAN builds should produce identical output. Once that dependency is added, bumping __FreeBSD_version will indeed cause everything to be rebuilt. If that's too annoying we could add a src.conf knob to skip those dependencies to provide fast but inconsistent builds as today.