From nobody Mon Dec 30 15:04:49 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YMKC55gnsz5k48f; Mon, 30 Dec 2024 15:04:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YMKC54mtnz4gdW; Mon, 30 Dec 2024 15:04:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735571089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YoFA9ruGMOI16Zampn2QVo9OHmDdP9+Ts9alsPMeWCc=; b=a3BdzJ2CKkolrvnyIwhgKcCFCVXiErj9ClhMNr1q5jcQ1n/mZDO2pbBR7H9CUcAo4Ib/t1 kRy7PrruGPHAKPBFtnH78LieCrcLQOqAroSm81OyuVZIAIuzI3yEhVLgIWxMDDxd/euSko nZrg4rUQkNenrAd+floACTPo60H+QSfDhe6owcaF+qXrhV/Wz+gL/MsPW10OmEMeEMzfmp 7MYmVXTgAajzM1XOZrHcVK5zJbiRPYvDIBtwHc1G+ucBDvCtjwQ/vSeeBpyd2CKN5SUIow +6U5TvVWvV9ZyTrah4RPnXYM547VC3tmSRma6ANxOYmsUdsap47/s82wmW4iXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735571089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YoFA9ruGMOI16Zampn2QVo9OHmDdP9+Ts9alsPMeWCc=; b=juui1LX91P9drdXnZYKP4TxU23PdV4H/THXRp3WUCR4BkUyuHvsnsvOoIDwgboP/NXvCwK QlKot5iQkc+pBeuiVRG4gUrhoR0Iqw00mXjuQSm+Ced9ZwBTuQkgQez0m9j49Ci+AT+N8R NAcn1WGQRznyl8JmRvQXDof9t+J9fR9EMD3Ny94cV2YivO01eohkiBv3nnlD0msGrUtWaD 1yd+zndiKwstI78T3q1A9LldtfJLsts1SJvfalfZtTxKXnYtPVs7AhGuTmbAELtW4JuFEV RK5hlwBQKC0Jz3ZvAWFQ0nNgiuU8kqvstVvS0ExNWazab/64GoOK/MHo7AwaJg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735571089; a=rsa-sha256; cv=none; b=nr0zoYRgqq+L282g6+P0lqEk7Zk3kO8nb0SjBecczenFOLTX8tqooLjm8IHwORdrLsiZ3H hFcl8eSONCccAS6Hr12/eE2YC0eRzcAhkJJmdoL58Hd+wpABXC7t2fmLn3Y/kBQHgYNnC4 +6NEoFu3DY8grGqzHx/1WUdMqS9y0VFQGP2nE3GOQTCmmy3mLxxh2VlR7hjTwFB0GNMTZJ tCtIyN8OYqw+yxMOcvmY1tWTYDjh8xXpLWwDbNJ4XQuFX3Sjjjz6o/OA2uqdQKAkV91abc Wmng5MuM+UMApnjoZnl7nd1m/+jG4vw1MuOJNS4EKKsd/W034k/CvtOSs+oELA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YMKC53zhKzyxJ; Mon, 30 Dec 2024 15:04:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BUF4nDn084990; Mon, 30 Dec 2024 15:04:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BUF4nM3084987; Mon, 30 Dec 2024 15:04:49 GMT (envelope-from git) Date: Mon, 30 Dec 2024 15:04:49 GMT Message-Id: <202412301504.4BUF4nM3084987@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: b5739c8b1222 - main - TCP RACK, BBR: ensure return value is always ininitialized List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b5739c8b12226c791bc8e7a4ac6e48965333509a Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=b5739c8b12226c791bc8e7a4ac6e48965333509a commit b5739c8b12226c791bc8e7a4ac6e48965333509a Author: Michael Tuexen AuthorDate: 2024-12-30 15:02:43 +0000 Commit: Michael Tuexen CommitDate: 2024-12-30 15:02:43 +0000 TCP RACK, BBR: ensure return value is always ininitialized Do not return an uninitialized value from ctf_do_queued_segments() in case no packets are actually processed (all are skipped). Reviewed by: rrs CID: 1523774 MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48217 --- sys/netinet/tcp_stacks/rack_bbr_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_stacks/rack_bbr_common.c b/sys/netinet/tcp_stacks/rack_bbr_common.c index 150298f8413f..156091feeb30 100644 --- a/sys/netinet/tcp_stacks/rack_bbr_common.c +++ b/sys/netinet/tcp_stacks/rack_bbr_common.c @@ -478,7 +478,7 @@ skipped_pkt: if (no_vn == 0) { CURVNET_RESTORE(); } - return(retval); + return (0); } int