From nobody Fri Dec 27 17:26:18 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YKXTv5dPxz5j4fL; Fri, 27 Dec 2024 17:26:27 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YKXTv52XDz45Z3; Fri, 27 Dec 2024 17:26:27 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735320387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RDwD3ewwwKv4ORM3gdwL9029CAX3z6ZgyyTaCMdk9hA=; b=yi8Q1bcLNjJU1q/k0lXLd3AgjpPL1hH+cal/UT5m+oedMOxDXD3bQhq6t9tX9KxsmD+TFs /fDnxKBfHusvZCy58JYd1I3YCu0IEEN5ouW4fEqQfZIXiu6c6SCkaX68xBy2exjSwTG+BL uFWn6bulUu7ejqFS6ozPvxS6nmxHdxrujrAyojWKex7i9pM/Tcg+yUoz5wVC0pQ2Il1hdR yMVRNRwoas7l6wlRQb/nbcN4y1pE3osMzreKAg26NDiIJBL3E6iNv1IzEBaXa33olrL/D2 7OEcUIunw4REsSfmdwSa418u0lexsE25O6UFUPCV4zX6Gr8XFRltxGgrYNacWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735320387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RDwD3ewwwKv4ORM3gdwL9029CAX3z6ZgyyTaCMdk9hA=; b=vt0dOUmiZmZiiZB8J8xmaqFDA8/kpnhZLZP2/RqzWtA+P/hEMLgdZwfYFNiczK1aLOKjI/ uIBj31BnR8kTNnzKVvlZF5CFKWU+BhykEI65mxuBv4ftFPZR0RJwgl1pNN0XOvwAEXoo9R RaXhRXUKXg+t7/vxcrz3brLT4RVk574dm5WIRbTrwF8pqDhVR3uXH77+xMli8jCpkEMGfn xg1frO7gb8zw7wewFTEEepbfv37/KIAQqKNVF7t44i3fyrfR2ueZs62z7rkBs2fz1mpIAX Hrhp23FJ/c8hhDJyRjY8BcnzW3P5nCfx9UYILbMyG5N5OgDJQ3BaWbWUO+YczQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735320387; a=rsa-sha256; cv=none; b=DMzwK790P5ikY9EiEwnSC9UMltQlmb0j7tMWH8ChxEt7hiVg9j79qB+9svkyWooJdocUE9 mIR/JWMn7Ej/x2dVI5oPEbFEnzrBRnnq9cWi3cIAis0vi8Tf71L5lACKRAaAP1Oq8UB7RL may8MT1j6mw3Wa5R+5kN1cXh6+Xg8H1x/neU9QR5Q8RCvZlsb6rVZ9Tur0UMlrXQ5cG0C4 BbTN35mkWM0tONkM73GEnFekLxq0mNUjgUq/0VP2ls0wzKzN/GM8kACLL71YSuqtLnmRnD 5XjAD/V7lQJnS1bNqnqC6WlgLF+92oSIDEuvG3hBRECR51pdCWHN5rWADIz1Dw== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R10" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YKXTv3HRfz12Fx; Fri, 27 Dec 2024 17:26:27 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 7D24176FB; Fri, 27 Dec 2024 18:26:23 +0100 (CET) From: Kristof Provost To: Renato Botelho Cc: Andrew Turner , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ba1904937d9a - main - acpica: Extract _OSC parsing to a common file Date: Fri, 27 Dec 2024 17:26:18 +0000 X-Mailer: MailMate (2.0r6068) Message-ID: In-Reply-To: <149116bc-677c-47b2-9ff7-f454418fec21@FreeBSD.org> References: <202412121819.4BCIJ1KW097190__8805.67587898753$1734027579$gmane$org@gitrepo.freebsd.org> <149116bc-677c-47b2-9ff7-f454418fec21@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_B90DBFDC-A7D8-4764-961A-A5BB375C1A68_=" --=_MailMate_B90DBFDC-A7D8-4764-961A-A5BB375C1A68_= Content-Type: text/plain; charset=UTF-8; format=flowed; markup=markdown Content-Transfer-Encoding: quoted-printable On 26 Dec 2024, at 21:44, Renato Botelho wrote: > On 12/12/24 15:19, Andrew Turner wrote: >> The branch main has been updated by andrew: >> >> URL: = >> https://cgit.FreeBSD.org/src/commit/?id=3Dba1904937d9ae0539e39001467a1= 519b17177118 >> >> commit ba1904937d9ae0539e39001467a1519b17177118 >> Author: Andrew Turner >> AuthorDate: 2024-12-12 16:29:45 +0000 >> Commit: Andrew Turner >> CommitDate: 2024-12-12 18:00:22 +0000 >> >> acpica: Extract _OSC parsing to a common file >> This will be used by pci_host_generic_acpi.c so needs to be = >> in a >> common location. >> Reviewed by: imp, jhb >> Sponsored by: Arm Ltd >> Differential Revision: https://reviews.freebsd.org/D48044 > > My dev system was running CURRENT from Oct 31 and broke after I = > upgrade to most recent version on Dec 20. After bisecting I found = > this commit as the one that introduced the problem. > > It starts booting but can't found any disk. Pressing ? at mount = > prompt shows nothing. This system is a VM running on KVM and I've = > attached dmesg from successfully boot > > FreeBSD idaho.arrakis.com.br 15.0-CURRENT FreeBSD 15.0-CURRENT #22 = > n274182-938e4b131c4: Thu Dec 26 18:10:12 -03 2024 = > root@idaho.arrakis.com.br:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODE= BUG = > amd64 > I=E2=80=99m seeing similar boot issues on VMWare aarch64 (i.e. freebsd in= = VMware on a Mac). My bisect pointed to: commit 1f5c50a8617355758510675cb9412f56fed12efc Author: Andrew Turner Date: Thu Dec 12 16:30:39 2024 +0000 pci_host_generic:Add pcib_request_feature on ACPI In the ACPI attachment add support for the pcib_request_feature = method. This uses the common _OSC handling. Reviewed by: imp, jhb Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D48048 I=E2=80=99ve not yet been able to capture a dmesg, but it looks like the = nvme = storage device just isn=E2=80=99t found, leading to the zpool failing to = mount. I=E2=80=99m currently working around that with this patch: diff --git a/sys/dev/pci/pci_host_generic_acpi.c = b/sys/dev/pci/pci_host_generic_acpi.c index 1ff3a6bda707..c990edf26a3c 100644 --- a/sys/dev/pci/pci_host_generic_acpi.c +++ b/sys/dev/pci/pci_host_generic_acpi.c @@ -543,7 +543,7 @@ static device_method_t generic_pcie_acpi_methods[] = =3D { DEVMETHOD(pcib_release_msix, = generic_pcie_acpi_release_msix), DEVMETHOD(pcib_map_msi, generic_pcie_acpi_map_msi), DEVMETHOD(pcib_get_id, generic_pcie_acpi_get_id), - DEVMETHOD(pcib_request_feature, = generic_pcie_acpi_request_feature), + //DEVMETHOD(pcib_request_feature, = generic_pcie_acpi_request_feature), DEVMETHOD_END }; Best regards, Kristof --=_MailMate_B90DBFDC-A7D8-4764-961A-A5BB375C1A68_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 26 Dec 2024, at 21:44, Renato Botelho wrote:

On 12/12/24 15:19, Andrew Turner wrote:

The branch main has been updated by andrew:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3Dba1904937d9ae0539e39001467a1519b17177118

commit ba1904937d9ae0539e39001467a1519b17177118
Author: Andrew Turner andrew@Fr= eeBSD.org
AuthorDate: 2024-12-12 16:29:45 +0000
Commit: Andrew Turner andrew@Fr= eeBSD.org
CommitDate: 2024-12-12 18:00:22 +0000

 a=
cpica: Extract _OSC parsing to a common file
     This will be used by pci_host_generic_acpi.c so needs to be in a
 common location.
     Reviewed by:    imp, jhb
 Sponsored by:   Arm Ltd
 Differential Revision:  https://reviews.freebsd.org/D48044

My dev system was running CURRENT from Oct 31 and broke a= fter I upgrade to most recent version on Dec 20. After bisecting I found= this commit as the one that introduced the problem.

It starts booting but can't found any disk. Pressing ? a= t mount prompt shows nothing. This system is a VM running on KVM and I'v= e attached dmesg from successfully boot

FreeBSD idaho.arrakis.com.br 15.0-CURRENT FreeBSD 15.0-CU= RRENT #22 n274182-938e4b131c4: Thu Dec 26 18:10:12 -03 2024 root@idaho.arrakis.com.br:/usr/obj/us= r/src/amd64.amd64/sys/GENERIC-NODEBUG amd64

I=E2=80=99m seeing similar boot issues on VMWare aarch64 = (i.e. freebsd in VMware on a Mac). My bisect pointed to:

co=
mmit 1f5c50a8617355758510675cb9412f56fed12efc
Author: Andrew Turner <andrew@FreeBSD.org>
Date:   Thu Dec 12 16:30:39 2024 +0000

    pci_host_generic:Add pcib_request_feature on ACPI

    In the ACPI attachment add support for the pcib_request_feature metho=
d.
    This uses the common _OSC handling.

    Reviewed by:    imp, jhb
    Sponsored by:   Arm Ltd
    Differential Revision:  https://reviews.freebsd.org/D48048

I=E2=80=99ve not yet been able to capture a dmesg, but it= looks like the nvme storage device just isn=E2=80=99t found, leading to = the zpool failing to mount.

I=E2=80=99m currently working around that with this patch= :

di=
ff --git a/sys/dev/pci/pci_host_generic_acpi.c b/sys/dev/pci/pci_host_gen=
eric_acpi.c
index 1ff3a6bda707..c990edf26a3c 100644
--- a/sys/dev/pci/pci_host_generic_acpi.c
+++ b/sys/dev/pci/pci_host_generic_acpi.c
@@ -543,7 +543,7 @@ static device_method_t generic_pcie_acpi_methods[] =3D=
 {
        DEVMETHOD(pcib_release_msix,    generic_pcie_acpi_release_msix),
        DEVMETHOD(pcib_map_msi,         generic_pcie_acpi_map_msi),
        DEVMETHOD(pcib_get_id,          generic_pcie_acpi_get_id),
-       DEVMETHOD(pcib_request_feature, generic_pcie_acpi_request_feature=
),
+       //DEVMETHOD(pcib_request_feature,       generic_pcie_acpi_request=
_feature),

        DEVMETHOD_END
 };

Best regards,
Kristof

--=_MailMate_B90DBFDC-A7D8-4764-961A-A5BB375C1A68_=--