From nobody Thu Dec 19 18:57:00 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YDftK308Lz5hbk3; Thu, 19 Dec 2024 18:57:13 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YDftK0y8mz4JZ0; Thu, 19 Dec 2024 18:57:13 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-3a78b39034dso3332575ab.3; Thu, 19 Dec 2024 10:57:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734634631; x=1735239431; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L+UBL7KC+vNDw8LG1NHWr+R4yXlRaukXnZSVNMgR8QQ=; b=TG2mgIF2NrlMuzycYspM2ylBs4VvVuL7nmeCNr8C28ABDjRtFAuW3Z9713wEG8TVS3 6cmog6lvg3XAG4seIrn5v6vjBKTYGSFgNNzqTfjjFYAvUorqMRXYb73iRSdP730sOeZJ rgwoGiOs1OfgM+5T/HAxfkqQArpBY2hB2gsdEzi/vjF3ymg4DjMq1AplquC0whznnLjR D1+OCA7KLtXOUWnfityvmYGWgPxY6Y7JE58MMQdsWRj2t0ztl7HPQoJi3/rP5KDQ4BNR JG3tpzhmHMlYfaG2LhrIRQfFxrV/pEo226655aobcdzmropzC+/OGLiZc5uLigyEIAgF XkGw== X-Forwarded-Encrypted: i=1; AJvYcCVISm/3fd5vHfT3b9WpUq1pRkhf+HNuC40sAJj81BDaA3ATVQ9oXP1vSj8co/+hxeaQq3NoW1WwXg==@freebsd.org, AJvYcCVJCZKF0RVaS99AZjWmX8eO19a2Qg0HwLn5fB59PuVAo9J9KyPNADwJxc3szj2mrTgR9nvRrwzOLx8VS217Z9s=@freebsd.org, AJvYcCWEaHnPWiE0xBZVXZW2b69UPdRBfl8EWSHOk0gJuyRABeRdoW96VRVEy9SgOXkKEjZWs50AXB5xQJayDabAhJTBo79l@freebsd.org, AJvYcCXjc1e1h9mRm39iy/hL1/rLWNtlzD2JGPSTCM/Zg+zXGbBh0Emm0b8yMk7YvCCPtG3hXrSuAzTN0l/Dl2k6rklDL7p3UDM=@freebsd.org X-Gm-Message-State: AOJu0YyYjClPo1Jdy/oRPcWYZXyF+p+1qHpl3MTEvvOfmxpJvTeY4rHF vUX/+QHq0MzNo6yh5Kec9NqrnGhPbUnLSsaeGvE9z041WYxxbTTqtYUVfsKLGTmqiofTOwaUHq0 fyTUlBxTxkZLS/OJq0I4ZcAUqG2a/Cg== X-Gm-Gg: ASbGncvN9FyS6hIiRiWdGMj8XBaz/WB8NNrb+yOXF8zWR2mKmdTG53FapgKi16xBtu1 AkgYDubI7drSm0knbggRDe08uP+3JUK/FgEaf+/SY0nKHjCiv/k2ii+SUbjFXv55PYaJisEj0 X-Google-Smtp-Source: AGHT+IEL1BD9+Du9D+743p6TnPjZK4dZjQkt17WH2n1saN0b30s+UjZMBKK0XpYKO1CmHHf6QiQR3hatMZAqiw07DhE= X-Received: by 2002:a05:6e02:20eb:b0:3a7:81dd:d0ad with SMTP id e9e14a558f8ab-3c2d2568d69mr1810065ab.7.1734634631583; Thu, 19 Dec 2024 10:57:11 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202412131306.4BDD6bxu011253@gitrepo.freebsd.org> <9afbf270-0cc0-4fd0-8975-6b88aadd3903@FreeBSD.org> In-Reply-To: From: Ed Maste Date: Thu, 19 Dec 2024 13:57:00 -0500 Message-ID: Subject: Re: git: a1097094c4c5 - main - newvers: Set explicit git revision length To: Brooks Davis Cc: John Baldwin , Gleb Smirnoff , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4YDftK0y8mz4JZ0 X-Spamd-Bar: ---- Addressing John's other point: > > I guess is that how many other user git settings can affect the build? Should > > we not require an empty global git config as a prereq for someone who wants a > > reproducible build (and use the same setup for our official builds) and say > > that if you adjust your user config to impact the build that's kind of your > > problem? I think if the user adjusts their git config in a way that changes file content (e.g. scripted $FreeBSD$ expansion as was discussed early on in the git migration) that's their problem. Config that affects the output format of the command does need to be addressed. This is really no different to our build's use of things like `env -i LC_COLLATE=C sort` which we already do. Usage in newvers is the only Git usage I'm aware of that we need to address.