From nobody Wed Dec 18 21:21:24 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YD67P1tRbz5gx61; Wed, 18 Dec 2024 21:21:37 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YD67P09jQz55G4; Wed, 18 Dec 2024 21:21:37 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-3a81324bbdcso533635ab.1; Wed, 18 Dec 2024 13:21:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734556896; x=1735161696; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=beryF4TW9ubuGG+GmK5J2qrK82o02wfdcsgCRSNfJ38=; b=oRze5asgXJ20J+n/yUGlRvjj/75+Mdoxo8zaTENfXOZ93cGY02QpXdRiNL7KZTWGhE Vs6JQodk++ekG9eSvbJf5s1n9ddzNrheoyZFdbW9bL9kvMxSQfKk6rP+MOrbATrXIRUB B/WpLoZIif9Q8wmsW8JAaIQ35kIlQDszyR8nJbKtsZyp+qbgBKin/tv5egEs+EuvZVpN tlugmHkVrtnf9wWmONzsFlnyzpMoU8YbjYZj0M6E71JP9K6t0xGOaAoeefDecQcZvOAe sOWdNV22FXwGZyNhzDsOBW0cZ2m9vAFA9MeVTDDbDXI7AvYpCWYblH0xVPzAKKapZ3E6 XqFA== X-Forwarded-Encrypted: i=1; AJvYcCVpM3eyfdeiOdvAVWfRmPFc6X95BhqEE3Qk2CszIvG/qMmA4s5quUgX9HrqLpaM+nHonoyh3l1rqPzCeoWcjkarmYWR@freebsd.org, AJvYcCW2Ytj/BhkK9nWXvQGewCQh6dK0iwirBzUVdF6h+zUcsMz3XmdsuimSgg6nlbNKnS6EDxATLjHzIPQaudxcoT8=@freebsd.org, AJvYcCWxKsvnOg25sRTbX26NroqfZQum4OtuXBVixh/CX6Omalfg/W7GPw4G19w61yB5dHQDRCJDYeRfeScJ7fzUZ/kXX4PClWE=@freebsd.org X-Gm-Message-State: AOJu0YzgQ6RxlweLeCyXHLa5AJbfPEdmlhizsoqCgVkQ8I3h8Dz6lR33 tXv2deOl++9lZ1AFz3Fy0C7yQeJJt3mgar3pwueTg/6pEiQyfVyCnvGZJlvkmLFR5xVAggVvWMN 27RAqUaRBhnC3NELndDznmKjoxRsEbCsV X-Gm-Gg: ASbGnctPnZMbVaCRVSM4kdoLJmNjI1TwaXGpaVC0z478FXPj63jgz6epOlDbpB+0dMD qplgad1K1umEQ6IkgX5sAPmiTn5larYK2D9MjooEocxm6L3XcKdT8UHAWY18Jt5Ttur/Uchk3 X-Google-Smtp-Source: AGHT+IGA9MjR4BaN/TZF1RWDp0J9d//GlL3YjzeqR9gwN6nSZLwamnc7LYNPdSQAtVcDJ+Bppu775kQ2AWTsluOgm0k= X-Received: by 2002:a05:6e02:3b89:b0:3a7:dd45:bca1 with SMTP id e9e14a558f8ab-3c013b0716amr10838245ab.17.1734556895855; Wed, 18 Dec 2024 13:21:35 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202412131306.4BDD6bxu011253@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Wed, 18 Dec 2024 16:21:24 -0500 Message-ID: Subject: Re: git: a1097094c4c5 - main - newvers: Set explicit git revision length To: Gleb Smirnoff Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4YD67P09jQz55G4 X-Spamd-Bar: ---- On Wed, 18 Dec 2024 at 12:12, Gleb Smirnoff wrote: > > E> The status quo of --short=12 should be fine for quite some time. > > AFAIU John's concern is that you can't guarantee a reproducible build from a > "dirty" repository. A repository that has more branches than just the official > ones. I just make a quick check on Netflix repo, that has both the current > FreeBSD history and the before-the-official-git history together, as well as > splitted ports subdirectories and of course our own stuff. For short hashes > there are roughly 2x more ambiguities than for a "clean" repo. Apparently > chance of collision on a long hash is also doubled. I suspect the six or seven character hashes I listed are still unique in your repository. If not, adding one more character to get to seven or eight will be enough. Pick a release and give `git rev-parse --verify --short=1 ` a try in your repo -- I'm sure you'll get a unique short hash that's still much shorter than 12 characters.