From nobody Tue Dec 17 17:35:56 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YCPBM1SSNz5hVQn; Tue, 17 Dec 2024 17:36:43 +0000 (UTC) (envelope-from br@bsdpad.com) Received: from mail.bsdpad.com (mail.bsdpad.com [116.202.106.248]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4YCPBL6hGdz4Fs7; Tue, 17 Dec 2024 17:36:42 +0000 (UTC) (envelope-from br@bsdpad.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bsdpad.com; s=20201212; h=Subject:To:From; bh=jrh7TDeEfPc833p7VFK359+2QXwnwMIJBMgIGNfsIxk=; b=NszdEw5lPblw9hQEPfYOxQfuTK BfEnYV5bNuNdO/pHeAImz701xj5fEQj/+NxMYdTe9OTKMf3VlgmEDz/Nq9GfwXckdsAznydaZ4BY6 OKQcux53OTVMVmps4qddmrY49TpNlTFE0BxqXCaKugbE0HinlU/SfmSB623Fyw6fsmZ9P3OBha1h9 SRwlASU4ooR4eK/StwPtCp/a8J67keSj2If+2adPKTG2uEOlIjqK2PNnkOxx4VBUYGXsnU+UDpAs2 vwQ3R8vmj3y38BXH9TczOP8iMP+ravywWl9pnYhmWm/RqWQj1NjlNVbLIJTDjV1xVgApmyM4No9xv 3bKMDTuA==; Received: from localhost ([127.0.0.1] helo=bsdpad.com) by mail.bsdpad.com with smtp (Exim 4.94 (FreeBSD)) (envelope-from ) id 1tNbUD-00049o-0G; Tue, 17 Dec 2024 17:35:57 +0000 Received: by bsdpad.com (nbSMTP-1.00) for uid 1001 br@bsdpad.com; Tue, 17 Dec 2024 17:35:57 +0000 (GMT) Date: Tue, 17 Dec 2024 17:35:56 +0000 From: Ruslan Bukin To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 56816e687557 - main - riscv: Eswin hwreset support added. Message-ID: References: <202412171147.4BHBlAs7010565@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:116.202.0.0/16, country:DE] X-Rspamd-Queue-Id: 4YCPBL6hGdz4Fs7 X-Spamd-Bar: ---- On Tue, Dec 17, 2024 at 02:39:00PM +0000, Jessica Clarke wrote: > On 17 Dec 2024, at 11:47, Ruslan Bukin wrote: > > > > The branch main has been updated by br: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=56816e68755725371ac89dc5aa882fdce46605a5 > > > > commit 56816e68755725371ac89dc5aa882fdce46605a5 > > Author: Ruslan Bukin > > AuthorDate: 2024-12-17 11:35:08 +0000 > > Commit: Ruslan Bukin > > CommitDate: 2024-12-17 11:46:10 +0000 > > > > riscv: Eswin hwreset support added. > > > > Add reset controller driver for Eswin EIC7700. > > > > This one has two reset cells in FDT, which is unusual, so provide a > > custom hwreset_map method. > > > > Tested on SiFive Premier P550. > > > > Reviewed by: mhorne, jrtc27 > > I gave one review comment, I didn’t get to approving it. Are you > writing these manually rather than using (git-)arc?... > > Jess > I apologize. I'm using git arc. The comment you left resulted to a positive impact on the code so I decided to indicate you as well, despite you did not press Accept. Ruslan