From nobody Mon Dec 16 14:45:29 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YBjRG08Qbz5hWKy; Mon, 16 Dec 2024 14:45:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YBjRF5HPYz4cmT; Mon, 16 Dec 2024 14:45:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734360329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lJ/LNvEdaYlKHxSgAJeYG31CbKupDiWDH0OcXxyYj/Y=; b=cHeTnKuE07dm0MyDSlRlH7Fc3FP/CGlvVDdx4Z7eijqiP/9G/wyK6kdGv553eQQESjhnr6 449Raq1DEVXdtp6lAHpIBMwvle/BJTXxidCiWUTsvsytMeK3NAsPgypGTIxUwyE9mzmt9D ft+DJNdN/HiQxybMcNYeDlcKBDJ0MJglNg5wmIBv4v/FoifM2iFtmAEsf0OI/prNV3ylrl beMXRsFetlA0I34/LXWRhT+Kc3tXEiwu8P9KUaVnEwAX2r3eLOQMfn/7hc1a8KyEdnY7VV XK3AvhHbBmSKx947bkf7p2BvVmCm9MnkVU9lx6vZLgPoUxV4d9kAWUut69/pGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734360329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lJ/LNvEdaYlKHxSgAJeYG31CbKupDiWDH0OcXxyYj/Y=; b=ufHaFd45LzNjZhW4UrqOTfkIqCY0u+Ng2XWsmRmVpEuCOn9d6voXwA4GbzI4f4W+mopFbH uiR5YCsKWnXpve67YSpYhsnKK3+FcpCXAHdndqW71l3zVuos5Ld+MOzlPa0DIgKlf7ExCx Yp+CG9DZaZbK03qOSTYZDAVL+mZhTuHRxdFKyAx0/RIuS+tpJ2afU8uF/N6srjiKmO0Ni3 /24OSNPF+QFMTtwiFi6EOWpRLboW4m421AhueZXdVHt5ne59DkUvF4q/pcPMvjwAuBPyi2 epTh1R0nZjiwNUibu+wVII879UPHt2hrE0VBXz56Pvdb9/mrSkNeZox/0u9FKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1734360329; a=rsa-sha256; cv=none; b=nGz/LNc656Hy40QvzwrIEYCczvnOWHuZjHtedLiuMXXT7Ai3a/lGSdjH1X739EaDh5Ke84 YoExZsznof/x5Ud1hfLAVYAV6UeHu4CdDRvp3hKu+BQjmfUNVAuEg4WcSdTY6Rmhs7Hg7K /9FkeUhzH/1KXlUhLA3pCPC6/mNtH3DEGT6yGP+hsyU77Px6FxZvlyTfsgFlfXWO9uUpzb YR+DKeLkugVh0JVQaj8h7neGzmArD6t7DivCSKZSoPH6mT7dM0nlyRiUl/v2waUaHStZKE EMcVVKbmd8l/FmI6AvHbf50S5qymYFiFAaGa3McTG1HFjJJz1KpEM7vaZ4ZxoQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YBjRF4ntMzxnJ; Mon, 16 Dec 2024 14:45:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BGEjT9o052110; Mon, 16 Dec 2024 14:45:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BGEjTEY052107; Mon, 16 Dec 2024 14:45:29 GMT (envelope-from git) Date: Mon, 16 Dec 2024 14:45:29 GMT Message-Id: <202412161445.4BGEjTEY052107@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 0b011b5cddb5 - main - mountd(8): parsecred(): Remove comment on non-existent bug List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0b011b5cddb5b17cf5b8f50ff580f3eb4abaeeef Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=0b011b5cddb5b17cf5b8f50ff580f3eb4abaeeef commit 0b011b5cddb5b17cf5b8f50ff580f3eb4abaeeef Author: Olivier Certner AuthorDate: 2024-10-08 09:44:06 +0000 Commit: Olivier Certner CommitDate: 2024-12-16 14:42:31 +0000 mountd(8): parsecred(): Remove comment on non-existent bug 'name' can never be NULL, as it is equal to 'names' and 'namelist', which was passed by do_cred() only if the actual parameter wasn't NULL. Reviewed by: rmacklem Approved by: markj (mentor) MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D47014 --- usr.sbin/mountd/mountd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/usr.sbin/mountd/mountd.c b/usr.sbin/mountd/mountd.c index 76a5fc6fae93..653d7135ef79 100644 --- a/usr.sbin/mountd/mountd.c +++ b/usr.sbin/mountd/mountd.c @@ -3632,7 +3632,6 @@ parsecred(char *namelist, struct expcred *cr) */ names = namelist; name = strsep_quote(&names, ":"); - /* Bug? name could be NULL here */ name_ul = strtoul(name, &end, 10); if (*end != '\0' || end == name) pw = getpwnam(name);