From nobody Wed Dec 11 23:08:29 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y7rqx45xzz5gcCH; Wed, 11 Dec 2024 23:08:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y7rqx3b9gz43s8; Wed, 11 Dec 2024 23:08:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733958509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Nd1of46UL2lPWdzwDAzxKGQ8pyMEF8Su+M3miBCfVm0=; b=Opr85fyffFSPTwV9vXc+0OJ3mpPeNzaQfqqLQ6ome/gTAC6qzIdmwgOnCCDCLBzc8P0tQJ HUWNYcL8W+z9DaVNY02Q6zild9+tQmDmSROB6TJWXFPHrF2/e8yv0lmnIiteWD0bcPRQwq s3iR8p5mfDZQff+bleM2jxD69HK5BlPXlaJEXZm70/0tMOnoJ4t/mVfnXGCW+I+naV9wmM CNlTO7wRUQTbriLSA2eTbiOSa3J7VdfN8R/KUsZaQ9J7rIfw5zvVt6o+/ITIIi31q9oPHw K7PYq2dgP9n0kki8jOLUQSFsUB5/VpEMzcteIHNZlbgc9+AbkV0aysjgdGVN0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733958509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Nd1of46UL2lPWdzwDAzxKGQ8pyMEF8Su+M3miBCfVm0=; b=EFFEMgfH/Gu5PRkJv9U+sS6Xoez840atD6N3W2RJo6pTAkezVPICeUdoJLGG4ohkHwRgqr CALR5zyBS3Rh2D/eWSk5rJOMUCBe26XjQU2SwazNSseezudyHdgu57ltRD9ETEBTOpwYb2 HqJ3jY+yYAsSM2zX5suoaVLB9bwzQoJ72XI90f9+Ifn7JZ0P1Z5YkgeKSPtbJIMKqGASRO uWOV78WXHfiBBPsSAhxB7jYwSvOehDS8pycaMBXayInE5cMRTk3CJfSBhQ4iLXwAa1ueLr KoFFeMXolKT/o+5jhPVL/FRJ6BalwY3CUntRkoz27WatiGLcrFEjF7as+jT6gA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733958509; a=rsa-sha256; cv=none; b=aaRwiFHnp9bnORqeKqU2HwDVahRCzUPBmL/OmLP+FqB2oeuFfA5CxaWaAJx2lb83nr0xX3 QPkDCj1wXks5xSav+lWRG6hMOzPB4jyfhNCDmIF5gbT48gIVeYzUxlyr33Q9mO1PAWujk+ VZ4oMbZf84hm3STwtinrSRTMFkHD0t7bKXuQna/QObdcE1Q6j3RimwnPPDiWIDlOOjRCIl sIKA7wf04ztO4DWWRfksm5egQBXLa7la0R++HNQN/yWxkrPEyptWbPcbl6bFiyE6QZ3dC1 OpbbdZt5LxdeKlM8vR50Al8wL7XTqUrLJVHmowEJONgO8OBWY2d9lPq+ASciyg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y7rqx3BpmzS95; Wed, 11 Dec 2024 23:08:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BBN8T0r046687; Wed, 11 Dec 2024 23:08:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BBN8TW8046684; Wed, 11 Dec 2024 23:08:29 GMT (envelope-from git) Date: Wed, 11 Dec 2024 23:08:29 GMT Message-Id: <202412112308.4BBN8TW8046684@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 0e8a36a2ab12 - main - mount_nfs.c: Add an NFS mount option to set a port# for Mount List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0e8a36a2ab1223ffb0cbdfd49383d8cf978cfa74 Auto-Submitted: auto-generated The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=0e8a36a2ab1223ffb0cbdfd49383d8cf978cfa74 commit 0e8a36a2ab1223ffb0cbdfd49383d8cf978cfa74 Author: Rick Macklem AuthorDate: 2024-12-11 23:07:05 +0000 Commit: Rick Macklem CommitDate: 2024-12-11 23:07:05 +0000 mount_nfs.c: Add an NFS mount option to set a port# for Mount Normally mount_nfs acquires the port# for the NFS server's Mount protocol (mountd(8)) via rpcbind/portmapper for NFSv3 mounts. This patch adds a new mount option, so that the mount command can specify the port# and avoid using rpcbind for NFSv3 mounts. The new option is called "mountport" since that is what Linux calls their mount option for the same semantics. PR: 282481 Reviewed by: delphij Tested by: Ronald Minnich MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D47743 --- sbin/mount_nfs/mount_nfs.c | 56 ++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 49 insertions(+), 7 deletions(-) diff --git a/sbin/mount_nfs/mount_nfs.c b/sbin/mount_nfs/mount_nfs.c index e4c469eff0ae..189bdd70b398 100644 --- a/sbin/mount_nfs/mount_nfs.c +++ b/sbin/mount_nfs/mount_nfs.c @@ -108,6 +108,7 @@ static u_char *fh = NULL; static int fhsize = 0; static int secflavor = -1; static int got_principal = 0; +static in_port_t mntproto_port = 0; static enum mountmode { ANY, @@ -360,6 +361,13 @@ main(int argc, char *argv[]) softintr = true; } else if (strcmp(opt, "intr") == 0) { softintr = true; + } else if (strcmp(opt, "mountport") == 0) { + num = strtol(val, &p, 10); + if (*p || num <= 0 || num > IPPORT_MAX) + errx(1, "illegal port num -- " + "%s", val); + mntproto_port = num; + pass_flag_to_nmount=0; } if (pass_flag_to_nmount) { build_iovec(&iov, &iovlen, opt, @@ -900,11 +908,47 @@ tryagain: return (TRYRET_SUCCESS); } + /* + * malloc() and copy the address, so that it can be used for + * nfsargs below. + */ + addrlen = nfs_nb.len; + addr = malloc(addrlen); + if (addr == NULL) + err(1, "malloc"); + bcopy(nfs_nb.buf, addr, addrlen); + /* Send the MOUNTPROC_MNT RPC to get the root filehandle. */ try.tv_sec = 10; try.tv_usec = 0; - clp = clnt_tp_create(hostp, MOUNTPROG, mntvers, nconf_mnt); + if (mntproto_port != 0) { + struct sockaddr *sad; + struct sockaddr_in *sin; + struct sockaddr_in6 *sin6; + + sad = (struct sockaddr *)nfs_nb.buf; + switch (sad->sa_family) { + case AF_INET: + sin = (struct sockaddr_in *)nfs_nb.buf; + sin->sin_port = htons(mntproto_port); + break; + case AF_INET6: + sin6 = (struct sockaddr_in6 *)nfs_nb.buf; + sin6->sin6_port = htons(mntproto_port); + break; + default: + snprintf(errbuf, sizeof(errbuf), + "Mnt port bad addr family %d\n", sad->sa_family); + return (TRYRET_LOCALERR); + } + clp = clnt_tli_create(RPC_ANYFD, nconf_mnt, &nfs_nb, MOUNTPROG, + mntvers, 0, 0); + } else { + /* Get the Mount protocol port# via rpcbind. */ + clp = clnt_tp_create(hostp, MOUNTPROG, mntvers, nconf_mnt); + } if (clp == NULL) { + free(addr); snprintf(errbuf, sizeof errbuf, "[%s] %s:%s: %s", netid_mnt, hostp, spec, clnt_spcreateerror("RPCMNT: clnt_create")); return (returncode(rpc_createerr.cf_stat, @@ -914,10 +958,10 @@ tryagain: nfhret.auth = secflavor; nfhret.vers = mntvers; clntstat = clnt_call(clp, MOUNTPROC_MNT, (xdrproc_t)xdr_dir, spec, - (xdrproc_t)xdr_fh, &nfhret, - try); + (xdrproc_t)xdr_fh, &nfhret, try); auth_destroy(clp->cl_auth); if (clntstat != RPC_SUCCESS) { + free(addr); if (clntstat == RPC_PROGVERSMISMATCH && trymntmode == ANY) { clnt_destroy(clp); trymntmode = V2; @@ -932,6 +976,7 @@ tryagain: clnt_destroy(clp); if (nfhret.stat != 0) { + free(addr); snprintf(errbuf, sizeof errbuf, "[%s] %s:%s: %s", netid_mnt, hostp, spec, strerror(nfhret.stat)); return (TRYRET_REMOTEERR); @@ -941,13 +986,10 @@ tryagain: * Store the filehandle and server address in nfsargsp, making * sure to copy any locally allocated structures. */ - addrlen = nfs_nb.len; - addr = malloc(addrlen); fhsize = nfhret.fhsize; fh = malloc(fhsize); - if (addr == NULL || fh == NULL) + if (fh == NULL) err(1, "malloc"); - bcopy(nfs_nb.buf, addr, addrlen); bcopy(nfhret.nfh, fh, fhsize); build_iovec(iov, iovlen, "addr", addr, addrlen);