From nobody Wed Dec 11 17:47:50 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y7jjy5DSRz5gFk4; Wed, 11 Dec 2024 17:47:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y7jjy4hxgz4LCg; Wed, 11 Dec 2024 17:47:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733939270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+zZtVEW2dTM1SsmpG0X34hbFworx4hKTDgJR+ioSrWU=; b=ndODUHN2q9mm15t9rjfbw32za0xlomYgsm73L6okC0VWMQmEYSUhRbD/7PPZOws/jyszdu NezWaeT3c+Z3y2kUaLW9sFmvT7OC3OL438M+gOthsyawT7lDktd677k+W7tp5omCdVWupK YqVkJnsdP6xtyrwsz2mp2L1y2KuKXn1lOC0a+a8hU8BXj0G+LrOcwRQ+qCoHAVj5qXVVih oT840w3mc4vLVzj0+/NE8ijj5wdYbNbEvYxEr4QbdbLz4crG6uI7LNAkb8tNZrFW/BbFTJ fChKr7bco3yk1SX0Khy+I/gHFKbmNqwXt9p/T+GOE75/dYMSImLAMTaZAFcXsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733939270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+zZtVEW2dTM1SsmpG0X34hbFworx4hKTDgJR+ioSrWU=; b=lRsjIgsFHBZc9QEE9T/++mRlnI9c5vPm9WwAkAypMgkcVZ4u4tBluY4He21Fe+XlidsaVv rXeiH5kTkJmwTHO2lLdmkpuK6Hl3sMvyUvFBpQ355EsJrEtzngEcTCFJbDpaB8PWn+ByaZ fBY8iHpbfWwn3/y+DUJL83y+FFwWa8PXR7EbOdlmmpWSQXiSHNpOlYyGEzps9uSTAVvnZA QFyLzZ6hNnaglnqi/HobcxEfnN4g6uymdO7aNryEJpRCkIuu3Bo27Da/ftV5dafJXRFFdb mqFMeJdT2OWM+Mwyh3qXPWJ9xzCfV+FuXrwEg2VOnR+Pnf1Aue5KPaUrbvFQ7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733939270; a=rsa-sha256; cv=none; b=WzC7lyPzXwjJBGoqWjB4FyXUoozYlC+tv7S42nzBAJggGd9Bdps3HqZbPf+AnM4UwpcnCQ sGvlLTHlJBfVD9slw+ckFQ7pNfvkdS7svZ0ENytm31Z/SJQ+i9r8ZYKNB5saeBTUbG5i/D rWBTjXWOPXODg1PJ+E/y+Pr1QwlR2aX+Om4cOwP4EoVO1tL1/epLe+Jwce5xDNCUee5Mdm eDbvK2TxGKBB/umM8MZCqP8JiQGsNXrAWMta+8QKcdyO/OzGBEb1ug1eXvKgI5X7TFZ/qp UaN1W6DE0OKIyUXTfFe9bu8XPhakLKJCBA6oUi+5Gfc6WAafEJbvtUKd4QdDMA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y7jjy4G25zHQ7; Wed, 11 Dec 2024 17:47:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BBHloK4049193; Wed, 11 Dec 2024 17:47:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BBHloZj049190; Wed, 11 Dec 2024 17:47:50 GMT (envelope-from git) Date: Wed, 11 Dec 2024 17:47:50 GMT Message-Id: <202412111747.4BBHloZj049190@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: 37bb465d27ee - main - buf_ring: Remove an unneeded barrier List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 37bb465d27eefd2237e6e3af9592457fccf324e2 Auto-Submitted: auto-generated The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=37bb465d27eefd2237e6e3af9592457fccf324e2 commit 37bb465d27eefd2237e6e3af9592457fccf324e2 Author: Andrew Turner AuthorDate: 2024-12-11 15:15:25 +0000 Commit: Andrew Turner CommitDate: 2024-12-11 17:02:24 +0000 buf_ring: Remove an unneeded barrier This was left over from before using atomic(9) consistently. It is unneeded as these loads are already ordered correctly. Reviewed by: alc, kib Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D48002 --- sys/sys/buf_ring.h | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/sys/buf_ring.h b/sys/sys/buf_ring.h index ab7e683ed0e9..00870cbf3531 100644 --- a/sys/sys/buf_ring.h +++ b/sys/sys/buf_ring.h @@ -107,7 +107,6 @@ buf_ring_enqueue(struct buf_ring *br, void *buf) cons_tail = atomic_load_acq_32(&br->br_cons_tail); if ((int32_t)(cons_tail + br->br_prod_size - prod_next) < 1) { - rmb(); if (prod_head == atomic_load_32(&br->br_prod_head) && cons_tail == atomic_load_32(&br->br_cons_tail)) { br->br_drops++;