From nobody Tue Dec 10 22:50:02 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y7DTN4hN0z5gjZx for ; Tue, 10 Dec 2024 22:50:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y7DTN2Gdnz4gmn for ; Tue, 10 Dec 2024 22:50:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-7fc8f0598cdso77613a12.1 for ; Tue, 10 Dec 2024 14:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1733871014; x=1734475814; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LzYAaosPG2tTYy7HcFqfYoiKW4lOHDQnwXatPQ23NRk=; b=XTD2kMP70lN0/Q8FJMZBwR6eSWO80ocb1fjDluS6kcI266MvJne2325T8/kPavob9c GQ6tV1EZmX4ftNIokoXqPq//dvDEfCww4ya/j5EMVl3ze9ljfzdtWJ3PGQMKPIyPok7R 7ydt27VzL1XSoyufzdUGiER8zZgaUKOX5MgJaC9uRocCtdDlQ4vYMVp8U6WRx3Hln+GZ 4Y+E3aHpgsNu1sCiIy49N0jjOiPFyzDSJhJtQ23TduhfL4dUDtFdWc0rT1CePV/w8Gix flNcIjE84b5UamTzLhMSYNg0vCkv7lTXVcMKWCN3fS0+3SKlBspN4LWnY15mIhgW6p+C kacA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733871014; x=1734475814; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LzYAaosPG2tTYy7HcFqfYoiKW4lOHDQnwXatPQ23NRk=; b=IKki9qdj9bCU0p+K077fATYlRrBI4MhTn6kQcwylIhxd1vogk8L6pTml7IRYkdDmlZ HgEynB1RiwEKD21xVGC6n7rKxBeEibuUuGjmL378zbuTQoLJJLBU22X//4eSK7urtmSj IQ7SNHXxa1VBLPmNJONB6Gu7qihJxJVCbqrs8f5of4X7rBAKkmMUYs4rS2VSdmihr6I9 RKrnUtCo6rXzGhjLOMiJZxRbRYr11PFfbTJweoXokmWcrQFDoixpvxuQOkv/kVpJyhLa LeQJmI1lND4qp/2MfkjduKnJsDTLLVynaF8QVYKpgXrlmhG4ZxGCmffwJEEtkQPUS3RU gkYA== X-Forwarded-Encrypted: i=1; AJvYcCXg4FkkIQt75nwiRteWLehg8TshnBdykpmhL68YXHLoBDvQqvSLECeXd39kbXIq+/krWuiOKLUOLlqlDfCMQL/h4Ip6kg==@freebsd.org X-Gm-Message-State: AOJu0Yy9Yfqvhq0zvUjeVH99Y3FNpynxFDy5442VKmzDsb9b7DruAV2g mfJbjxsRxTcaUp+EdyTd/ZjqpUIZUKHouJpwkZnlMNAhTgItbW85GA9luEwzwDdL+S77BbodIvx Cg8XxbuGE0lO5Z3NsOuB3rMrTUBIYayEx18/9rw== X-Gm-Gg: ASbGnctBoLSXVV6I6+doz9LoqFCi1SZHghen82hiSpYebntcs9cSjOun+Ka5Jjpt0ic 1MX+6xqbAHRws+h4WKVOqXBx9CJ4ZUmuQQVg45J+fVkPLlt6ZygA44aOa2ZhdOsjQ+A== X-Google-Smtp-Source: AGHT+IGonA3Xqz/+c8ebrd0wToRMdw5xrC/hxMiGA0hS7An8/RKdxZzmym/uDMa60UXGb9WAWo6wEDaBqRkjHpLdluQ= X-Received: by 2002:a17:90b:1347:b0:2ee:5c9b:35c0 with SMTP id 98e67ed59e1d1-2f1287ab9b9mr789437a91.9.1733871014422; Tue, 10 Dec 2024 14:50:14 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202412091447.4B9ElFBH050286@gitrepo.freebsd.org> <6F9C2C43-A3DD-4CF5-AC27-899FE139E9A6@freebsd.org> <0883q825-802q-2n9q-3s4o-3nq13qpqno71@SerrOFQ.bet> In-Reply-To: From: Warner Losh Date: Tue, 10 Dec 2024 15:50:02 -0700 Message-ID: Subject: Re: git: 87e140a5c6f8 - main - iwlwifi: avoid (hard) hang on loading module To: Ed Maste Cc: "Bjoern A. Zeeb" , Jessica Clarke , src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000e6cca30628f24d1b" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Y7DTN2Gdnz4gmn X-Spamd-Bar: ---- --000000000000e6cca30628f24d1b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 10, 2024, 3:09=E2=80=AFPM Ed Maste wrote: > On Mon, 9 Dec 2024 at 20:55, Bjoern A. Zeeb wrote: > > > > On Mon, 9 Dec 2024, Jessica Clarke wrote: > > > > > On 9 Dec 2024, at 14:47, Bjoern A. Zeeb wrote: > > >> > > >> The branch main has been updated by bz: > > >> > > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=3D87e140a5c6f89eea7ea6320d1ae3456= 6492abfc0 > > >> + if (bootverbose) > > >> + printf("%s: module '%s' not yet available; will be" > > >> + "initialized in a moment\n", __func__, op->name); > > > > > > Missing a space in the string. > > > > Thanks; I'll add that. > > Or just allow the line to go beyond 80 columns, allowing someone to > grep for "will be initialized in a moment" to find the source of this > string. > It's either in style.9 as a length exception or is in a review somewhere... it make it easier to grep the error messages... Warner > --000000000000e6cca30628f24d1b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Dec 10, 2024, 3:09=E2=80=AFPM Ed Maste <emaste@freebsd.org> wrote:
On Mon, 9 Dec 2024 at 20:55, Bjoern A. Ze= eb <bz@freebsd.org> wrote:
>
> On Mon, 9 Dec 2024, Jessica Clarke wrote:
>
> > On 9 Dec 2024, at 14:47, Bjoern A. Zeeb <bz@FreeBSD.org> wr= ote:
> >>
> >> The branch main has been updated by bz:
> >>
> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D87e140a5c6f89eea7ea63= 20d1ae34566492abfc0
> >> + if (bootverbose)
> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0printf("%s: module '%s&#= 39; not yet available; will be"
> >> +=C2=A0 =C2=A0"initialized in a moment\n", __func__= , op->name);
> >
> > Missing a space in the string.
>
> Thanks; I'll add that.

Or just allow the line to go beyond 80 columns, allowing someone to
grep for "will be initialized in a moment" to find the source of = this
string.

It's either in style.9 as a length exception or is in a review s= omewhere...=C2=A0 it make it easier to grep the error messages...

Warner=C2=A0
--000000000000e6cca30628f24d1b--