From nobody Sat Dec 07 07:15:00 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y4zsd70JMz5gfFb; Sat, 07 Dec 2024 07:15:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y4zsc1SyDz49TN; Sat, 7 Dec 2024 07:15:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733555700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AqZE6h+qRNirNacz6MJOSbdzKNYd7R4GqpS42kj4y5s=; b=px/Eia9JDAn4wezBLtAUT76NMe8nTqpHEuZPh02Yx1Sg7CyfsAxS5LlpHUTmg6mRq3ohQS +KZNPJ0RHVFuXVP9SuaS+dx3PB27PuwGjR0GWh4dDiy4lTCfDmYgsj8jZSwhyhqnLrQEjM b4gyEVNsAhan77UQDRg2ZrxwI2zqJAzwl5RKtt900GZ8qlKY7YL4ZP1M6r9+iyQ3KOKUsT HgcRqAowgmqxysxEEeyVoufefbaqCdNXptlhvOxkILuZcPW+HNyvLXbsL0drg0gh8glXl5 4qQHG5gox1WBmqpgZfgEH1qqHNFFS6OdWb6sf9j4LRj4eKV71NdhqNzdU8ShEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733555700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AqZE6h+qRNirNacz6MJOSbdzKNYd7R4GqpS42kj4y5s=; b=RStHjNcnSKHEAAquc7XROpCzJ31NN7Fy8CH/8Q6rJ+UqlqH/Z722BwdRCt8S5iQvgJuGNC TuB+DdwBEs/QXVLQ4ZWSFFflnzwCh5IhAGpEQH6ed2sunZ7iZ1UFSqfCNxP+J5PMXjKGtz swfMVqqU20rej4I7+QFPw6dhXHGYKOpcc8OqDQFPlRV4BpahxXeeUxwoOdXbTsSsMrK4Z4 NqmF3yCkgkuAebT5EQOY7aT7MnA2jVMLsg+qCdSo2RoQBWH5+XLBPkVtGtqiuQ5Ixfdd0c 6GE4gXvoMPArsOMZtZryam59zAItsBpQa10HoshbVhoLdTP2GT6G7ZcifD0P8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733555700; a=rsa-sha256; cv=none; b=YfpjFVjq/YogHlz+YhlbWnwLL7mbU+S/Qrino2BDXXviMc7VNfry0vAhFxykeRiWhJFFDh U1OgKh/iEVIwe62qxq+BYiqAgmE5PNoy5NVQOK/zVy5KGPaQJVHVwI5if67QjJJapuGgx/ VwPsaxOpEiGL5URhEq1iHMSw3tRt2YVDcUR1SDIDq457fDSb5hYBUYugiobPBIdTQfZPuk 6t1uJlWcU9KpU+vg+4YYC2bsYOAjpKkiyC/PnmBdbiVSsR59jG6/nBsstS/ZIL361aZSzC j0E9xxNyEjwd8diHzIGR+djSeJnIKZsITrW4puYRsbSj6cTrF7ZaLudH6ylZwg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y4zsc0vSlz1CXr; Sat, 7 Dec 2024 07:15:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4B77F0cu058649; Sat, 7 Dec 2024 07:15:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4B77F0Ph058646; Sat, 7 Dec 2024 07:15:00 GMT (envelope-from git) Date: Sat, 7 Dec 2024 07:15:00 GMT Message-Id: <202412070715.4B77F0Ph058646@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: 977679d651de - main - rtwn: remove unused rate configuration code for management traffic. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 977679d651de56720892868ec429b90e90e2ee20 Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=977679d651de56720892868ec429b90e90e2ee20 commit 977679d651de56720892868ec429b90e90e2ee20 Author: Adrian Chadd AuthorDate: 2024-12-06 03:55:06 +0000 Commit: Adrian Chadd CommitDate: 2024-12-07 07:14:45 +0000 rtwn: remove unused rate configuration code for management traffic. After discussion with the rtlwifi maintainers, it looks like this path isn't even used. (And it's part of the firmware rate control path which we currently don't enable for other reasons.) Differential Revision: https://reviews.freebsd.org/D47938 --- sys/dev/rtwn/rtl8192c/r92c_fw.c | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/sys/dev/rtwn/rtl8192c/r92c_fw.c b/sys/dev/rtwn/rtl8192c/r92c_fw.c index e611e5addeb3..426dfd0e6d3f 100644 --- a/sys/dev/rtwn/rtl8192c/r92c_fw.c +++ b/sys/dev/rtwn/rtl8192c/r92c_fw.c @@ -170,30 +170,6 @@ r92c_send_ra_cmd(struct rtwn_softc *sc, int macid, uint32_t rates, uint8_t mode; int error = 0; - /* XXX should be called directly from iv_newstate() for MACID_BC */ - /* XXX joinbss, not send_ra_cmd() */ -#ifdef RTWN_TODO - /* NB: group addressed frames are done at 11bg rates for now */ - if (ic->ic_curmode == IEEE80211_MODE_11B) - mode = R92C_RAID_11B; - else - mode = R92C_RAID_11BG; - /* XXX misleading 'mode' value here for unicast frames */ - RTWN_DPRINTF(sc, RTWN_DEBUG_RA, - "%s: mode 0x%x, rates 0x%08x, basicrates 0x%08x\n", __func__, - mode, rates, basicrates); - - /* Set rates mask for group addressed frames. */ - cmd.macid = RTWN_MACID_BC | R92C_CMD_MACID_VALID; - cmd.mask = htole32(mode << 28 | basicrates); - error = rtwn_fw_cmd(sc, R92C_CMD_MACID_CONFIG, &cmd, sizeof(cmd)); - if (error != 0) { - device_printf(sc->sc_dev, - "could not set RA mask for broadcast station\n"); - return (error); - } -#endif - /* Set rates mask for unicast frames. */ if (RTWN_RATE_IS_HT(maxrate)) mode = R92C_RAID_11GN; @@ -283,7 +259,6 @@ r92c_joinbss_rpt(struct rtwn_softc *sc, int macid) end: #endif - /* TODO: init rates for RTWN_MACID_BC. */ if (macid & RTWN_MACID_VALID) r92c_init_ra(sc, macid & ~RTWN_MACID_VALID); }