From nobody Thu Dec 05 03:51:56 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y3gSY1ZB4z5fmYB for ; Thu, 05 Dec 2024 03:52:13 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic311-25.consmr.mail.gq1.yahoo.com (sonic311-25.consmr.mail.gq1.yahoo.com [98.137.65.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y3gSX122lz42Km for ; Thu, 5 Dec 2024 03:52:11 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=ipS9ar8t; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.65.206 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1733370729; bh=aYSMKvK5rbfRHoZltX4589LRLzzy9ZdDnSzIZXabeWs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=ipS9ar8teQv6RfQvvl5DSzwKbPTA/9NfsuTx7nq4x2am1FaD6c5i+ambsJa0Ix3G9MCeqM+nOGbgQlDoOlPB3334zOflUoWGgeXVj2c5IK4aFtafsRu91c14/1ZuWC7aRO0LdFow8GsZilHFw7HIayV1T2z3jhukkivQSkftJZO8EC/yidb25nGf8QP3aoIK84GBZZEZ77aCPFAo+HnC8o1O0nwl/Syn840i66et60jzQe9KE00r28FnxaS6EHFgcGs7CyPATdeYj8yjB5nDgC3ytO++Eeu4N6rkqpY/Z9t7AD4iteoCaKiXff9nXvIaS0D6b6fKMWWhF9uswJidPg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1733370729; bh=1ZLXwZIWSZsZco/ImbUofnbS50lexSziCFQVptZ6kji=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=mU2csMXIAGzM21X5sZurT49jCM3FLiZzaP4bgBnSz+j4IsJpp+tluQL0vobPzXmgoy+YsVGJR2rt9CxsfcWfYG4Ux49flymh7becyS+m8bHTB5m2dJWh3cmFoXqA+tWOrIIgx8ddpPwTCMRf4CRgVN2O6RZdrIHm/P0V+olFfMJsqWeuViyjFpco8ABbNouHin2PFxFKhVrJNtu1dDlEcShSMVIxJ7pWrt0YJzaMZCenRyhYtqLo7uRXfyQ8D5w6sImfYozk01nG7qacphbhD8alTUldnlEF1DX6RdJwRKzOaJDXLCxek3uF22RkW7bpM5A6tdl7iwbiaCFPy9AGCg== X-YMail-OSG: qVtV8dsVM1kFwS9kJT0Aaj4FHb4WMqdEqEbv7ncU4RJUmxyB9.GUpjGpMJ12SEj hAqPteU42HrV62kbyM4cCRvT9dLNqSlofx69_EOvRXYds76Mv0xsXTtccFSoDQuhJLYhubIKURtT UjkaHCXSQh8Wr23t6dRm4Fbjc55yWbPO.i2rMplZYwbUYmQo0DgIv7h27K97rrgHg7x8h9eaoo0r QCUkYfKE6A3bCbO0v.5FucjuhLsZt_aP2VAN0aQN5KinVBe09s8U2dO.Jsn4ze9tPRHuYURJQDWv wjSlpT8j9mbxu6HebKek52EZcm1oKFLvQdWPHTZQZypxcya..4znbMG1NFIOdQ5vl7f.FzuEKUiC bmXVyZalFyIAwE50WZYh.qYZ8PEn8uAICFE.YTN8Uh.ciQiQi0jBsQqdR1X5aylp6l7dEuxOS4Xf srmHpXc8xoO.4RVl28Pm7cN_DyR2ArkKBh3aBTWa4yi.NCztro1XTbgEeuaGhpnMEuhANNveRCYT q190Mzswr_w.3fQzCoJAvMT5hh_O4tEZTrD4ywHwwzzMBvS3QiEcJSxfZxCMztW.xjaVEBpAuweU HLgnp6DgoWNOR.r4Pq90pBHgzHqV3SO7OywKwsWdHFnubFfrzFpcAa6.CY.VU53jo3AMm0imsR6T iW_Pkci7YGTITImqwsmBECRG9JKl9.jAFeYm82LdONL_Xf9xy4kD7.rELvG12IzFa0XgVQDMXFBC KhE1dI5JpVe.1ccB5X5W5y7WLkPog4TKVWEvhRA1qvRnaStdhyLTh7aizfhC0vmG1ndmmVJEnd_3 5U1kYhgnco4LtoYG9Hv9ZLb7B6w7YL_tOQAznapaTdiPaiXFO3m9ALpn.BcsUDIXCFavkIfNABPD FDWk7wkT1ujuwjoicdrT0jJGkGeKDXrydjakrONFKLP.j6jLGPYkoftUVvqfNf.cdnfskG2sO7E9 Fq9d4FKHyS8gR.LBegt_uJ3H.9HJV8kp9Ais80vO2mGap3chHSUs4qrekiiULz776ba.eAUO_MRI mRXlZORwTta6XJcErQzgzED_lepr1ugniC5VrXvbBblJZMMncrkU4wKsi1rMp3_BmsiDR0MYAATl 88Lj7u9PcuFUF_HJ8LmADKIvnb00JqjYJk3JJjhlMu8HgBT4j2pdErJnwxd5TQZtyGBndOJlkZar TmwW6rldJJAE7ribpzrratdVStH11_i_H1OziGAbFIEMHbXOIQHpJ1Lyx0Za2frFWqlrhQlmgwhx 4mxYL3QvrDGwB73fJ_fw8dbRfhQg5XRoM.uYQBpccA1D1fQ0so1j4SSu2CE.lSHblT7RTXfX2HMU 3Xs99mTQkMa869LmAFykg0Ffoea9xwOAfZtbvs0xP35hNDK5PIayHfc.aAMVmt6Y0ewKVzrrABQF LbtAZgTgAa.CN_XscBWgeCpCwrEJNxdq4H7DVr6ok52RQxESylOD2y_iHBzrSYX0MY4zbfePvgSc WVTpsZz1IBPlvqnD_Ba5da9Jw6HXix3wclnAMusHXCl6.6ThsteDU5hFjjJAi3BnqsxD45RUjXmC ZU9.GYvUPMmtRNtAL3uPGRSTcPJM2J5F8OCY3f6wh2eCW2Wq5Eodh7RVJi1ryakIvT46SEZQftgP .LdwulR3RSugFiLMomhdM9lD497kdV9tf21Okt8jDjErIeDkIDzkwke51_FTPbq1Tzqujaa.ZjRh I_J4DC5JW2DA.LOJ50y6f0tAgxrSzTsT4YWtdZAdXH77Ch8JTx02v7SLllJKeWXAmgRnxmyOo9FG oOpNqyDozfz7q.o34W_C7kcSDASm2OO98SUqcgcra.iigvC4OFcBcUbYkNAoITeqB5CUvVr8ZMON fvJrfpNO_.nekbRdVYHPQMXZAOEKOomgVhpAK9ebxr.vsWzKJXnw8GTqxjSqMVD7CCbm6zrqr8VQ .tgM_uLJwXhuQwLnw8.ocUyUPkyDwgyDE.NzlwV9uNt6SkR3XJO5BGoTdzQnoCZvWrbH11P3y2_D MLU3Cgamh_y.sWWuqU9SnuGhb7yJswfPWnm0pPUUj0a7UEApyRpE_x4._5wlKF5STlEc9.qMi6Vn jj.cvxK1p7FmKbsfH8VOM3Ol3VGvIbJuvfBOLnuLdfoV0FO5_uvHtA5Eqqdg9gN1VamsTtnoDdDX _rCFdSdHpn2O5i1MPEgu3wtXzOxBcfdsgGHDrLG2Ez8lG3rZ8LZ5YyWGzbi0hNevoDqQDuWGNevD OyILo93gBMZGJN7UXkHwf.w0OcVjxxPCNHaN_9dzE2058_8HX277rcgMSEFRTM5PYGPtwfUYbkLo IYUoK0qXWkCBwYA-- X-Sonic-MF: X-Sonic-ID: 9252b1e5-1804-41c3-a9ea-4715d0c57d27 Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Thu, 5 Dec 2024 03:52:09 +0000 Received: by hermes--production-gq1-5dd4b47f46-5xsmt (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 98c3be432b9cc231b732fb9c588aed07; Thu, 05 Dec 2024 03:52:08 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\)) Subject: Re: git: b882d21558f3 - main - arm: link all .rodata variants into one output section From: Mark Millard In-Reply-To: <6088B065-8BA0-4D0B-8E08-706B634D5D91@yahoo.com> Date: Wed, 4 Dec 2024 19:51:56 -0800 Cc: Warner Losh Content-Transfer-Encoding: 7bit Message-Id: <6F21458C-6550-4070-BF4A-876CA3E8978A@yahoo.com> References: <6088B065-8BA0-4D0B-8E08-706B634D5D91@yahoo.com> To: mmel@freebsd.org, John Baldwin , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3776.700.51.11.1) X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; FREEMAIL_FROM(0.00)[yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.65.206:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.65.206:from] X-Rspamd-Queue-Id: 4Y3gSX122lz42Km X-Spamd-Bar: --- [I appearently never sent the below at the time.] On Nov 20, 2024, at 08:03, Mark Millard wrote: John Baldwin wrote on Date: Wed, 20 Nov 2024 14:52:06 UTC : > On 11/19/24 08:02, Michal Meloun wrote: >> >> >> On 19.11.2024 16:15, John Baldwin wrote: >>> On 11/17/24 03:36, Michal Meloun wrote: >>>> The branch main has been updated by mmel: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/? >>>> id=b882d21558f37e6a565694ac9b8f2a519e5b86fa >>>> >>>> commit b882d21558f37e6a565694ac9b8f2a519e5b86fa >>>> Author: Michal Meloun >>>> AuthorDate: 2024-11-17 11:28:47 +0000 >>>> Commit: Michal Meloun >>>> CommitDate: 2024-11-17 11:35:55 +0000 >>>> >>>> arm: link all .rodata variants into one output section >>>> MFC after: 1 week >>>> --- >>>> sys/conf/ldscript.arm | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/sys/conf/ldscript.arm b/sys/conf/ldscript.arm >>>> index d9edcfac9f78..7cf904ce39ff 100644 >>>> --- a/sys/conf/ldscript.arm >>>> +++ b/sys/conf/ldscript.arm >>>> @@ -17,7 +17,7 @@ SECTIONS >>>> _etext = .; >>>> PROVIDE (etext = .); >>>> .fini : { *(.fini) } =0x9090 >>>> - .rodata : { *(.rodata) *(.gnu.linkonce.r*) } >>>> + .rodata : { *(.rodata*) *(.gnu.linkonce.r*) } >>>> .rodata1 : { *(.rodata1) } >>> >>> Is this line now spurious or do linker scripts prefer more exact matches? >>> >>>> .interp : { *(.interp) } >>>> .hash : { *(.hash) } >>> >> Right hit. I want write { *(.rodata) *(.rodata.*) *(.gnu.linkonce.r*) } >> >> Warner already tried to tell me the same thing, but I didn't get it :( >> Btw arm64 has the same problem. >> >> This gives me another question. Who generates the .rodata1 section? This >> section appeared in gnu ld three decades ago, with no real description. >> Do we still need it? > > I have no idea if we still need .rodata1 (or why it exists), I was just > reading the diff of the linker script. Looking around at examples on the web I'm seeing mostly the likes of the following for analogous text: .rodata : { *(.rodata .rodata.* .gnu.linkonce.r.*) } .rodata1 : { *(.rodata1) } (and somewhat similarly for .data.*) I saw some examples of *(.rodata.str1.4) for examples that lacked use of .rodata.* , giving some idea what would be expected to match the .* part of the pattern. === Mark Millard marklmi at yahoo.com