Re: git: 3ee87f8a4d7a - main - stress2: Use tests as the default test user.
Date: Wed, 04 Dec 2024 15:57:24 UTC
On Wed, Dec 04, 2024 at 04:32:52PM +0100, Dag-Erling Smørgrav wrote: > Peter Holm <pho@FreeBSD.org> writes: > > Dag-Erling Smørgrav <des@FreeBSD.org> writes: > >> The branch main has been updated by des: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=3ee87f8a4d7a56c846d356d028e77bd72a0e1fbb > >> > >> commit 3ee87f8a4d7a56c846d356d028e77bd72a0e1fbb > >> Author: Dag-Erling Smørgrav <des@FreeBSD.org> > >> AuthorDate: 2024-12-04 13:07:05 +0000 > >> Commit: Dag-Erling Smørgrav <des@FreeBSD.org> > >> CommitDate: 2024-12-04 13:12:43 +0000 > >> > >> stress2: Use tests as the default test user. > >> > >> This allows some tests to run without prior configuration; others will > >> have to be modified to use `su -m` since the tests account is locked. > >> > >> Reviewed by: allanjude > >> Differential Revision: https://reviews.freebsd.org/D47875 > > Please back this out. > > No. Please revert shortly, or I will. > You had your chance to object in Phabricator and didn't take it. He said in the review that the change doesn't work for him. Peter is effectively the sole author of stress2 and has been running it continuously for many years. Look for "Reported by.*pho" in the commit logs. If he says it doesn't work, then that's an objection. > This may not fully solve the problem but it's still an improvement over > the current situation. Feel free to submit a review that fixes the > remaining issues.