Re: git: 2f915345634e - main - LINT: Remove DTrace support

On 12/2/24 11:39, Kristof Provost wrote:
> The branch main has been updated by kp:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=2f915345634e9e0f809f79581359190268908ba9
> 
> commit 2f915345634e9e0f809f79581359190268908ba9
> Author:     Kristof Provost <kp@FreeBSD.org>
> AuthorDate: 2024-11-27 16:57:08 +0000
> Commit:     Kristof Provost <kp@FreeBSD.org>
> CommitDate: 2024-12-02 19:36:35 +0000
> 
>      LINT: Remove DTrace support
>      
>      Ensure we have at least one commonly built kernel config that does not include
>      DTrace.
>      This is intended to help detect issues such as 45d108ee14 where a variable is
>      only used for static probe point, resulting in build failures when DTrace is
>      disabled.
>      
>      Sponsored by:   Rubicon Communications, LLC ("Netgate")
>      Differential Revision:  https://reviews.freebsd.org/D47821
> ---
>   sys/x86/conf/NOTES | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/sys/x86/conf/NOTES b/sys/x86/conf/NOTES
> index ffd90c06b516..bb45d4ecbf92 100644
> --- a/sys/x86/conf/NOTES
> +++ b/sys/x86/conf/NOTES
> @@ -2,12 +2,6 @@
>   
>   # Common NOTES between i386 and amd64
>   
> -#
> -# Enable the kernel DTrace hooks which are required to load the DTrace
> -# kernel modules.
> -#
> -options 	KDTRACE_HOOKS
> -

For cases like this we generally leave the option in but comment it out so that
NOTES is still documenting the option and the syntax for enabling it.

>   # DTrace core
>   # NOTE: introduces CDDL-licensed components into the kernel
>   #device		dtrace

^^^ Like this

-- 
John Baldwin