From nobody Mon Aug 19 15:24:18 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wnbx26t64z5TChx for ; Mon, 19 Aug 2024 15:24:22 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wnbx251M2z43hc for ; Mon, 19 Aug 2024 15:24:22 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-7a1e0ff6871so294508385a.2 for ; Mon, 19 Aug 2024 08:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724081062; x=1724685862; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=lZW245F1E9PSmF5CdT/1o7SrUVoY+sDtbtLn1bE+Lcw=; b=cEsA4PxdDB6PNkknfslKPJ993dwjIvKvTAtHEdvyyX5gUlKfPlWII2IjjnN0+IamHY /pUlttofKEV6iPxJoADcyyUM74I1SlkR5EXJesagcJ8fPM7rzzBK+HxBt9aSVldn0y9N x2B1ofCG4mEsCl2chre+EL6Jt4bO72vyYpD0Jw+H9s/ocnkPL5NVOJfyg43lXyuPswGt Apgy0IoMC1BoKapAamnzKK5Epc6le4w2Z/bAm34jq6fVdaeqHtMUJ1bE38Iv9rcOYGcj Saz/8sGEIJMDJvsnrAalqNkVn3cUMetDHjYLb7MivlLX5oAjw4Q7pzEdKDFYs/CmBdSP THig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724081062; x=1724685862; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lZW245F1E9PSmF5CdT/1o7SrUVoY+sDtbtLn1bE+Lcw=; b=ECCLqzNgF/Rk/eS2BGm/sYYp3XX5Mh33rvcvnFcpUD9m06n00NIsGIM9CGeQ9iAu9E bEYYFfPgTMP0qLHGlITFT6k7g9c7Qa3QyAgxDgmVUucmgnMFMs+ItU//cfIP6KSMZSBi WwYh+fH5lH2n6MhIo42t3yX4VIOZ7HL7EeoGVnRJm9YpvCNeyHrcPbhMO8thDOzyH+L/ MLrP+bEZHLVe1qGZ305lFfcQN7CVgFimgti4St5MbKTvM6orYA9FnfhTX2ftpxnJkYiu zP3m5l06N8cj5wIFQKp+m3NoR3lSkEOOc9f762ZeLfKnOYqgcPHDqtkf7TsCeG3K2Ioy pt3Q== X-Gm-Message-State: AOJu0YyiwFrUA+q411A2lU1Mt/k6q/YLAxT30OBwkPxyXIlodXWtFVgk vBKJNbKPZRXFLXlf8LrgWCpNo/MYWXQnXLXdoonPvlGfV20JLSBp8gBgDA== X-Google-Smtp-Source: AGHT+IGAi3aCjFbPdtyJ/mqLDW2laoQ8qPMo7qshWBEHBnqBkH2pmZ7IiH8T6usvNiOnL3z6WfjzvA== X-Received: by 2002:a05:622a:5a8f:b0:44f:e5fd:4643 with SMTP id d75a77b69052e-454b682fad4mr84791601cf.24.1724081061709; Mon, 19 Aug 2024 08:24:21 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4536a072267sm40656901cf.81.2024.08.19.08.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 08:24:21 -0700 (PDT) Date: Mon, 19 Aug 2024 11:24:18 -0400 From: Mark Johnston To: Mark Millard Cc: dev-commits-src-main@freebsd.org Subject: Re: git: d7d5c9efef03 - main - pkgbase: Let source packages be built in parallel Message-ID: References: <7B9F6ED4-4906-43CC-860F-DB4AA3FD44D9.ref@yahoo.com> <7B9F6ED4-4906-43CC-860F-DB4AA3FD44D9@yahoo.com> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7B9F6ED4-4906-43CC-860F-DB4AA3FD44D9@yahoo.com> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Wnbx251M2z43hc On Mon, Aug 19, 2024 at 08:12:57AM -0700, Mark Millard wrote: > Mark Johnston wrote on > Date: Mon, 19 Aug 2024 14:37:37 UTC : > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=d7d5c9efef031aa11a841d1836f7c937dcbe4ec8 > > > > commit d7d5c9efef031aa11a841d1836f7c937dcbe4ec8 > > Author: Mark Johnston > > AuthorDate: 2024-08-19 14:08:05 +0000 > > Commit: Mark Johnston > > CommitDate: 2024-08-19 14:37:27 +0000 > > > > pkgbase: Let source packages be built in parallel > > > > To build the packages target, we build src and src-sys packages > > containing the source code from which the repo was built. These > > packages take significantly longer than the others, presumably because > > they contain many more files. Because both source packages are built > > to satisfy the same target, they end up being built serially. Split > > them into separate subtargets so that they can run in parallel. This > > saves a couple of minutes on my build machine. > . . . > > For parallel execution of the 2 targets below, aren't > the following "rm -f" commands racy relative to the > later *.plist generation activity in each of the > ". . ." sections of code ? Yes, thank you. I believe this patch is sufficient: https://reviews.freebsd.org/D46320 > create-source-src-package: _pkgbootstrap .PHONY > rm -f ${SSTAGEDIR}/*.plist 2>/dev/null || : > . . . > . . . > ${SSTAGEDIR}/src.plist > . . . > > create-source-src-sys-package: _pkgbootstrap .PHONY > rm -f ${SSTAGEDIR}/*.plist 2>/dev/null || : > . . . > . . . > ${SSTAGEDIR}/src-sys.plist > . . . > > === > Mark Millard > marklmi at yahoo.com >