From nobody Thu Aug 15 20:10:17 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WlGT404tcz5SnPH; Thu, 15 Aug 2024 20:10:32 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WlGT31fYLz41Ks; Thu, 15 Aug 2024 20:10:31 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=asomers@gmail.com Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-492959b906eso510918137.0; Thu, 15 Aug 2024 13:10:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723752629; x=1724357429; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fb12BNKKjdwbuTRTo9AUUp+L34hoe4Mp9DjmEpZ0+hs=; b=Sh1Wf2B7lwoBcxCyGXxKDqY6j6wEioUJFU/qs9vlHcEzKtErNgfbA1O9+Nk+34dOEH en3POigXOGxILpyhJK4J4jEWblFf9rEIPVsCax84sHYiMf8qokBzsEErbGDCkcm7YbUL FGrgjMdV2mGQXAp8GPugx/bQ2v4B6v4e17rj+2QQj99kTu+4iSNj1vBklSCXDeJ9MeN6 EtuYf/OogQeG6+oG9SoqzxkBiLDPSikirAAU4nIFe9Hav81lc3kqN/xJmXxcl78jsD+E 27HHMkoIsNQNfzg+Rfawuob01JOVUV8/FN67mOlgLCH5EZ4KuuT545JO3YS2gs5vQhdN J03A== X-Forwarded-Encrypted: i=1; AJvYcCX/9WNwjfe8cWrF00IvHD0Zt4szZ66NhgKlfnwEs0LX5AACV3jJNT82c/k9K6sAKQw9uBFGWEv0/4DAT3w5aA5A57/OjsCicgtGLaFoqRM64o+LlMtPCbOwvgnNwXOTCKvvUiXF0YLkMjUMl0t+JmWe/HBu2SzWf0A7rMY7FGobt7X/RrX9FAoDGfSsKZQ= X-Gm-Message-State: AOJu0YxH4ZyULfni8KtkICBvh6ykYvREHQCGsMr4598bYcFGSWzmUR4X CifW0KWz3OCHVdPc4zZmWsgqzo7tmrMpNC5IWxoCuf3QyYp8ox4KQash+StU4Qj3UZscqCAFuNH MhIcGi4Zaauvh/ZYrpgNiTpfi5JUjsg== X-Google-Smtp-Source: AGHT+IGfxz19J9+ulXz6mNHWKMF832zC/YWeYD5WzgQixZqLSLK+nRYdaK8YAawaYo8GDH0DxDrHp8/EKINW+EMOyvg= X-Received: by 2002:a05:6102:441f:b0:48f:ebc3:a006 with SMTP id ada2fe7eead31-4977994fd57mr1468143137.15.1723752629234; Thu, 15 Aug 2024 13:10:29 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202101170021.10H0LZEk066670@gitrepo.freebsd.org> <202101170057.10H0vqp6056258@slippy.cwsent.com> In-Reply-To: From: Alan Somers Date: Thu, 15 Aug 2024 14:10:17 -0600 Message-ID: Subject: Re: git: b7ab6832cd98 - main - cat: disable building it with Casper To: Mariusz Zaborski Cc: Cy Schubert , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.40 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-0.80)[-0.801]; NEURAL_HAM_SHORT(-0.70)[-0.702]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; FREEFALL_USER(0.00)[asomers]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.217.54:from]; RCVD_IN_DNSWL_NONE(0.00)[209.85.217.54:from]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4WlGT31fYLz41Ks According to the comment, this change was supposed to be temporary. But it's been in place for 3.5 years. Can it be reverted now? On Sat, Jan 16, 2021 at 6:07=E2=80=AFPM Mariusz Zaborski wrote: > > Hello, > > Seems like your cat.o wasn't rebuild. > Did you use NO_CLEAN flag? > It seems to work on: > https://github.com/freebsd/freebsd-src/runs/1715237892 and on my > machine. > > Can you try doing: > make buildenv > cd bin/cat > make clean > make > > Thanks, > Mariusz > > On Sun, 17 Jan 2021 at 01:58, Cy Schubert wro= te: > > > > In message <202101170021.10H0LZEk066670@gitrepo.freebsd.org>, Mariusz > > Zaborski > > writes: > > > The branch main has been updated by oshogbo: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Db7ab6832cd988aff7f4e46= 8e507c314d > > > d7641638 > > > > > > commit b7ab6832cd988aff7f4e468e507c314dd7641638 > > > Author: Mariusz Zaborski > > > AuthorDate: 2021-01-17 00:04:28 +0000 > > > Commit: Mariusz Zaborski > > > CommitDate: 2021-01-17 00:21:46 +0000 > > > > > > cat: disable building it with Casper > > > > > > We want to measure what are the actual cost of sandboxing cat(1). > > > > > > Requested by: mjg, cy, Mike Karels > > > Discussed with: rwatson, markj > > > --- > > > bin/cat/Makefile | 13 +++++++------ > > > 1 file changed, 7 insertions(+), 6 deletions(-) > > > > > > diff --git a/bin/cat/Makefile b/bin/cat/Makefile > > > index abfdcbcfbb2e..cce69d8aad9e 100644 > > > --- a/bin/cat/Makefile > > > +++ b/bin/cat/Makefile > > > @@ -15,11 +15,12 @@ CFLAGS+=3D-DBOOTSTRAP_CAT > > > HAS_TESTS=3D > > > SUBDIR.${MK_TESTS}+=3D tests > > > > > > -.if ${MK_CASPER} !=3D "no" && !defined(RESCUE) && !defined(BOOTSTRAP= PING) > > > -LIBADD+=3D casper > > > -LIBADD+=3D cap_fileargs > > > -LIBADD+=3D cap_net > > > -CFLAGS+=3D-DWITH_CASPER > > > -.endif > > > +# Temporary disable building cat with Casper. > > > +#.if ${MK_CASPER} !=3D "no" && !defined(RESCUE) && !defined(BOOTSTRA= PPING) > > > +#LIBADD+=3D casper > > > +#LIBADD+=3D cap_fileargs > > > +#LIBADD+=3D cap_net > > > +#CFLAGS+=3D-DWITH_CASPER > > > +#.endif > > > > > > .include > > > > > > > Hi, > > > > Almost there. > > > > ld: error: undefined symbol: cap_init > > >>> referenced by cat.c:154 (/opt/src/git-src/bin/cat/cat.c:154) > > >>> cat.o:(main) > > > > ld: error: undefined symbol: fileargs_cinit > > >>> referenced by cat.c:158 (/opt/src/git-src/bin/cat/cat.c:158) > > >>> cat.o:(main) > > > > ld: error: undefined symbol: cap_service_open > > >>> referenced by cat.c:131 (/opt/src/git-src/bin/cat/cat.c:131) > > >>> cat.o:(main) > > > > ld: error: undefined symbol: cap_net_limit_init > > >>> referenced by cat.c:135 (/opt/src/git-src/bin/cat/cat.c:135) > > >>> cat.o:(main) > > > > ld: error: undefined symbol: cap_net_limit_name2addr_family > > >>> referenced by cat.c:141 (/opt/src/git-src/bin/cat/cat.c:141) > > >>> cat.o:(main) > > --- all_subdir_kerberos5 --- > > --- libheimntlm.so.11.debug --- > > objcopy --only-keep-debug libheimntlm.so.11.full libheimntlm.so.11.debu= g > > --- libheimntlm.so.11 --- > > objcopy --strip-debug --add-gnu-debuglink=3Dlibheimntlm.so.11.debug > > libheimntlm.so.11.full libheimntlm.so.11 > > --- all_subdir_lib --- > > --- init_test --- > > (cd /opt/src/git-src/lib/csu/tests/dynamic && DEPENDFILE=3D.depend.ini= t_test > > NO_SUBDIR=3D1 make -f /opt/src/git-src/lib/csu/tests/dynamic/Makefile > > _RECURSING_PROGS=3Dt PROG=3Dinit_test ) > > --- all_subdir_bin --- > > ld: error: undefined symbol: cap_net_limit > > >>> referenced by cat.c:143 (/opt/src/git-src/bin/cat/cat.c:143) > > >>> cat.o:(main) > > > > ld: error: undefined symbol: cap_close > > >>> referenced by cat.c:168 (/opt/src/git-src/bin/cat/cat.c:168) > > >>> cat.o:(main) > > > > ld: error: undefined symbol: fileargs_open > > >>> referenced by cat.c:263 (/opt/src/git-src/bin/cat/cat.c:263) > > >>> cat.o:(scanfiles) > > > > ld: error: undefined symbol: fileargs_realpath > > >>> referenced by cat.c:441 (/opt/src/git-src/bin/cat/cat.c:441) > > >>> cat.o:(scanfiles) > > > > ld: error: undefined symbol: cap_getaddrinfo > > >>> referenced by cat.c:444 (/opt/src/git-src/bin/cat/cat.c:444) > > >>> cat.o:(scanfiles) > > > > ld: error: undefined symbol: cap_connect > > >>> referenced by cat.c:468 (/opt/src/git-src/bin/cat/cat.c:468) > > >>> cat.o:(scanfiles) > > cc: error: linker command failed with exit code 1 (use -v to see invoca= tion) > > *** [cat.full] Error code 1 > > > > make[4]: stopped in /opt/src/git-src/bin/cat > > > > make[1]: stopped in /opt/src/git-src > > > > make: stopped in /opt/src/git-src > > exiting RC=3D2: building amd64 > > > > > > -- > > Cheers, > > Cy Schubert > > FreeBSD UNIX: Web: https://FreeBSD.org > > NTP: Web: https://nwtime.org > > > > The need of the many outweighs the greed of the few. > > > >