From nobody Sat Aug 10 00:20:45 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WghJm35jwz5SrxH; Sat, 10 Aug 2024 00:20:56 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WghJl6zd6z57rT; Sat, 10 Aug 2024 00:20:55 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723249256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gx94AKPonInaHeo1vb+DBSK0zrrsgGR5b8oY54SwW5M=; b=rdkqWJ5ZTxrmri5lp7SGzCTNH+wjN2HZ160JkVGRQzXo6ICFlPlM5cx1HmY3kThqB/5Udh YE5Ckflz6p1EjexO6Pfe7Nc74JkUOwZ3LBvu2zztRLiz/IpXtM2NSVw0tCcrYvhZC3GFuQ a0qJIK9pTBTjxtdpKaVQ5v4DRYzQP8Quhjr1wtMxHcsRikUriYU+RssJB21wauCvMRUHNh 4Rr7yOr9BvacznhdXeIGdOYioa9zXSyQKYY7JHTVrD+xNTgEks6RqSW6MBsg2K0PyKMq+9 EoFJc1PsFtBDq2tn1wYBbA8KhunptQ6KtWOoio9lxZE9TO0dClpHC4uQkidJwA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723249256; a=rsa-sha256; cv=none; b=VK1vo35GqzyBiIxIgmKZKq+2PVGeBe5O86E/x0qOXMvMO5WylY1ZFcWFeMqPpz4YP35Fyn 5pai/jDP/jB1SezcUUQRXdMTtx0LT5fKW7nnk0JzfYMVmFVw1S8eZIo9qmhO9Fy6fdKadE OdUrmtUn2vNhpqqFLTVOxBuraYu6YjA3wGCm/y7vBtRvd2r51X2zsA07ERmpnqGCrQ5+2q UDWRq/h3tdDhItJOvIhhGQuf5uf+F0JJqX70NjYSRgletBGH2XEiBAXM7kZnwkmh5K8GxI oEI40ySvTNAq4UKzcI+l3lzbp5Cu9QK7GTyVmTClq95lcBIwtRKuYHbi2sI0tA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723249256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gx94AKPonInaHeo1vb+DBSK0zrrsgGR5b8oY54SwW5M=; b=pqp4v2p/SN15Zp7IyhEHfDEjq/ZmUZO4KiPmIXBirYSjYIDVR96/QZKKtG2+kg4H1HIEjP 9cP4UNKLXqJsDsNAvL3ZfgT3rn01ozGQZ1MTzBGdvm1EM67kfNtQ5GPiYpEtt3r4HExr6a 5dTGp84e47+IUrbhfTV3m1vZRIWN3sLC+r1peGsqGGYxcU+GGLkpQOQKT3Rlsre/EPz3dG G1jjRekrYm/1c9x6Y3hvjMqhNviPIaPzmkxZOWaHZyLZoJYpZx8aZYiyg4EYAzGhHXk7hy 1iCVXQieB0J1aGo16MWqYRoJumPELZdVwuqBMR3u3fO7bg5gmMcJNL9ZNJN2KQ== Received: from smtpclient.apple (unknown [IPv6:2001:19f0:6001:9db:98f0:9fe0:3545:10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WghJk4PV8zhGY; Sat, 10 Aug 2024 00:20:54 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.8\)) Subject: Re: git: 9b569353e0b0 - main - tcp: initialize V_ts_offset_secret for all vnets From: Zhenlei Huang In-Reply-To: <202408091415.479EF480062250@gitrepo.freebsd.org> Date: Sat, 10 Aug 2024 08:20:45 +0800 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202408091415.479EF480062250@gitrepo.freebsd.org> To: Michael Tuexen X-Mailer: Apple Mail (2.3696.120.41.1.8) > On Aug 9, 2024, at 10:15 PM, Michael Tuexen = wrote: >=20 > The branch main has been updated by tuexen: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D9b569353e0b073a513cf10debbe634c2= ceb29fdf >=20 > commit 9b569353e0b073a513cf10debbe634c2ceb29fdf > Author: Michael Tuexen > AuthorDate: 2024-08-09 14:12:22 +0000 > Commit: Michael Tuexen > CommitDate: 2024-08-09 14:12:22 +0000 >=20 > tcp: initialize V_ts_offset_secret for all vnets >=20 > Initialize V_ts_offset_secret for each vnet, not only for the > default vnet, since it is vnet specific. >=20 > Reviewed by: Peter Lei > MFC after: 3 days > Sponsored by: Netflix, Inc. > Differential Revision: https://reviews.freebsd.org/D46246 > --- > sys/netinet/tcp_subr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c > index 9e95a87b3596..9b5f2651fb35 100644 > --- a/sys/netinet/tcp_subr.c > +++ b/sys/netinet/tcp_subr.c > @@ -1465,6 +1465,7 @@ tcp_vnet_init(void *arg __unused) > VNET_PCPUSTAT_ALLOC(tcpstat, M_WAITOK); >=20 > V_tcp_msl =3D TCPTV_MSL; > + arc4rand(&V_ts_offset_secret, sizeof(V_ts_offset_secret), 0); Emm, does it have any (potential) security problems if not initialized ? = If yes then does it deserve an SA ? > } > VNET_SYSINIT(tcp_vnet_init, SI_SUB_PROTO_DOMAIN, SI_ORDER_FOURTH, > tcp_vnet_init, NULL); > @@ -1502,7 +1503,6 @@ tcp_init(void *arg __unused) > /* Initialize the TCP logging data. */ > tcp_log_init(); > #endif > - arc4rand(&V_ts_offset_secret, sizeof(V_ts_offset_secret), 0); >=20 > if (tcp_soreceive_stream) { > #ifdef INET