From nobody Wed Apr 24 00:29:04 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VPKc041kQz5JNyk; Wed, 24 Apr 2024 00:29:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VPKc03bn9z41fg; Wed, 24 Apr 2024 00:29:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713918544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J7QVpGARZBIGmb7NtUsGx8eWw0p6Lrjc3cq8ocyjO5k=; b=xasMov919lZR4ACRQARe9VtUl8FGGjeYQ7Mwrh6GLdLaruTb2fsR+/LVnay4F5MEpN0QiX Kax6KLOUUQnqCnj4gjl7HIaWM5Wg5xsmci9V4rIFjyHwFGUowhtFtJlUdRrgHrsNqpVfna qukpRVpUNvhYBc6o6KW0Z8ogLbWNXkOV4H5LzxSfF2pzw/+yJ7rfVf0mGwfl6r3Nhmrx0H 7VOI+n41u0+VkxYYkDiFu1PqBX+oGkbeZcaUOt5Tl3RcOTGlDGFdcPs845byA3EC7S2aPL OyfYAPZPS3H4o1u2ZuR3KvcXLPrbp5KEZ1MVEzRbgADdY0kVaUDI+eYheZPLaw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713918544; a=rsa-sha256; cv=none; b=msF45pMxy17eWr7kDBgySzX30wOSUyZ4dNohGeotasaE5ooEzp2QB4+Ocbg65fEC2AAmMy qLPUD0qgY0XBM7bad0csUAhTMYc9nkeJKxT01dS1EKO2VUilzok97pi8Sc3XIxeyd22Iw/ wQ14YRD+gOkwapiZks2vmd2rTzCMJvutFMJwe2cmRIoZYoGfaK5j/+vXWToK4ZulJIBaTA W0nvXCwP+rl7gUPBgn15+5LMu2GneHVxj0+TNuHiBYDTzyD0Bf0mhit6CX6aTKqy8eRiLW 7aK6Yv0Cs+71Zi/SnMREhkICa/wzpIgYUPtx0+MFG0uBxrGLDed6QO6yDj1fzw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713918544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J7QVpGARZBIGmb7NtUsGx8eWw0p6Lrjc3cq8ocyjO5k=; b=x7GGkhCfx2nCPNO0Qe2ds3PmL1Rz2k7PTu1NPVAoJypbaOYytnJGFJ8V+ncEi83Fjmv1PV t6sVv7xWqUJ/lt/CWS+2Xa7osEWxChjVvCl7wATetpcjmk7MGQ2LW22Vwmi4xmIrPSluj2 IR+gcl8RhrYs04KF4k+HAkAqdO1f5ACqPxqiqG2BKr3N1VtM7C4XA+0FH4k+2FYQjpAHiL h3uWIy21oXsExWeAo1qoh+7dFOL2+AJlyc26y74DpH/m3zvQ8p1vvOxo+rv422t0yXUeUP 02Koz3Vmb+9vnIi77Di0X8uZHkAyRkgyBgrmCmVosCScXRABKu6UgbPEo8+2KA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VPKc03CZWztLn; Wed, 24 Apr 2024 00:29:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43O0T4U4051389; Wed, 24 Apr 2024 00:29:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43O0T4jF051386; Wed, 24 Apr 2024 00:29:04 GMT (envelope-from git) Date: Wed, 24 Apr 2024 00:29:04 GMT Message-Id: <202404240029.43O0T4jF051386@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jake Freeland Subject: git: f239db4800ee - main - ktrace: Remove CAPFAIL from default trace points List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jfree X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f239db4800ee9e7ff8485f96b7a68e6c38178c3b Auto-Submitted: auto-generated The branch main has been updated by jfree: URL: https://cgit.FreeBSD.org/src/commit/?id=f239db4800ee9e7ff8485f96b7a68e6c38178c3b commit f239db4800ee9e7ff8485f96b7a68e6c38178c3b Author: Jake Freeland AuthorDate: 2024-04-24 00:26:14 +0000 Commit: Jake Freeland CommitDate: 2024-04-24 00:26:14 +0000 ktrace: Remove CAPFAIL from default trace points The CAPFAIL tracepoint was recently extended to report ECAPMODE capability violations for processes that do not enter capability mode. This allows developers that are interested in Capsicumizing their programs to determine where violations are being raised. Previously, CAPFAIL only produced output for processes using Capsicum(4) capabilties. Thus, most ktrace users never received log output from the trace point. With the recent changes, this is no longer the case. Having this trace point enabled by default will produce output for all processes that use syscalls that are not permitted in capability mode. This may lead to confusion for users that are not familiar with the feature. Remove KTRFAC_CAPFAIL from ktrace's default points to avoid this. Approved by: markj (mentor) Reviewed by: markj MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D44887 --- usr.bin/ktrace/ktrace.1 | 2 +- usr.bin/ktrace/ktrace.h | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/usr.bin/ktrace/ktrace.1 b/usr.bin/ktrace/ktrace.1 index 5ccb206456b8..da39aac7800f 100644 --- a/usr.bin/ktrace/ktrace.1 +++ b/usr.bin/ktrace/ktrace.1 @@ -137,7 +137,7 @@ trace requests .It Cm + trace the default set of trace points - -.Cm c , i , n , p , s , t , u , y +.Cm c , i , n , s , t , u , y .El .It Ar command Execute diff --git a/usr.bin/ktrace/ktrace.h b/usr.bin/ktrace/ktrace.h index 1022f06532b1..bf3f70539310 100644 --- a/usr.bin/ktrace/ktrace.h +++ b/usr.bin/ktrace/ktrace.h @@ -31,13 +31,12 @@ #define DEF_POINTS (KTRFAC_SYSCALL | KTRFAC_SYSRET | KTRFAC_NAMEI | \ KTRFAC_GENIO | KTRFAC_PSIG | KTRFAC_USER | \ - KTRFAC_STRUCT | KTRFAC_SYSCTL | KTRFAC_CAPFAIL | \ - KTRFAC_STRUCT_ARRAY) + KTRFAC_STRUCT | KTRFAC_SYSCTL | KTRFAC_STRUCT_ARRAY) #define PROC_ABI_POINTS (KTRFAC_PROCCTOR | KTRFAC_PROCDTOR) -#define ALL_POINTS (DEF_POINTS | KTRFAC_CSW | PROC_ABI_POINTS | \ - KTRFAC_FAULT | KTRFAC_FAULTEND) +#define ALL_POINTS (DEF_POINTS | KTRFAC_CAPFAIL | KTRFAC_CSW | \ + PROC_ABI_POINTS | KTRFAC_FAULT | KTRFAC_FAULTEND) #define DEF_TRACEFILE "ktrace.out"