From nobody Tue Apr 23 19:34:21 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VPC4F2Qk8z5Hwcv; Tue, 23 Apr 2024 19:34:37 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VPC4F0BNpz4f3Y; Tue, 23 Apr 2024 19:34:37 +0000 (UTC) (envelope-from delphij@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3476dcd9c46so4552570f8f.0; Tue, 23 Apr 2024 12:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713900873; x=1714505673; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5oQy2wNwh+0orEsg0qyWPlCjL/huz+bTTa1yh00LnBM=; b=BZEhx/7nZWJBXZUebThg4cvL2dpyjmwoJFvNBmswP3KKbzclVZK9i8NmWW2wCLzn8c 7QsB2cVha/DD8Vt+/L4pC/8R+T4z8xTuII6rdHqIvQEZ4kt97rdz9ZnLgcXa+0WKTd+J 6Dx2ZRkwc96MOHb6koRtq4b6K2G8C5lz7z5oLu+vMXxfH8dh2hIQVkpeaAb0uftFpONu C7PfMJmCt1zEB0vCLEMPd5bO6wcfUZP07XQy6Bf2N4fBsO7GGnoF0WMGEoIiLBzNc2kx HqTH2DJ4ynSVb6OZm5KS5VCX6vY1MjfksaR43XL7LG+bU4aUCfl7DIom5lCAduXQ5kuf i6vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713900873; x=1714505673; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5oQy2wNwh+0orEsg0qyWPlCjL/huz+bTTa1yh00LnBM=; b=qJxm1oIc8si/DlBewxZn5fwUPG5vyyd+ZXEGgu9pnHRVyve/ddHEdqxi7VGcvrwotM d+Axvv2YGpTZoaxX3oRK7i7EYdKgeNLEHeMGHp/ylqUk6wvJTI592NLUljVdk/sOQ472 zc1Kt750lA6otKbhi0V0CHx2FtjYQBnXe1d36MN6DnfQwXljyYX14Cccdtz3BJSm2XMk 6+5/5KQ7M3p/cDvqJ8jvuEy2YZiKcwz5Wv8CW2Y1dt3SYPP3jLA983K/Bm8Y5aKzwZLe WCrnMQEEN5DuXrgLLNLSJ5/Id0LhRZkGeIfY6vMEa8OkP/E0Y8D3wK3jNU9qOrQ04CFY U4FQ== X-Forwarded-Encrypted: i=1; AJvYcCV4T2J0y+fecUBJURE4tyOznn93DJWzY9/UcoCDoBYoewjZeFhEAkEXgOCqBFg03ixm7qAiAu8DSma4D0UxQgkIjGz7BzZtXfHZI198g0q6qh5icOs9epp4MB5L6gOBND01aDbUafx8P8LVT8FPsolC0vBsVjxRyWbSwQc7eCFcGzQFjuqvwZWT/BaN2fRew3hiPsuEm1hgCXhPmhKsEJsvh3og8yk2mEAINTJYQGJY1Az6 X-Gm-Message-State: AOJu0YwY9DCU4+i2vNCPRveDbMTjoOuagYR6FwxVR4xCKGGWD7h0eBfT BVqXV68WysildFUEE53CiFu3pq+4GLw3hMBqzuZBS+OLXMTQ6B6X9xlTg08mN15aZVpefMMahU3 w+wH+auyUIuOg8RvMTWoJuHtGHk23hw== X-Google-Smtp-Source: AGHT+IF5o5BDdcxLRJmxmHIhLVWnzfrnM3DrU9pLDi6/18pZMU1ggiOakbMGven42Z2JRsQKF1/FHsMZ7+x5CnKouvY= X-Received: by 2002:adf:fe41:0:b0:345:5f6a:cc05 with SMTP id m1-20020adffe41000000b003455f6acc05mr132685wrs.34.1713900872958; Tue, 23 Apr 2024 12:34:32 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202404181915.43IJFEoG020480@gitrepo.freebsd.org> In-Reply-To: From: Xin LI Date: Tue, 23 Apr 2024 12:34:21 -0700 Message-ID: Subject: Re: git: 67783db661f8 - main - CONTRIBUTING: request only one submission type per change To: Gleb Smirnoff Cc: Lexi Winter , Ed Maste , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, imp@freebsd.org Content-Type: multipart/alternative; boundary="000000000000b68e410616c8a429" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4VPC4F0BNpz4f3Y --000000000000b68e410616c8a429 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Possibly slightly off-topic, but have we considered some other alternatives to Phabricator, like Gerrit ? (My opinion might be biased as we use Gerrit at $WORK). I liked the review UI more (the context representation is cleaner compared to Phabricator and one can easily navigate between different amendment revisions of one change), and it is integrated with Git with a customizable workflow (e.g. can have complex submit requirements, like a change must be approved by a different person, has to pass certain presubmit workflow, etc.) and is actively developed and maintained (both Android and Chrome makes heavy use of Gerrit). Cheers, On Tue, Apr 23, 2024 at 12:02=E2=80=AFPM Gleb Smirnoff wrote: > Lexi, > > On Thu, Apr 18, 2024 at 08:27:56PM +0100, Lexi Winter wrote: > L> as a non-committer src contributor, i've discussed this with imp@ quit= e > L> a bit and i think this should be phrased more strongly in favour of > L> using GitHub for commits. > L> > L> the current situation is that Phabricator is useless for non-committer= s > L> because 1) you have to know who can review your commit, and 2) once yo= ur > L> commit is reviewed, someone has to commit it, and Phabricator doesn't > L> address this. > > The 1) is actually not as bad. Phabricator has subscribtion hooks, and > many > committers have rules installed to get notifications of new reviews that > touch certain paths of code. > > The problem 2), IMHO, equally applies to github and Phabricator. > > L> i think it might make more sense to suggest that people submit all > L> patches via either GitHub or Bugzilla, and only use Phabricator if > L> specifically asked to. > > I don't agree here. Looks like we should address those phabricator > submissions that go unnoticed due to lack of maintainers of a code. > I don't think submitting same patch to github will improve visibility. > > > -- > Gleb Smirnoff > --000000000000b68e410616c8a429 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Possibly slightly off-topic, but have we considered some other= alternatives to Phabricator, like Gerrit?=C2=A0 (My opinion might be biased as we use Gerrit at $WO= RK).=C2=A0 I liked the review UI more (the context representation is cleane= r compared to Phabricator and one can easily navigate between different ame= ndment revisions of one change), and it is integrated with Git with a custo= mizable workflow (e.g. can have complex submit requirements, like a change = must be approved by a different person, has to pass certain presubmit workf= low, etc.) and is actively developed and maintained (both Android and Chrom= e makes heavy use of Gerrit).

Cheers,

On Tue, Apr 23, 2024= at 12:02=E2=80=AFPM Gleb Smirnoff <glebius@freebsd.org> wrote:
=C2=A0 Lexi,

On Thu, Apr 18, 2024 at 08:27:56PM +0100, Lexi Winter wrote:
L> as a non-committer src contributor, i've discussed this with imp@= quite
L> a bit and i think this should be phrased more strongly in favour of L> using GitHub for commits.
L>
L> the current situation is that Phabricator is useless for non-committe= rs
L> because 1) you have to know who can review your commit, and 2) once y= our
L> commit is reviewed, someone has to commit it, and Phabricator doesn&#= 39;t
L> address this.

The 1) is actually not as bad.=C2=A0 Phabricator has subscribtion hooks, an= d many
committers have rules installed to get notifications of new reviews that touch certain paths of code.

The problem 2), IMHO, equally applies to github and Phabricator.

L> i think it might make more sense to suggest that people submit all L> patches via either GitHub or Bugzilla, and only use Phabricator if L> specifically asked to.

I don't agree here. Looks like we should address those phabricator
submissions that go unnoticed due to lack of maintainers of a code.
I don't think submitting same patch to github will improve visibility.<= br>

--
Gleb Smirnoff
--000000000000b68e410616c8a429--