Re: git: 8993d785a261 - main - expand.1: Fix markup for the '-t' option

From: Gordon Bergling <gbe_at_freebsd.org>
Date: Tue, 23 Apr 2024 14:21:30 UTC
Hi des,

On Sat, Apr 20, 2024 at 09:40:26PM +0200, Dag-Erling Smørgrav wrote:
> Gordon Bergling <gbe@FreeBSD.org> writes:
> >     expand.1: Fix markup for the '-t' option
> >     
> >     When viewing the manpage the '-t' option is shown as follows
> >     
> >         -t -Sm tab1, tab2, ..., tabn Sm
> >     
> >     with the markup '\&Sm' included within '.It Fl t', which doesn't
> >     makes any sense.
> >     
> >     So just remove it.
> 
> You can't just remove the Sm, you need to add Ns before and after each
> comma to do what the Sm was intended to do.  This is why we have a patch
> review system, please use it.

I usualy always create differentials for changes, but I try to avoid them
for one-line changes. I have tested various combinations for the .Sm usage,
but I didn't saw any change in the manual page formating when removing the
macro, so that was the easiest thing to have the '-t' option not advertising
a none existing '-Sm' option.

--Gordon