From nobody Sun Apr 21 16:33:08 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VMv7m60ykz5HHQP; Sun, 21 Apr 2024 16:33:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VMv7m5HDQz4N87; Sun, 21 Apr 2024 16:33:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713717188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oxU4IMBbQTAGo85EdojjgZl5dN/pySUp6HjX9XRNlz8=; b=aUm95DzoeNJAm1QQvrU4O5KQcWEu1PA355/lLYF4AyWvB0UzKD9nYa+tC2RT5K7qc3bwYl vJrNMlH/bkfVQrPPgwC1cvcCq+fYi3DpRq58gXXbRZv23d5fDCfLSe8wP7H/12uqgP3Krs HTFf77eqolv95vQD3ZCyq70TlgpKa1251qp0JV8Zt4potyBba4RgmKsPOFUjDS0sNqS6FQ JqJAoU8c3kXXF9/zSR33if08EKc4Mu2hEpdRnn3BJYlwo7QNsvwo9dCAEmj68biWiM27zK cdb/z8k8Ugax3M2odJoR7h8DE/ZB6k49DWCcHD+T9ejPp1Vz/eh0eqSMON6IdA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713717188; a=rsa-sha256; cv=none; b=F6usDAAvXATiiJdiH5rFrQM/2Ges7fkQFYBc4PbFAVnzYpYI//0hMYvtrwxM4o8rtuXzuK iduFBj0YkmROSVxSFajk15Rm4Bb2v2ZP+7DnKbseJSSp7pIWWLGLUTBHspqutXBaabYS8b 2NG2vPfTV2GQ4DoiyoJR3ifcbRrL5ZONwtWtHLhkYe8/+PQ5a9CQINF0utruSuPaMipJBv J4jv/mw/aQGfjo1YzSr3PwJMb2l26O6IBojD8PiJP91i8iy8RDk8mcV20aagpJWOFH3jAU ecJTmfBkyq+P8AmZQfDFoGqQc+ewhzG3ImrgNykOOjCK4ZiUlJB4nKhq8slJSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713717188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oxU4IMBbQTAGo85EdojjgZl5dN/pySUp6HjX9XRNlz8=; b=rvaFP0vC9UT6IuFb3fbhMw5BeKHM3GR2Gxjm4nU7t0t5KL+dbuUn6zzfVqgYuKal6NeKoY pZsG7uiY1RvKSUSYmIvNucd03N1aCsBHqtPyhO2HW0zdQbRWyshLWw3tgW6w/t8Y/iO91c H44o9RsfxAP9uXoWE2w7dSDwgUXt1E8ts3xPKL8Y7nPI9wCV86hHlNtM2GAxqr1/HSVWRL QZHDF3hcJyKiLKht1eaL2suL1nfEZvEx2mQSVjuXJZvPp+mcbhwzsJeydZkbRIVLb+pX6i ODBUAY+myiUA+E6TzBzhxYtXS71ZNOweUYxmyJAYQm26Gae6paJxENe20iGSWA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VMv7m4sYfz1RgY; Sun, 21 Apr 2024 16:33:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43LGX8rx071645; Sun, 21 Apr 2024 16:33:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43LGX8Uv071642; Sun, 21 Apr 2024 16:33:08 GMT (envelope-from git) Date: Sun, 21 Apr 2024 16:33:08 GMT Message-Id: <202404211633.43LGX8Uv071642@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Enji Cooper Subject: git: b571bcea5495 - main - bsd.subdir.mk: improve `SUBDIR.${MK_FOO}` advice List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b571bcea5495327fd210378109b0b2aed08bebc3 Auto-Submitted: auto-generated The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=b571bcea5495327fd210378109b0b2aed08bebc3 commit b571bcea5495327fd210378109b0b2aed08bebc3 Author: Enji Cooper AuthorDate: 2024-04-21 16:27:48 +0000 Commit: Enji Cooper CommitDate: 2024-04-21 16:30:09 +0000 bsd.subdir.mk: improve `SUBDIR.${MK_FOO}` advice - Remove superfluous whitespace by removing trailing whitespace before `\` (line continuation character) - Quote `SUBDIR.` to clarify the fact that this is a variable reference--not the end of a sentence. --- share/mk/bsd.subdir.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/share/mk/bsd.subdir.mk b/share/mk/bsd.subdir.mk index 95a178c04907..565af41602c0 100644 --- a/share/mk/bsd.subdir.mk +++ b/share/mk/bsd.subdir.mk @@ -125,8 +125,8 @@ SUBDIR:=${SUBDIR:u} .endif .if defined(SUBDIR.) -.error ${.CURDIR}: Found variable SUBDIR. with value "${SUBDIR.}". This was \ - probably caused by using SUBDIR.$${MK_FOO} without including \ +.error ${.CURDIR}: Found variable 'SUBDIR.' with value "${SUBDIR.}". This was\ + probably caused by using SUBDIR.$${MK_FOO} without including\ or by using an invalid $${MK_FOO} option. .endif