From nobody Thu Apr 18 20:27:36 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VL8Th374Pz5HWmD; Thu, 18 Apr 2024 20:27:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VL8Th2FMYz4LvJ; Thu, 18 Apr 2024 20:27:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713472056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=twE6txNcm3pajodqnzin66K2Z1hDBHd7eLaeyNXHOhs=; b=n/JN+UJYfs0oyyGkqEKRyTfOPGwgOwccODciGBkOTovJpO8EB08CaJWWF3kB+Cu+S3hoHJ bEqA4ha3vM+nznyXeDOSnXNsqlqPtcJ+QiWx43K6oMMHKl5nNOuAo5Fc6A6IccI5ZQ6Jl3 dKDumPukXaVfRiHndL08qjLf/ZqxYJAz6grv5kmdsw3l+XAAtdV9XJUG/nzanZfH3FJyKw +vwYyb54m/4/CGMqZXFxfldpZNU3K4ZvWXBTINH45KyqIuoX6UAE+4lCVekoKeVO0ufg1N RIiAh2hBvxGIXHOWbvY/P0gS48httRJiMcldAkYFXyg8Dzg0GF4OjCrxCeV+cg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713472056; a=rsa-sha256; cv=none; b=AWoEcb2JUZFx3ub8bDvh8Mc8JMuGRRqF1yB9OdVczHB55AV1r1+V+GwmDQUBw4VgOeaKeR IHnkkIqsddc9lXWtTZmRqUSh3wW4a9KntTAFPv8r5hXSkYUtHeH81taInhW+DNzpYG0ttU zv6CSlsLmkJfv9PzJxADI5uSyxiw0PN8tlevaqT+4de3mSww0VkkmUGQsmr6eWP9edIrLk q/h2/+QLemwnpxovKT3eVpJVdyVa++RC3OEe6TKnsPqlW8J/ySBoHQsC9qHGRJ+sXT7A4z Fz+1uq5KIocV6e402B6wJzfsZakAoP49/LjUnexf7DU0ruNQxYdyEasZflQKpA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713472056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=twE6txNcm3pajodqnzin66K2Z1hDBHd7eLaeyNXHOhs=; b=KntInN4OEjCfDaOkaq1GXPj1R8Tsha0P7EE0vYnulsDLUByFwYUWaJl7jkbSHuqTH2xFh3 Q9byKpmCrvbDmAxEmFgJNWNo2vQucMeXv4twQEXwlCpB000ymO54zBmlI0tvDRQ5X88k+A qVhNEWV2zOtm0rGAOxQ1Gb3OFvIiaM64Rhm9K3kjzyWvHzNoxkpgUyQY/fv8paOwaxwGBB d8oRIIWb4ZIa3GrjmsdvILxN745dqlBpC/DfCbZ1k1twnntsy0le2Woxra7wlx+8MYieUo VKD1NWGEMmW79acusBFpKhY+1J26LfQdo8gsNCLwnET9MvO4LfXNfndC/PzVaA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VL8Th1rtczP5G; Thu, 18 Apr 2024 20:27:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43IKRaPq039875; Thu, 18 Apr 2024 20:27:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43IKRaNH039872; Thu, 18 Apr 2024 20:27:36 GMT (envelope-from git) Date: Thu, 18 Apr 2024 20:27:36 GMT Message-Id: <202404182027.43IKRaNH039872@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 1941914d3bb4 - main - tcp rack: improve BBR_LOG_CWND event List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1941914d3bb41b9e29a250d876ed8814b7b91f96 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=1941914d3bb41b9e29a250d876ed8814b7b91f96 commit 1941914d3bb41b9e29a250d876ed8814b7b91f96 Author: Michael Tuexen AuthorDate: 2024-04-18 19:57:44 +0000 Commit: Michael Tuexen CommitDate: 2024-04-18 19:57:44 +0000 tcp rack: improve BBR_LOG_CWND event Fix a typo, which resulted in missing r_ctl.gate_to_fs in the BBLog event. Reported by: Coverity Scan CID: 1540024 Reviewed by: rrs, rscheff Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44648 --- sys/netinet/tcp_stacks/rack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 409402adb907..669d213e58fb 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -17026,7 +17026,7 @@ rack_new_round_setup(struct tcpcb *tp, struct tcp_rack *rack, uint32_t high_seq) log.u_bbr.flex1 = rack->r_ctl.current_round; log.u_bbr.flex2 = rack->r_ctl.last_rnd_of_gp_rise; log.u_bbr.flex3 = rack->r_ctl.gp_rnd_thresh; - log.u_bbr.flex5 = rack->r_ctl.gate_to_fs; + log.u_bbr.flex4 = rack->r_ctl.gate_to_fs; log.u_bbr.flex5 = rack->r_ctl.ss_hi_fs; log.u_bbr.flex8 = 40; (void)tcp_log_event(tp, NULL, NULL, NULL, BBR_LOG_CWND, 0,