From nobody Wed Apr 17 03:33:53 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VK62T6KwWz5HjYQ; Wed, 17 Apr 2024 03:33:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VK62T39ksz4Qr4; Wed, 17 Apr 2024 03:33:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713324833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k9/XOuuJ6oi3utSNxGYE2fZE1bcLJjEV6gw6HqvTc/A=; b=GzH/JTA7mUFJFV5faOYHkfYp16fRMR+5T0thaT7mLyMMBpevJC6ElOqUiJyQZ5+Lv0jtXp q7pQIARWdD+CW6ZdwGipSnrl3BbfTZTVrGNzyToxab+IgBj11IuCIcKXXwRowUjpsIl4y8 eDCvVVo+5/R0XlIXzi7V2+Dn8swLkZ4XuQLEzk6qlWkQuWeqoe3X1T3MKQZt3wLjx2nkx2 0tD5P23tJO1fwfDiBJcV0950XXO8W1+U5FSZtX0vaVWKNY4Q//I5abrYJ2qQJGqwpwuNrY WhpyWJuR8n3iSp0d5y+sEjGuppE4ueUOvNUV3A+kFljfK6xVduyX7wW7jAvBiQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713324833; a=rsa-sha256; cv=none; b=Z1jHADNhpQdtzDfpnX6X5D/njZhqxgEjVsiAW9VaCazlTV5dkmUjFMPh7FaeO/95IoOfnZ Q3KqyrbBXnHIj8wSXOwjYIynBqy6d86kN5HVuwKq2jrcQLkkOk3zZ5G5xpfqvzPAhWJpl/ fmMkadRptSClGOZUEJ3HfkpaeaHiE7OIFK5A3PKFqnLjU9hrFLvmrW4wgz/j0q5GmC91gE cuTnM/c8gV3jo8Om45DhO/+VVlosjtq4ONLtCJHwqPV4ZgDexuUbadANsSwU0aLk2/y92+ hFiOZG2YVcMAGqTcZV4rTdMkoK9JDw+DEP+yL8tQa0AY41Pnz4T187mOBow6sQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713324833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k9/XOuuJ6oi3utSNxGYE2fZE1bcLJjEV6gw6HqvTc/A=; b=oawuYeVzPh9SUpc3c+tlBmh8S7qSq41N5Mpg8412YjM6xkUk9Ga/3eqNa2zSQJ6+r/anjw HA3oEC/vk/u22CmUyIANmGb6FPnwZvfVDBJ6iZH25z4C8JM5Yr7Og0MCvT8TQ6Fpn9rwJY QfTMZ3uHwARGvDzPdkYYFCkMNyIDtC9wJ0Sg9GMBxsA07O9lvE9i5UaqDv/Z7dF3QjJ/XD CDokN0Yqsnqam01P8uDT61DYjZtV7ZtVuy7nKPcbw/WgkT/0rSXDDWl1b6VR4l8W91AX+N nZGKhMCQ4aQVwwGGIHJid+MbeBUV/xXZ5Xl9GRIKxJab5vDZGQuBDUetZT8ZQQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VK62T2nMMz19FH; Wed, 17 Apr 2024 03:33:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43H3XrpA087209; Wed, 17 Apr 2024 03:33:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43H3Xrti087206; Wed, 17 Apr 2024 03:33:53 GMT (envelope-from git) Date: Wed, 17 Apr 2024 03:33:53 GMT Message-Id: <202404170333.43H3Xrti087206@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 97b77de2d951 - main - nvme: Eliminate intel_log_temp_stats_swapbytes List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 97b77de2d951b4946fb3219a99c98f2dd4c0120f Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=97b77de2d951b4946fb3219a99c98f2dd4c0120f commit 97b77de2d951b4946fb3219a99c98f2dd4c0120f Author: Warner Losh AuthorDate: 2024-04-16 22:36:47 +0000 Commit: Warner Losh CommitDate: 2024-04-17 03:30:19 +0000 nvme: Eliminate intel_log_temp_stats_swapbytes We can't post a AER for this page, so there's no need to be able to swap it to host byte order. It's not one of the standard defined pages that can post via AER, and the vendor's public docs for this temperature page don't suggest it's possible to get over or under event changes. Since nvmecontrol no longer needsd the swap routine, remove it since it's now unused. Sponsored by: Netflix Reviewed by: chuck Differential Revision: https://reviews.freebsd.org/D44659 --- sys/dev/nvme/nvme.h | 17 ----------------- sys/dev/nvme/nvme_ctrlr.c | 4 ---- 2 files changed, 21 deletions(-) diff --git a/sys/dev/nvme/nvme.h b/sys/dev/nvme/nvme.h index 706b77507b61..409d1f006cad 100644 --- a/sys/dev/nvme/nvme.h +++ b/sys/dev/nvme/nvme.h @@ -2241,23 +2241,6 @@ void nvme_sanitize_status_page_swapbytes( #endif } -static inline -void intel_log_temp_stats_swapbytes(struct intel_log_temp_stats *s __unused) -{ -#if _BYTE_ORDER != _LITTLE_ENDIAN - - s->current = le64toh(s->current); - s->overtemp_flag_last = le64toh(s->overtemp_flag_last); - s->overtemp_flag_life = le64toh(s->overtemp_flag_life); - s->max_temp = le64toh(s->max_temp); - s->min_temp = le64toh(s->min_temp); - /* omit _rsvd[] */ - s->max_oper_temp = le64toh(s->max_oper_temp); - s->min_oper_temp = le64toh(s->min_oper_temp); - s->est_offset = le64toh(s->est_offset); -#endif -} - static inline void nvme_resv_status_swapbytes(struct nvme_resv_status *s __unused, size_t size __unused) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index e41f32635346..b7b03082c54e 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -718,10 +718,6 @@ nvme_ctrlr_async_event_log_page_cb(void *arg, const struct nvme_completion *cpl) nvme_sanitize_status_page_swapbytes( (struct nvme_sanitize_status_page *)aer->log_page_buffer); break; - case INTEL_LOG_TEMP_STATS: - intel_log_temp_stats_swapbytes( - (struct intel_log_temp_stats *)aer->log_page_buffer); - break; default: break; }