From nobody Wed Apr 17 03:33:48 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VK62P2KzZz5HjNk; Wed, 17 Apr 2024 03:33:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VK62N6mrmz4QvQ; Wed, 17 Apr 2024 03:33:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713324829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=G5egkH9APeJS1NPVpe/7d0y6ixqxCbxse+5eoZcnxyk=; b=ANJwhnR2YmEuWOuph2LO6pD4mL8rNqa5YHTZe5dMOv7lef2zV2LSdKS6vYbHqJa/ZIZO+N nqM8hnPOwvzc1Uv1Dz19pnxJulbkInugBOjohTAmBVq9PhhfoEd3YaqDUqy5iiIxrvkFEa TdpQe1wp8c4hxH2SCJ9IYiwRBZsC2bWr6BSR/o7TJFP3Xxo2nVe70KNt8SJjPUZ/JFcfgr OCXXiNqI4Of/ls5wSIuPtUtDr25M1vRTaEc1ToJyJlIiYQXrTH1b/dFq//rsE7099OmED2 0KP9wvtRFLucDGYMm0QzLWLqD/2fJB6U0oad40rvWez9orRwCkv0tKyYS/CvBA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713324829; a=rsa-sha256; cv=none; b=bQTWg/syREXE0CVFNwk3YOquL5V6oMgg/Cwc2k+ODq5WsjUVFj3eli7QEJ/6A6JEj1EmtY GGhIVJiDe3jhwr+89/yTrcmKFOBk/HYfFSrQBD+je2ycdowrc8p3b9u2Ff/GF6JdC/igCv 5QcASDf1Xrl2XaniJHH4IcKl45tYET41KaXEuINUnQ6ZgP6eBLap01MKfzQLDwa9VJzHq8 4fAZmyWHlVhT7phhojuTKanmgn8WR80SQXgINuZ2KeABqjDNcn/U68uPo9rP2/pEK1+Qrr QmX9ZHT81f6pVnquYZPdn7vBMcHHTwcCBSbchqERsH31BMepI/3Ax9AGPP5D9g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713324829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=G5egkH9APeJS1NPVpe/7d0y6ixqxCbxse+5eoZcnxyk=; b=A+uwAmlj6IvMrtA8h1duIM3Y+yALZwCK/7BcaARo+BD7vvy9cTIbP6zglHjzuPYQBHajUp 4YAGzL4+Jnf4Pi7ChCWxmNhP31XFs7xfSu3HIK4klDYEx52XlAby5eJC6hQFhv5f7m57ET 3HSxlmMsw0O72SAjAN4jn/JBxcrDv6airVDgDGSToT9hkT+joCvcBiGNI7n37ROS2RnV8D LSgTRmBIfalki/SNmJEqs74eTdEmbH4Mx8qtgqFmzHo2qe0JbFOlHZnOGvOrRMxhnTK/V7 HH8qmjokcWLnY1ravf2OhnI15YAWgZFSfFWwnM6CEG1/upOnyTnZSOx5XFhx7Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VK62N6Krvz19WS; Wed, 17 Apr 2024 03:33:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43H3XmGq086997; Wed, 17 Apr 2024 03:33:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43H3XmKt086994; Wed, 17 Apr 2024 03:33:48 GMT (envelope-from git) Date: Wed, 17 Apr 2024 03:33:48 GMT Message-Id: <202404170333.43H3XmKt086994@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: b850caf7b709 - main - nvmecontrol: Move command effeccts page printing to little endian orderinng List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b850caf7b7099636fd4323cb47a82f5201309fed Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=b850caf7b7099636fd4323cb47a82f5201309fed commit b850caf7b7099636fd4323cb47a82f5201309fed Author: Warner Losh AuthorDate: 2024-04-16 22:36:25 +0000 Commit: Warner Losh CommitDate: 2024-04-17 03:30:18 +0000 nvmecontrol: Move command effeccts page printing to little endian orderinng Sponsored by: Netflix Reviewed by: chuck Differential Revision: https://reviews.freebsd.org/D44655 --- sbin/nvmecontrol/logpage.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sbin/nvmecontrol/logpage.c b/sbin/nvmecontrol/logpage.c index 9a8aa691d5db..bdabc1078166 100644 --- a/sbin/nvmecontrol/logpage.c +++ b/sbin/nvmecontrol/logpage.c @@ -219,10 +219,6 @@ read_logpage(int fd, uint8_t log_page, uint32_t nsid, uint8_t lsp, /* Convert data to host endian */ switch (log_page) { - case NVME_LOG_COMMAND_EFFECT: - nvme_command_effects_page_swapbytes( - (struct nvme_command_effects_page *)payload); - break; case NVME_LOG_RES_NOTIFICATION: nvme_res_notification_page_swapbytes( (struct nvme_res_notification_page *)payload); @@ -441,7 +437,7 @@ print_log_command_effects(const struct nvme_controller_data *cdata __unused, printf(" Command\tLBCC\tNCC\tNIC\tCCC\tCSE\tUUID\n"); for (i = 0; i < 255; i++) { - s = ce->acs[i]; + s = letoh(ce->acs[i]); if (NVMEV(NVME_CE_PAGE_CSUP, s) == 0) continue; printf("Admin\t%02x\t%s\t%s\t%s\t%s\t%u\t%s\n", i, @@ -453,7 +449,7 @@ print_log_command_effects(const struct nvme_controller_data *cdata __unused, NVMEV(NVME_CE_PAGE_UUID, s) != 0 ? "Yes" : "No"); } for (i = 0; i < 255; i++) { - s = ce->iocs[i]; + s = letoh(ce->iocs[i]); if (NVMEV(NVME_CE_PAGE_CSUP, s) == 0) continue; printf("I/O\t%02x\t%s\t%s\t%s\t%s\t%u\t%s\n", i,