From nobody Thu Apr 11 22:53:27 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VFw3W0D21z5GJDp for ; Thu, 11 Apr 2024 22:53:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VFw3V4dbjz4647 for ; Thu, 11 Apr 2024 22:53:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a52223e004dso28639666b.2 for ; Thu, 11 Apr 2024 15:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1712876020; x=1713480820; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=R7ZLQYAnpLs6Yfg+fWq1HmGh8SOvDLqaL38f2WzwHNk=; b=EkxMhAtB6qsHQo0LIGUBoY+7ehnRFNZUrZcvM7z85oE+AILfpLFvMDCxUOqogN0JXs oeBm+ebsBDwrRbFI+l+mN14+uu0OE1A6PHuhSoEb8adof+IdWnaSqVGEho7lInW+v8jb CfbtB/IW191ESdKMdHnrmPXpgM3AtuPZxCZbMp6Ct/r4lcdJd2aVB6YfAuI0lWowAPeQ Q4ILJEdPuBE3aPXm+yxMMIQ5PkPze5Pu2lBQvDEGvnHUF/y5Sg6A4mbgWKOaWj+kT0EN Vbwx3jQzq1oBIzY8uRq61mu7KNpUqwyrmv13sTTx0M0GLNkOZov/JpSVZLXuehgFcrVx IEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712876020; x=1713480820; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R7ZLQYAnpLs6Yfg+fWq1HmGh8SOvDLqaL38f2WzwHNk=; b=GKT431UNt9Ocy3VBkgeJjocnsg0YIMK1sJNMYudHtVlQ4FsWO30hbPZNn/yLs5BPJK hue5JC7WiXzTnsgyCLljsA+DZDuW56btPWRmU6V1qzmMj1zbGyVYucYlDuvOQpl529UF hAylb4shU5mvZco0+VKsxxKhbxAZp8wCAYarCMTW5sk5Fa/PgJBxEbKkMZPBV+JNtxqC FAO1LjLfafX+oSm2QCN8HyAa9PAau3wiCdkAkLBN/punrSqYggdVyGuq+J2zSKdOOgsq KnaaKHcc5tuLBYGvf4578jg299DWYd/WsXIXFtKA4TmWofSKbEnRGY1F4kaZgy1vUpi7 7zPQ== X-Forwarded-Encrypted: i=1; AJvYcCW3AuFQ+jEEU6vOfoyFjsIwC1dUu9XQSRabU/QvcKBImqAfiJREC21OlBSPrIVqQDuePAXFC9qYBjHi9aZ7h3XAPfJTEtIl0eTjBPbCFdoptA== X-Gm-Message-State: AOJu0Yyq2TetdMTiuhnJothhclS14qwF36SlcLYXo0Tso0qyuZR8ssla u2MAEkM2jo+gw1d2PJhJQVGaIZ3fhBOwv8oxbJCjbBB3B7MeJ7Y8EFiqkzDEzJ4a6dE34mVlVXd 7QlaxvnfVCvPY27eVzL9Nhps46dlsSL65SvdjuQ7rx5ZowYuUv4c= X-Google-Smtp-Source: AGHT+IF4prt71erzlQ9/lDMVnErV5YMS7GXcEBk+arC5+iSfptVJptv/GH3xeaTRFpEq4ADlC4kgcY6f7/yn6fYSLyk= X-Received: by 2002:a17:907:1747:b0:a4e:65e5:9ffc with SMTP id lf7-20020a170907174700b00a4e65e59ffcmr696688ejc.75.1712876019688; Thu, 11 Apr 2024 15:53:39 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: dev-commits-src-main+owner@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202404100322.43A3MTXZ087267@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 11 Apr 2024 16:53:27 -0600 Message-ID: Subject: Re: git: ac83063d37e5 - main - bcm2838_xhci: add module To: Andrew Turner Cc: Warner Losh , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000b2c55c0615da064f" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4VFw3V4dbjz4647 --000000000000b2c55c0615da064f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 11, 2024 at 4:10=E2=80=AFAM Andrew Turner wrote: > > > On 10 Apr 2024, at 04:22, Warner Losh wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Dac83063d37e5e92ad048cc4ed958654= c02103f74 > > > > commit ac83063d37e5e92ad048cc4ed958654c02103f74 > > Author: Lexi Winter > > AuthorDate: 2024-04-10 03:11:36 +0000 > > Commit: Warner Losh > > CommitDate: 2024-04-10 03:11:39 +0000 > > > > bcm2838_xhci: add module > > > > bcm2838_xhci(4) is a shim for the XHCI controller on the Raspberry P= i > 4B > > SoC. It loads the controller's firmware before passing control to t= he > > normal xhci(4) driver. > > > > When xhci(4) is built as a module (and not in the kernel), > bcm2838_xhci > > is not built at all and the RPi4's XHCI controller won't attach due = to > > missing firmware. > > > > To fix this, build a new module, bcm2838_xhci.ko, which depends on > > xhci.ko. For the dependency to work correctly, also modify xhci to > > provide the 'xhci' module in addition to the 'xhci_pci' module it > > already provided. > > > > Since bcm2838_xhci is specific to a quirk of the RPi4 SoC, only buil= d > > the module for AArch64. > > I think this broke GENERIC-ACPI kernel. The bcm2838_xhci driver is FDT > only. > You may be right... But I don't see GENERIC-ACPI committed to the tree. Maybe you could share it with me so I can fix this? Warner --000000000000b2c55c0615da064f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Apr 11, 2024 at 4:10=E2=80=AF= AM Andrew Turner <andrew@fubar.g= eek.nz> wrote:

> On 10 Apr 2024, at 04:22, Warner Losh <imp@FreeBSD.org> wrote: >
> The branch main has been updated by imp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3Dac83063d37e5e92ad048cc4ed958654c02103f74<= /a>
>
> commit ac83063d37e5e92ad048cc4ed958654c02103f74
> Author:=C2=A0 =C2=A0 =C2=A0Lexi Winter <lexi@le-Fay.ORG>
> AuthorDate: 2024-04-10 03:11:36 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-04-10 03:11:39 +0000
>
>=C2=A0 =C2=A0 bcm2838_xhci: add module
>
>=C2=A0 =C2=A0 bcm2838_xhci(4) is a shim for the XHCI controller on the = Raspberry Pi 4B
>=C2=A0 =C2=A0 SoC.=C2=A0 It loads the controller's firmware before = passing control to the
>=C2=A0 =C2=A0 normal xhci(4) driver.
>
>=C2=A0 =C2=A0 When xhci(4) is built as a module (and not in the kernel)= , bcm2838_xhci
>=C2=A0 =C2=A0 is not built at all and the RPi4's XHCI controller wo= n't attach due to
>=C2=A0 =C2=A0 missing firmware.
>
>=C2=A0 =C2=A0 To fix this, build a new module, bcm2838_xhci.ko, which d= epends on
>=C2=A0 =C2=A0 xhci.ko.=C2=A0 For the dependency to work correctly, also= modify xhci to
>=C2=A0 =C2=A0 provide the 'xhci' module in addition to the '= ;xhci_pci' module it
>=C2=A0 =C2=A0 already provided.
>
>=C2=A0 =C2=A0 Since bcm2838_xhci is specific to a quirk of the RPi4 SoC= , only build
>=C2=A0 =C2=A0 the module for AArch64.

I think this broke GENERIC-ACPI kernel. The bcm2838_xhci driver is FDT only= .


--000000000000b2c55c0615da064f--