From nobody Sat Apr 06 20:19:19 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VBmsh245Lz5HGlS; Sat, 6 Apr 2024 20:19:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VBmsh0njhz4MlP; Sat, 6 Apr 2024 20:19:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712434760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xe21eNBi01FK1559kapjD9RIIsjTHDh3Ck8U1UvKUGI=; b=EgU8XM81oBTmFqvMZ23VpsXnomAOCH6vt4TrT6rDztjzykv1s5EbOqXQCE3e25UCnEF8C4 9C3NOYVYZAmy3RpPunNwvyfu0767EytIEJ1mNtWNcYHFV3huYGxS/iqK2xBAn3DT8wnfmE vTuKpRXKzmLWib6XHrHKgLKxfrER0xtemm8o8tCbn+lfZGPDtVkGcD71sLsuxyEc4jYbl8 PjOeE/Nw1qPvjEQtTNURX81TvMn2ZCoBycnZ32GzS92BFpkeEgR3/p/dSDGxNTKXcDvgB5 G1Sgk0RFoCqIk1bbHlz0QrD4/maQtiwcf4fYKpawhbtiU/SQuWoZJsEDQIisKA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712434760; a=rsa-sha256; cv=none; b=i8I1Fq00XjIwuMUdH5dpWdF8Grijvq/NQp7K4OkURqlflvM5gLAKHiv7ywNQ+Qn0NPdE0s src2u6N/i/7SzWkJ3M6SvBWixrey5FPSB5nSq184hTVXwxB9F8i4zDpvydVF4YnbdAMm0K yqOX/XMTTxuiUhlDaQlBgUqpV7ylZ1/RvfFi1t+owKqXKJfSJyTz0rBHlvL6Wegqhlcm+Q OpK5mfOQMnlZ5pAzQQjMKet0D54fgYn0gB41wK0AoWD+43dwMxiFaTTgKkyl0h/LwWzJVQ Fx0+Q0nk8EBR4CDSbaiapzD74l+CW/pgF3JD4ifj+j/9niAM8LCLpER1zvxr7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712434760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xe21eNBi01FK1559kapjD9RIIsjTHDh3Ck8U1UvKUGI=; b=MIT16E2hE3Q6YZ5wwostSeBLWJJUkwwW4Ifh+cOc826iaSFZ3O9kOybNQTUuO0mgLmpKks wYgdGQ3F7mtTEkWzWeeJ+67nVcI055AtzQIF/Zytw0HVegSXRoeqmHg4usKpNubkVpe6jW 8qmu12cNiAjSk2fPWTLScyX5FMesjGfzkccs0Z0mRH4Cw0EATxiW215SW2i6xvDIJzuqaU qG4DRICw1qbzHB+0M48J4Ms+xf9hXqq49jMfw8qaJWVezl2vkYaMS05XTqinqstW8pkoVj ODSrt9L+rnefXt6trMzU6QUI5kw2XjEWcbU+Jh6KY1+Ly6Uis3WhMwlPufUJaw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VBmsh0PsQzxgG; Sat, 6 Apr 2024 20:19:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 436KJJE6030354; Sat, 6 Apr 2024 20:19:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 436KJJ2g030351; Sat, 6 Apr 2024 20:19:19 GMT (envelope-from git) Date: Sat, 6 Apr 2024 20:19:19 GMT Message-Id: <202404062019.436KJJ2g030351@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: ce4f1f49e036 - main - Revert commit 6255157d24e2 from llvm-project (by Dimitry Andric): List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ce4f1f49e036fd806b534decfe38020dae32a384 Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=ce4f1f49e036fd806b534decfe38020dae32a384 commit ce4f1f49e036fd806b534decfe38020dae32a384 Author: Dimitry Andric AuthorDate: 2024-03-19 13:07:27 +0000 Commit: Dimitry Andric CommitDate: 2024-04-06 20:14:31 +0000 Revert commit 6255157d24e2 from llvm-project (by Dimitry Andric): [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14 After many years of using the really old std::pair ABI which did not yet have a trivial copy constructor, FreeBSD 14 and later will finally get rid of it. Only use the old ABI for FreeBSD 13 and earlier. Note: on the FreeBSD side, we will bump our libc++.so version for this, and keep an old compatibility library in a separate package. Differential Revision: https://reviews.llvm.org/D126462 This ABI change can cause crashes when binaries compiled against older libc++ versions are run against binaries compiled against this libc++ version. For example, lang/ldc uses a precompiled bootstrap ldc2 binary that was compiled against the old libc++, but also links against libLLVM-15.so. If libLLVM-15.so is compiled against the new libc++ version, the ABI mismatch results in segfaults or even stack overflows. Note: we can only re-enable the std::pair trivial copy constructors again when the official libc++ ABI version is bumped to 2. PR: 276104 MFC after: 1 month --- contrib/llvm-project/libcxx/include/__config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/llvm-project/libcxx/include/__config b/contrib/llvm-project/libcxx/include/__config index fa5535facb14..a5981984d37e 100644 --- a/contrib/llvm-project/libcxx/include/__config +++ b/contrib/llvm-project/libcxx/include/__config @@ -190,7 +190,7 @@ # endif // Feature macros for disabling pre ABI v1 features. All of these options // are deprecated. -# if defined(__FreeBSD__) && __FreeBSD__ < 14 +# if defined(__FreeBSD__) # define _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR # endif // For XCOFF linkers, we have problems if we see a weak hidden version of a symbol