From nobody Sat Apr 06 08:05:40 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VBSb82xF1z5G5hN; Sat, 6 Apr 2024 08:05:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VBSb826gmz4713; Sat, 6 Apr 2024 08:05:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712390740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K8ykdTyDH1WTNRu5NHKFKFMGdz+ocNwy9McfoDUviz0=; b=nl2BxFB0gXK2fE1LK0LwrJ8b32FxfeiMzfRpVBWIy2lIMCZIxjVtIfUpk32u0pBzjmMJrU Ye67AkbryFUGfgJ8Hl9C6/doiZtXd7oBchuyEQe9B91PAo5QfQ5T3JB8obokcxaJbnzEZJ /3PJ743WIHdA7javZs+jUiS2DQSxar88t3F4pnuLCWFeVjWuOwxOTcrqypyS3UgkdTD9ZZ qM7AWtNUVUtoe85lxZAKiX2FpA4gLpoROwS4PiV43dfqWxjlDB5IrSg/AB3zSyQy8r0sI3 H2iNJ2DLZNepSCBGETCXZta1HLu5H0u7Lx5LQDU1nYh6TydumkMf3Z9moWwIDg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712390740; a=rsa-sha256; cv=none; b=yz1rHXp2VLIlegtJSQ7g9MId6i6mO/MoDv4Lls2M+saRnWB2TlenNhGu3ZBd2ZYfmANUdv SlbglwIyjXNUKe8ZDvvapwAdRqzVwBakbp0o8PA1LIT3zzRpZyxjmpBF2cwUhXSGSRaQHG ml7yA429Lna8TIm7oibBOUNSHIJjpPU5DzwdjUWA7PXkaEoms7iSLWW27HGzCIVViEi7Df O/hZ8/9AcemScIJDqpa2FWI/7+M9sZWko/OtU2+1HaN+hIOYCKuZPiul7qPbsxqSaaFU3E 4JFf6Jr5vW/2rsXJZINYarPZyUdolqeLJNZcKDnqqK+Sjc00K1H6k6a/oAoSdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712390740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K8ykdTyDH1WTNRu5NHKFKFMGdz+ocNwy9McfoDUviz0=; b=yL+xOsLpXLVAh0VUc1WK0j0lqi6CxxK34rAWODlBykD9vaA6Sw+k0h4bF67/zjVnF6Y7ML 7kIVC1sEtaRCJfX6tjmnpPsfuCdYbMHLOqyrVkpLI9hcMKT3tdOvw/GYlJri5xjvbSSG34 rXe/Zl8CXw2rk2LyklvhEVfTPcvPPV2uqaVZa3CJCBGvZ5eEbE5EZsdYxxs6+cmqkxDR37 o1oArWkIFL2jSo25ihlOFrjNZagy9p78c10Ru5WcsNY8CVeNWKgFkvlnQU4gtDLViepa1s xmXprXairRZMY2esjrB2Gpqy6iaiddkL2FKoRQZHJ9Afk7KwcvsQWQkt5cO5eQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VBSb81bznzc9Q; Sat, 6 Apr 2024 08:05:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43685eCV094891; Sat, 6 Apr 2024 08:05:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43685e0u094888; Sat, 6 Apr 2024 08:05:40 GMT (envelope-from git) Date: Sat, 6 Apr 2024 08:05:40 GMT Message-Id: <202404060805.43685e0u094888@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 3e1c8a35f741 - main - tcp: improve consistency List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3e1c8a35f741a5d114d0ba670b15191355711fe9 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=3e1c8a35f741a5d114d0ba670b15191355711fe9 commit 3e1c8a35f741a5d114d0ba670b15191355711fe9 Author: Michael Tuexen AuthorDate: 2024-04-06 08:02:06 +0000 Commit: Michael Tuexen CommitDate: 2024-04-06 08:02:06 +0000 tcp: improve consistency No functional change intended. Reported by: Coverity Scan CID: 1523781 Reviewed by: rscheff MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44645 --- sys/netinet/tcp_input.c | 2 +- sys/netinet/tcp_timewait.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index 8410cb490915..d27a79d1c3b1 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -1955,7 +1955,7 @@ tcp_do_segment(struct tcpcb *tp, struct mbuf *m, struct tcphdr *th, tp->t_flags |= TF_DELACK; } else { tp->t_flags |= TF_ACKNOW; - tcp_output(tp); + (void) tcp_output(tp); } goto check_delack; } diff --git a/sys/netinet/tcp_timewait.c b/sys/netinet/tcp_timewait.c index 266556274e18..8d77db275310 100644 --- a/sys/netinet/tcp_timewait.c +++ b/sys/netinet/tcp_timewait.c @@ -123,7 +123,7 @@ tcp_twstart(struct tcpcb *tp) soisdisconnected(inp->inp_socket); if (tp->t_flags & TF_ACKNOW) - tcp_output(tp); + (void) tcp_output(tp); if (V_nolocaltimewait && ( #ifdef INET6