From nobody Wed Apr 03 22:18:39 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V8zfl5gZXz5G106; Wed, 3 Apr 2024 22:18:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V8zfl59n9z4ccX; Wed, 3 Apr 2024 22:18:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712182719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jZAQX96vFUZ6EVJY73K6DMfXQkrg3XdMyZxXX1zrqB8=; b=Yhf2zxAtqLlr7Wxr3G5JG7Q61aKF/PX0HYB36x3y3XbdrqZRGmnGXjucj7BBIZfC+BD5f5 Wr0HUQPQv0uwmrEpJTuMeac0jR3qopMh/S+4iTAhvjRL80i694A61a83QDh2UNyK5g5vxs gcWGJqkqflTqhUkSb607k7dWW02BcQiwmFaQff0TpBLHW/t+LsqHbdXgpFNwGOZmoYNQmp nqFeLalD+Ir4ialczQCpCIk1hm14o5DK6aE0JF2FgfIuj29Y9CnUbbwNeV7JlubqXEyen9 eFfNeo5G3/OaQMCbcGxYWtkpYiCa451HnsQbJ7aMYzSgtaB1Zg5YliTXKi2YCw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712182719; a=rsa-sha256; cv=none; b=O01zrNH9edUHtmhZoH/h780h5wBeSgh9LFUtBlN1YXqcAMBOxFpUkcClq6JQAGbbYUWjYK I0kPA+VXic0tpn6VKpCM69NRNAYzac0+f3clBr5nd10HnSV9UriQp72e4a1of14U76thKQ FD9NXX4Zd+/esiug/O+/D6PRtMEMPJnaZMB3wE05MA0Wr9p5WQbMNRqJfVPMONTgIclMOY dA2BcK8krp/st1FnZKIdD8gDRd6cEeDUaqwpacFLlmpiO2RSZJLpAHpZFp9xa2TTN94g+9 83KN1lMMGqJDXAEUyqyB9hpemSl8KOTmGcTwGHhTTO6kelYfUnFsC6JcSGhFzA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712182719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jZAQX96vFUZ6EVJY73K6DMfXQkrg3XdMyZxXX1zrqB8=; b=tYzQu+dzFTinnDCDNktYMsL+xCB1Wh+v7W2vk3Nh3pZ3YjUV3RbwoaZmx5k+f17YDbqK9V +5TfD51KxNWpTy1NG+sJASvWIkSuRjd0btglG9Zx3pZHDcaAkyFPzKucS3jO2RIvCVPoo6 32vfJSv9ZDQvWijkGmBEU8Rfcw6yeQ/UvBKK1+n9BNIYCAVe0SxQuuGOTf68VaUJEZoMHE cpeKYLvIJwHQ6If3E5AB5iOshYfhsn6H7nX1Fkcsw1k7nxgwcObGy/TNnZp7utVl/afbxx ZMIP6qVuZszCWVLBfrS8GDwAuVgZnhGvFOAR9bm9GuZk1YQz7luZENLF6NDZUg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4V8zfl4mqCzrGp; Wed, 3 Apr 2024 22:18:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 433MIdLU006476; Wed, 3 Apr 2024 22:18:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 433MIdPD006473; Wed, 3 Apr 2024 22:18:39 GMT (envelope-from git) Date: Wed, 3 Apr 2024 22:18:39 GMT Message-Id: <202404032218.433MIdPD006473@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 6b454da6bbaa - main - tcp: address a warning List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6b454da6bbaa3327cf9b7185d198c96ffc1b88f4 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=6b454da6bbaa3327cf9b7185d198c96ffc1b88f4 commit 6b454da6bbaa3327cf9b7185d198c96ffc1b88f4 Author: Michael Tuexen AuthorDate: 2024-04-03 22:14:59 +0000 Commit: Michael Tuexen CommitDate: 2024-04-03 22:14:59 +0000 tcp: address a warning t_state is an unsigned variable, so no need for testing that it is non-negative. Reported by: Coverity Scan CID: 1390885 Reviewed by: glebius MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44619 --- sys/netinet/tcp_subr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c index 860d65249148..312740ccf599 100644 --- a/sys/netinet/tcp_subr.c +++ b/sys/netinet/tcp_subr.c @@ -1086,7 +1086,7 @@ tcp_default_fb_init(struct tcpcb *tp, void **ptr) /* We don't use the pointer */ *ptr = NULL; - KASSERT(tp->t_state >= 0 && tp->t_state < TCPS_TIME_WAIT, + KASSERT(tp->t_state < TCPS_TIME_WAIT, ("%s: connection %p in unexpected state %d", __func__, tp, tp->t_state));