From nobody Wed Apr 03 17:53:17 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V8smp3FyDz5FW7j for ; Wed, 3 Apr 2024 17:53:30 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V8smp1NsBz45HP for ; Wed, 3 Apr 2024 17:53:30 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-416262d747dso774635e9.0 for ; Wed, 03 Apr 2024 10:53:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712166808; x=1712771608; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=82vW2Nv0K9oBl4CIzeODksQT3xkLutQmmNzOD3XALvc=; b=gkJyFAQdgO0FQPz8pou40UEuI4zNNJgtHvCcAPJvMjkGE+1Asuynj9AE0lJUaPJD4Y ZMpXtjP5W2romQ0wQ91JIUbuef3HFzk7OXT/QsZskfA6nXVNr1TWHNMWlsIP0VtWpVWs f0JAj86iHzUNrhMyFPxTi4p0RZnK3AkNcGBrFWRQ2Bmys5bJrF+95EpwrVGfuwj/wQ8q ZjUcPb/ifDBAxTG8wfYUio4gCyp+16JC5lbBk42STAu8d7tH8TZkV9jMVNYy21mmuCjw LcwMTeGy0P8O+Q9bdcMh5UJJAbVThIk/QfX+jiWfGiD8++OV9xgDLdv/v8hOOucHX+Kc KLXA== X-Forwarded-Encrypted: i=1; AJvYcCXYiQIiQuULaG5mnK1bpptlWfoSLffOdrlfO54Smo5jeFAItZr4nuW/jWN2VF+53duC/e4ag3l9mei2U32hz3/UKzYsuTrLnvW+kADTIaUdlg== X-Gm-Message-State: AOJu0YxQ2+hMTNGKbvK3bOrfWPP3RUnCeWQNEUJfWURT32lD80XLhpBH 2/tdf+VGYGaI9GXDpA4DIQ/I57vvIaYV5483jvSbZ+kmJC3gSfVXbai1AHrMoWw= X-Google-Smtp-Source: AGHT+IEczbWbjrJiAZGWqXJqoauSPrnPEa2lifIeSkFs2nQBA8+LkKwtvgk+HOWvM9tYLtzMwq4Wng== X-Received: by 2002:a7b:c303:0:b0:416:1e4d:497a with SMTP id k3-20020a7bc303000000b004161e4d497amr200553wmj.25.1712166808372; Wed, 03 Apr 2024 10:53:28 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id c9-20020a7bc2a9000000b0041552dbc539sm17486000wmk.11.2024.04.03.10.53.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2024 10:53:27 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: git: 872c4402af13 - main - ddb: Don't throw away qualifier when pretty-printing unnamed pointers From: Jessica Clarke In-Reply-To: <202404031618.433GIQUx096602@gitrepo.freebsd.org> Date: Wed, 3 Apr 2024 18:53:17 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <7D6B67DF-D648-49F2-A03B-D7F9A509CA79@freebsd.org> References: <202404031618.433GIQUx096602@gitrepo.freebsd.org> To: =?utf-8?Q?Bojan_Novkovi=C4=87?= X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4V8smp1NsBz45HP On 3 Apr 2024, at 17:18, Bojan Novkovi=C4=87 = wrote: >=20 > The branch main has been updated by bnovkov: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D872c4402af1325ed156d7f5ee2252dd3= 6b016b5c >=20 > commit 872c4402af1325ed156d7f5ee2252dd36b016b5c > Author: Bojan Novkovi=C4=87 > AuthorDate: 2024-04-03 15:55:13 +0000 > Commit: Bojan Novkovi=C4=87 > CommitDate: 2024-04-03 16:17:54 +0000 >=20 > ddb: Don't throw away qualifier when pretty-printing unnamed = pointers >=20 > Reported by: jrtc27 > Fixes: c21bc6f ("ddb: Add CTF-based pretty printing") > Approved by: markj (mentor) > --- > sys/ddb/db_pprint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sys/ddb/db_pprint.c b/sys/ddb/db_pprint.c > index b4116372cf65..8e6759a03220 100644 > --- a/sys/ddb/db_pprint.c > +++ b/sys/ddb/db_pprint.c > @@ -276,7 +276,7 @@ db_pprint_ptr(db_addr_t addr, struct ctf_type_v3 = *type, u_int depth) > if (name !=3D NULL) > db_printf("(%s%s *) 0x%lx", qual, name, (long)val); > else > - db_printf("0x%lx", (long)val); > + db_printf("(%s *) 0x%lx", qual, (long)val); At this point, why not just: db_printf("(%s%s *) 0x%lx", qual, name !=3D NULL ? name : "", = (long)val); Jess