Re: git: 1a18383a52bc - main - libcrypto: link engines and the legacy provider to libcrypto

From: Kristof Provost <kp_at_FreeBSD.org>
Date: Mon, 18 Sep 2023 00:01:51 UTC 
On 16 Sep 2023, at 16:55, Ed Maste wrote:
> The branch main has been updated by emaste:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=1a18383a52bc373e316d224cef1298debf6f7e25
>
> commit 1a18383a52bc373e316d224cef1298debf6f7e25
> Author:     Pierre Pronchery <pierre@freebsdfoundation.org>
> AuthorDate: 2023-09-15 15:14:16 +0000
> Commit:     Ed Maste <emaste@FreeBSD.org>
> CommitDate: 2023-09-16 15:55:12 +0000
>
>     libcrypto: link engines and the legacy provider to libcrypto
>
>     OpenSSL's legacy provider module and engines need to link to
>     libcrypto.so, as it provides some of the actual implementations of
>     legacy routines.
>
>     This is a little tricky due to build order issues.  Introduce a small
>     hack (LIBCRYPTO_WITHOUT_SUBDIRS) that builds libcrypto.so in its usual
>     early phase without any OpenSSL provider modules or engines.  This is
>     intended to restore the test suite; a future change should remove the
>     hack and replace it with a better approach.
>
>     PR:             254853, 273528
>     Discussed with: Folks at EuroBSDCon in Coimbra
>     Sponsored by:   The FreeBSD Foundation

MFC after: 3 days?

We’ll want this in 14.0.

Best regards,
Kristof