From nobody Mon Sep 11 18:51:59 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rkwn44JFjz4tMBC; Mon, 11 Sep 2023 18:52:08 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [195.93.173.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rkwn34Wg2z3TJB; Mon, 11 Sep 2023 18:52:07 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of dchagin@heemeyer.club has no SPF policy when checking 195.93.173.158) smtp.mailfrom=dchagin@heemeyer.club; dmarc=none Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.17.2/8.16.1) with ESMTP id 38BIpxFH002386; Mon, 11 Sep 2023 21:51:59 +0300 (MSK) (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.17.2/8.16.1/Submit) id 38BIpxEU002385; Mon, 11 Sep 2023 21:51:59 +0300 (MSK) (envelope-from dchagin) Date: Mon, 11 Sep 2023 21:51:59 +0300 From: Dmitry Chagin To: Mateusz Guzik Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a87c6962affc - main - ufs: restore name cache fast path lookup Message-ID: References: <202309092150.389LovR0091943@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202309092150.389LovR0091943@gitrepo.freebsd.org> X-Spamd-Bar: - X-Spamd-Result: default: False [-1.75 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.95)[-0.946]; FORGED_SENDER(0.30)[dchagin@freebsd.org,dchagin@heemeyer.club]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; ASN(0.00)[asn:61400, ipnet:195.93.173.0/24, country:RU]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; FREEFALL_USER(0.00)[dchagin]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[dchagin@freebsd.org,dchagin@heemeyer.club]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4Rkwn34Wg2z3TJB On Sat, Sep 09, 2023 at 09:50:57PM +0000, Mateusz Guzik wrote: > The branch main has been updated by mjg: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a87c6962affc2d1994d8f30806c934eb4cb7af22 > > commit a87c6962affc2d1994d8f30806c934eb4cb7af22 > Author: Mateusz Guzik > AuthorDate: 2023-09-09 21:48:57 +0000 > Commit: Mateusz Guzik > CommitDate: 2023-09-09 21:48:57 +0000 > > ufs: restore name cache fast path lookup > 10x, do you plan to merge this to the stable/14 releng/14.0? I just cherry-picked this to my stable/14 prod, so compile and runtime tested > Found by: dchagin > Fixes: f3c81b973897 ("ufs: add missing vop_fplookup ops") > --- > sys/ufs/ffs/ffs_vnops.c | 6 ++++-- > sys/ufs/ufs/ufs_vnops.c | 4 ++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/sys/ufs/ffs/ffs_vnops.c b/sys/ufs/ffs/ffs_vnops.c > index 0dd64f696e0c..2b11a15c46c9 100644 > --- a/sys/ufs/ffs/ffs_vnops.c > +++ b/sys/ufs/ffs/ffs_vnops.c > @@ -135,6 +135,8 @@ static vop_setextattr_t ffs_setextattr; > static vop_vptofh_t ffs_vptofh; > static vop_vput_pair_t ffs_vput_pair; > > +vop_fplookup_vexec_t ufs_fplookup_vexec; > + > /* Global vfs data structures for ufs. */ > struct vop_vector ffs_vnodeops1 = { > .vop_default = &ufs_vnodeops, > @@ -151,7 +153,7 @@ struct vop_vector ffs_vnodeops1 = { > .vop_write = ffs_write, > .vop_vptofh = ffs_vptofh, > .vop_vput_pair = ffs_vput_pair, > - .vop_fplookup_vexec = VOP_EAGAIN, > + .vop_fplookup_vexec = ufs_fplookup_vexec, > .vop_fplookup_symlink = VOP_EAGAIN, > }; > VFS_VOP_VECTOR_REGISTER(ffs_vnodeops1); > @@ -192,7 +194,7 @@ struct vop_vector ffs_vnodeops2 = { > .vop_setextattr = ffs_setextattr, > .vop_vptofh = ffs_vptofh, > .vop_vput_pair = ffs_vput_pair, > - .vop_fplookup_vexec = VOP_EAGAIN, > + .vop_fplookup_vexec = ufs_fplookup_vexec, > .vop_fplookup_symlink = VOP_EAGAIN, > }; > VFS_VOP_VECTOR_REGISTER(ffs_vnodeops2); > diff --git a/sys/ufs/ufs/ufs_vnops.c b/sys/ufs/ufs/ufs_vnops.c > index a7d5e8ba96fc..79cca75fc563 100644 > --- a/sys/ufs/ufs/ufs_vnops.c > +++ b/sys/ufs/ufs/ufs_vnops.c > @@ -101,7 +101,7 @@ VFS_SMR_DECLARE; > #include > > static vop_accessx_t ufs_accessx; > -static vop_fplookup_vexec_t ufs_fplookup_vexec; > +vop_fplookup_vexec_t ufs_fplookup_vexec; > static int ufs_chmod(struct vnode *, int, struct ucred *, struct thread *); > static int ufs_chown(struct vnode *, uid_t, gid_t, struct ucred *, > struct thread *); > @@ -475,7 +475,7 @@ ufs_accessx( > * VOP_FPLOOKUP_VEXEC routines are subject to special circumstances, see > * the comment above cache_fplookup for details. > */ > -static int > +int > ufs_fplookup_vexec( > struct vop_fplookup_vexec_args /* { > struct vnode *a_vp;