From nobody Thu Oct 26 18:52:06 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SGZfM1HSfz4y8yf; Thu, 26 Oct 2023 18:52:11 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SGZfL46KVz3Ktw; Thu, 26 Oct 2023 18:52:10 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b="nL8L/v7x"; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::430 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6b87c1edfd5so1204761b3a.1; Thu, 26 Oct 2023 11:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698346329; x=1698951129; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Ps5aWoumvsYkTdqurmF24S+usJFCMPG3sdr/qqhnMUk=; b=nL8L/v7x5LJ9GP4ClXXcDcsFl/jWO/qxsxGc0um3/CVh3n+EKmLiINo0v+h/h1l/Tr BU3qhProWP6U3h/tBxt2qOonZUGyWoMc+c/yhd8PF/pliVnbpmQxnBpe+jF5abJuiKvV e8BNWdpRRB7ZjmSNUS5Sun2k6tQhT3vJKvjhpgcVPzbzdYADJpQxv+KrF/U2n1aQyZZw rKjFBKM4IMf6PFsE1fRaisj492vaAZrRCFTVjmQfTmR/HHcJsUb72qO49y7x4w4ajocw wXwiJIafPHD9rIutFp9D1wHH3RsL5EQ18HkJCYNit+GjgvKKcxn7Xcf4gtbJZPfcsaG6 35Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698346329; x=1698951129; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ps5aWoumvsYkTdqurmF24S+usJFCMPG3sdr/qqhnMUk=; b=V/SeO03Kh08tnhZYlc47enkIsJWXcMpc94famQZr6O4X3jZqnIcsFzcM4/9cfUfNor x++waHzzte4LmetT0tpd/tifT7A1iuePM1FaE3nsKzyJXrdI2bnJKwOmVh6i3hJ7EJ4h pFrNRT5AwRu/W4ZJXqYB8VEgIFiXADWEf+vpIBMQaLdM9bnZxCyeS7j5ChdC9OuitG5Z RIfO/2mdB0RnhtmAPiCg2aTXqeSv1qhYqSlzfr8B1cwTSuyW+afuZCWATtLAzZYs5wFS gI39k11zGEwohRDz+NYMFtOANDolzGAwjUSiSKZUH9EaygdRxWta/7ytK5VI4oED9R1v ESfw== X-Gm-Message-State: AOJu0YyUBmmnucE/UKw2A0Rg0kfQz3V+zwz3o4r1ovrGXOJ6ocOXt4lL XVMbTstSyp8YlLeJ6VdkwjPnYiQx/H8AtA== X-Google-Smtp-Source: AGHT+IEegOpsWFEI28UKAeqi+NxjP+dPtoZghK0UyPpY/ZxdZBd1yuqgVBlZ/mHGWQ4M3QPIn0TtyQ== X-Received: by 2002:a05:6a00:2356:b0:6b1:bf32:4fb5 with SMTP id j22-20020a056a00235600b006b1bf324fb5mr391866pfj.28.1698346328537; Thu, 26 Oct 2023 11:52:08 -0700 (PDT) Received: from smtpclient.apple (c-73-35-248-51.hsd1.wa.comcast.net. [73.35.248.51]) by smtp.gmail.com with ESMTPSA id b4-20020aa79504000000b0068fe76cdc62sm5758009pfp.93.2023.10.26.11.52.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Oct 2023 11:52:07 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_A84BD7E4-2FC4-4DC4-AF9D-6549544C566F"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: git: 6120673f7566 - main - tests: fix ATF_TESTS_PYTEST no clean build From: Enji Cooper In-Reply-To: Date: Thu, 26 Oct 2023 11:52:06 -0700 Cc: Dimitry Andric , markj@freebsd.org, "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: <8962DE73-16C0-4DF0-87B9-53A5ECC3D158@gmail.com> References: <202310201747.39KHlUgB005433@gitrepo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spamd-Result: default: False [-5.55 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.95)[-0.953]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::430:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4SGZfL46KVz3Ktw X-Spamd-Bar: ----- --Apple-Mail=_A84BD7E4-2FC4-4DC4-AF9D-6549544C566F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 22, 2023, at 3:13 PM, Gleb Smirnoff = wrote: >=20 > On Sat, Oct 21, 2023 at 09:07:26PM +0200, Dimitry Andric wrote: > D> > commit 6120673f7566c35023921540d2d682572d1bf1ce > D> > Author: Gleb Smirnoff > D> > AuthorDate: 2023-10-20 17:47:08 +0000 > D> > Commit: Gleb Smirnoff > D> > CommitDate: 2023-10-20 17:47:08 +0000 > D> > > D> > tests: fix ATF_TESTS_PYTEST no clean build > D> > > D> > The hack with .xtmp file was effectively making the make to > D> > ignore changes to the sources, breaking NO_CLEAN builds. The > D> > hack can be actually omitted as setting SCRIPTSNAME_${_T} for > D> > every test is sufficient to prevent renaming by bsd.prog.mk. > D> > > D> > Reviewed by: melifaro > D> > Differential Revision: https://reviews.freebsd.org/D42283 > D> > D> This appears to break clean builds, in that it now deletes files > D> mentioned in ATF_TESTS_PYTEST in the _source_ directories, leaving = your > D> git checkout looking as follows: >=20 > Oh shit... Sorry. :( When I come up with a better change, who would > be a good reviewer for the change? Hi Gleb! If you include the tests group, we might be able to help (it=E2=80= =99s a bit larger than asomers@/jmmv@). jmmv@FreeBSD.org has been = inactive these days too =E2=80=94 it would probably be a good idea to = mark his account disabled (if possible). bdrewery@ might have been a = good resource as well. Cheers, -Enji PS I=E2=80=99m swamped with work/life stuff, but I try to give my input = if/when I can. --Apple-Mail=_A84BD7E4-2FC4-4DC4-AF9D-6549544C566F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEtvtxN6kOllEF3nmX5JFNMZeDGN4FAmU6tVYACgkQ5JFNMZeD GN7vYg/9Ha/8FGf0PpdQ8kPee2iSn/00L6D9cfs9nZT92JhqNl817+7KAVPhRXdG SdV7jatFIlFRzUMXHgdCi1A7j1desfdCthNmX9RM3rTZ16KfG+U9Mg7FrWvTIXFz pa3gunbUXJbF8y+ZfK73ziabqQqkMfyWB3UkdMaSgNcpjF9CKxLxsgZrpjiRJAf0 hEmPF0R+eFxRn+fewmYpG1Fz5b8lPAU6GgqofRVcZIMbwdM1U7GnEJsL2ekhSEI0 2b53Y4BUXrDkwHr5x2MrpQdlacQKQtE3klwxJkS42Fxbi82mOp3sujXfklQ3qtAh 69GV6ywH56wj49a6ezdnMFOxUdLzapdClFO/ye5e5fa6nlJDFWshAwT4U/V+RL7/ pNvzuAhdHZKTfLZg1SFhcszHXjUB6bJyd4CQtOQd+iygWhAXYMjuTsmulBtph5+g CNmJN7/L1OMzlmChkeQAqj5j+rBzAI6Al6Sh7tDL4p1rtKAxTmQNwUfFa7POl0KB NI3ecIBdCAwhvDu1iCZRr/hvsLynkXyEc2gmzx0E7K9pggXwi5hlRXa52W27TSl+ ovkt156xxJWygGIPX46Kgf1aD8OYWnz/ZKH2nD534OVVcNY6oIP5wqDWIRGNjetU 8DR9Jyzes33mkmA09VSsZUisi4hTBS9qNr3ENbsjAUYRr39uxUs= =FD7x -----END PGP SIGNATURE----- --Apple-Mail=_A84BD7E4-2FC4-4DC4-AF9D-6549544C566F--