From nobody Thu Oct 19 17:28:10 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SBF6n030qz4xgrr; Thu, 19 Oct 2023 17:28:17 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SBF6m6VfZz3PwT; Thu, 19 Oct 2023 17:28:16 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697736496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uThdu/WKdVZvlDZNe596rGZZm7DmSvHjz1U0Z5FcI1k=; b=IrudJ6YKPzMPgmVqBOdtos3FBUzL6Bghy90p5ZTTIRXKDrzVVo8ry0WfiQVWhJk7GsM/M2 gr68RsblJOAgRjoBZ6kO6L4BFF7NUb+0FYulFEyonoyET/HwWGi1EW08Byr2dcdRsjusXo slYocn6+I1+0jXLTPMt2802VfOhh2/Eb4cnQJXjYpDKUMvFN7URaQvQapl3eTml0tBF6QH voijjdc9VKA+ogZjweDX/zlTS+dr2Ov94hLxiKCT0HtrGBX5Ir/Ed/Q7oOhLPCyXZ6xOAd VUqzpxVinGqD8zpMLul6hGldnzJVjPDEUfn6BWf6G7K6jt/UheDEqMtzFWzFyg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697736496; a=rsa-sha256; cv=none; b=hqYo02dqoynwMsmFl7WuDvV9X9CV5Hvdsmu0yhSOTng4R72ZmyKJX8xoU53JW5kPhG1UmO xJtyVBT6ve1kFDkJ2Wj9XAEegUvH1au+2SymS6bWaUgjlB9zwiVG0su//PfJ2vwW4c8hKH Rmhui8kaD8Dfy+y2IAQxEOedPp1MhIUE+YFCAI6o8hvuE8Yw+Zs0CCpA/nOiVqPntzQZXa fV0a/BBGoYcYImzpp5bBax7+wV5ThVVvPtLxy279Otrr83e8AYQ2gQyoa/MzTTjwj7Bwuy QjZjRVxxf0otrcfovIF5ZBvrgXlTx0urTEJrt9/ajW4kS3nc0lkZ3YPrCMPP8Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697736496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uThdu/WKdVZvlDZNe596rGZZm7DmSvHjz1U0Z5FcI1k=; b=knEF83FUK3/LEWHXKTNljRXNGIzxkPZCK3szdOwJmOfVcH3dFpZRdmqfj/fFDAL3i/48jE CSD0syxpqct8iwXvcKfj+brP4QgWoZ1xaHwB9xhjAtHlZjfjk8u/D8JyQSHoCaLSPfLOWm T+7YSudNrkXs5ygXmslgmNaM/8zeCyusgHJVc6uggVHfsStOYQXPmsLYXZ2ugRSV09tv1v 797CaVTNUt3jlkrJpeVOx8lONpHzVPXS5vh/JrabFuDU8IcnqGpsMGkifDf5kTEbt74Rtd PlCgQwTl3kXQQHWpGRAvoUA/JQlnO+Gxme2VXLuywomBDvZq3349uyMFKqhVng== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SBF6l4qS4z19M1; Thu, 19 Oct 2023 17:28:15 +0000 (UTC) (envelope-from zlei@FreeBSD.org) From: Zhenlei Huang Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: git: 02320f642095 - main - pmap: Prefer consistent naming for loader tunable Date: Fri, 20 Oct 2023 01:28:10 +0800 References: <202310191701.39JH1UXB041167@gitrepo.freebsd.org> To: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" In-Reply-To: <202310191701.39JH1UXB041167@gitrepo.freebsd.org> Message-Id: <07922B4A-923A-41A3-8134-10BAF338564B@FreeBSD.org> X-Mailer: Apple Mail (2.3696.120.41.1.4) > On Oct 20, 2023, at 1:01 AM, Zhenlei Huang wrote: >=20 > The branch main has been updated by zlei: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D02320f64209563e35fa371fc5eac9406= 7f688f7f >=20 > commit 02320f64209563e35fa371fc5eac94067f688f7f > Author: Zhenlei Huang > AuthorDate: 2023-10-19 17:00:31 +0000 > Commit: Zhenlei Huang > CommitDate: 2023-10-19 17:00:31 +0000 >=20 > pmap: Prefer consistent naming for loader tunable >=20 > The sysctl knob 'vm.pmap.pv_entry_max' becomes a loader tunable = since > 7ff48af7040f (Allow a specific setting for pv entries) but is = fetched > from system environment 'vm.pmap.pv_entries'. That is inconsistent = and The 'system environment' is misleading. I meant 'kernel environment' . Sorry for fast commit. > obscure. >=20 > This reverts 36e1b9702e21 (Correct the tunable name in the = message). >=20 > PR: 231577 > Reviewed by: jhibbits, alc, kib > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D42274 > --- > sys/arm/arm/pmap-v6.c | 4 ++-- > sys/i386/i386/pmap.c | 4 ++-- > sys/powerpc/booke/pmap.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/sys/arm/arm/pmap-v6.c b/sys/arm/arm/pmap-v6.c > index 719851432203..92e992a4b25e 100644 > --- a/sys/arm/arm/pmap-v6.c > +++ b/sys/arm/arm/pmap-v6.c > @@ -1750,7 +1750,7 @@ pmap_init(void) > */ > TUNABLE_INT_FETCH("vm.pmap.shpgperproc", &shpgperproc); > pv_entry_max =3D shpgperproc * maxproc + vm_cnt.v_page_count; > - TUNABLE_INT_FETCH("vm.pmap.pv_entries", &pv_entry_max); > + TUNABLE_INT_FETCH("vm.pmap.pv_entry_max", &pv_entry_max); > pv_entry_max =3D roundup(pv_entry_max, _NPCPV); > pv_entry_high_water =3D 9 * (pv_entry_max / 10); >=20 > @@ -3012,7 +3012,7 @@ get_pv_entry(pmap_t pmap, boolean_t try) > if (ratecheck(&lastprint, &printinterval)) > printf("Approaching the limit on PV entries, = consider " > "increasing either the vm.pmap.shpgperproc = or the " > - "vm.pmap.pv_entries tunable.\n"); > + "vm.pmap.pv_entry_max tunable.\n"); > retry: > pc =3D TAILQ_FIRST(&pmap->pm_pvchunk); > if (pc !=3D NULL) { > diff --git a/sys/i386/i386/pmap.c b/sys/i386/i386/pmap.c > index 6b839484e6c5..967ad48de460 100644 > --- a/sys/i386/i386/pmap.c > +++ b/sys/i386/i386/pmap.c > @@ -998,7 +998,7 @@ __CONCAT(PMTYPE, init)(void) > */ > TUNABLE_INT_FETCH("vm.pmap.shpgperproc", &shpgperproc); > pv_entry_max =3D shpgperproc * maxproc + vm_cnt.v_page_count; > - TUNABLE_INT_FETCH("vm.pmap.pv_entries", &pv_entry_max); > + TUNABLE_INT_FETCH("vm.pmap.pv_entry_max", &pv_entry_max); > pv_entry_max =3D roundup(pv_entry_max, _NPCPV); > pv_entry_high_water =3D 9 * (pv_entry_max / 10); >=20 > @@ -2519,7 +2519,7 @@ get_pv_entry(pmap_t pmap, boolean_t try) > if (ratecheck(&lastprint, &printinterval)) > printf("Approaching the limit on PV entries, = consider " > "increasing either the vm.pmap.shpgperproc = or the " > - "vm.pmap.pv_entries tunable.\n"); > + "vm.pmap.pv_entry_max tunable.\n"); > retry: > pc =3D TAILQ_FIRST(&pmap->pm_pvchunk); > if (pc !=3D NULL) { > diff --git a/sys/powerpc/booke/pmap.c b/sys/powerpc/booke/pmap.c > index fe6b95eda085..f41ea24cd30c 100644 > --- a/sys/powerpc/booke/pmap.c > +++ b/sys/powerpc/booke/pmap.c > @@ -1069,7 +1069,7 @@ mmu_booke_init(void) > TUNABLE_INT_FETCH("vm.pmap.shpgperproc", &shpgperproc); > pv_entry_max =3D shpgperproc * maxproc + vm_cnt.v_page_count; >=20 > - TUNABLE_INT_FETCH("vm.pmap.pv_entries", &pv_entry_max); > + TUNABLE_INT_FETCH("vm.pmap.pv_entry_max", &pv_entry_max); > pv_entry_high_water =3D 9 * (pv_entry_max / 10); >=20 > uma_zone_reserve_kva(pvzone, pv_entry_max);