From nobody Thu Oct 19 14:41:43 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SB9Qs1gblz4xWZ7 for ; Thu, 19 Oct 2023 14:41:57 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SB9Qr6TxMz4XYG for ; Thu, 19 Oct 2023 14:41:56 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4083f61312eso14574135e9.3 for ; Thu, 19 Oct 2023 07:41:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697726515; x=1698331315; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aJcPdynuVtlnT4qNwZy5h9AXj/VZvzpoz2++U2mHWe0=; b=jXcBg8Cg3bGTe7XNOm5PDG1iBXmLY9VslEt6iFRZ5IouuNFREGFm5IIgWLqzky1PkC 0Mv0w/DpvHaFwGqZJ19apcI3DoP1+OpkL/F05o7Mp6b0pHZWxShLLCEtdOtDJ8sB5IJq Ms8tvsSvVx91Y7V8aZsFoGXkefzhdYVr+fAun3tGooTUtKybinzwlDhEYP2SI4ME+5rY DAQTAYv/Vw02q5g6t/RYJf6C3MgbmJKAZjWTTzCegkU43zq0FhBL5amhTIV4EAXxOPQK yiE6JqshygAeomks/NOgmUhkjS55fyYG3B7hvhkf3U+dB39Em4itSVk6GAHGIDgnHp1I dCLg== X-Gm-Message-State: AOJu0YwT1KrKWZm2RViBuiSs5sVexP+gm4z8cnCx24PcUC7JIdgWoZZU HYyn4kwiD0jVJ/+I2UvMfy/u9QrwhD4XlvbFy9tAoQ== X-Google-Smtp-Source: AGHT+IFPvOBUbeY2g2HGBXdbkUEkisGXWikmzj5RiogkeaZx8EcWrV8UsF0clAaqgbIFIOBPNW3HJw== X-Received: by 2002:a05:600c:17d3:b0:405:40ec:415d with SMTP id y19-20020a05600c17d300b0040540ec415dmr1932374wmo.39.1697726514900; Thu, 19 Oct 2023 07:41:54 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id x22-20020a05600c189600b004083a105f27sm4510684wmp.26.2023.10.19.07.41.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2023 07:41:54 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.100.2.1.4\)) Subject: Re: git: 9eff6390718d - main - pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h From: Jessica Clarke In-Reply-To: <202310191420.39JEKitw071108@gitrepo.freebsd.org> Date: Thu, 19 Oct 2023 15:41:43 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <1DDF7B7C-9137-48F4-80C9-FDCC82F47118@freebsd.org> References: <202310191420.39JEKitw071108@gitrepo.freebsd.org> To: Kristof Provost X-Mailer: Apple Mail (2.3774.100.2.1.4) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4SB9Qr6TxMz4XYG On 19 Oct 2023, at 15:20, Kristof Provost wrote: >=20 > The branch main has been updated by kp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D9eff6390718d0fa67dffc6cd830b0bc6= b815e8c4 >=20 > commit 9eff6390718d0fa67dffc6cd830b0bc6b815e8c4 > Author: Kristof Provost > AuthorDate: 2023-10-19 10:06:29 +0000 > Commit: Kristof Provost > CommitDate: 2023-10-19 14:19:39 +0000 >=20 > pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h >=20 > When userspace includes pfvar.h it doesn't get the kernel's = COMPAT_* > defines, so we end up not having required symbols in userspace. = This > caused the libpfctl port to fail to build. >=20 > libpfctl will be updated to use the new netlink-based state export = code > soon, which will also fix thix build issue. >=20 > Sponsored by: Rubicon Communications, LLC ("Netgate") That=E2=80=99s normally a feature to stop userspace using deprecated = things. Will you be reverting this once libpfctl is fixed? One could also hack libpfctl instead to define COMPAT_FREEBSD14 temporarily (IIRC that=E2=80=99= s what was done for kbdcontrol to allow it to run on old kernels). Jess