From nobody Mon Oct 02 14:06:02 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RzjRH1pMcz4w6kC; Mon, 2 Oct 2023 14:06:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RzjRH0lcLz3Yqp; Mon, 2 Oct 2023 14:06:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696255563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/YxTmVGFgkPF8qwsdIUa2KJYTj/LgcXAZZPg1ilfKj0=; b=AES7uOClVm1WLaNWFw1NmdLcYP3D+r415BGgCpYgK2bEw22IwtqTznnqzlkdkUUzjy3WSG 9+EuLR/zggNCUxvcoFOdqbird8bH0QdUaqGmqEoWIKSEtx5AmpHmXPgri2gfQoQfgNZ4VM zxAwNM8zmglYHDJSq+mwmxERCSuH0AZLuM8nQH7vswuh3jkgtIVl1//Zy5bfd44ZdvLoCn mNSxFuQCKsyXxWvefR6Xs4Jgk8EzgCiH4tQEdhnHGbqdLrU8V4NHkMvBGoEwDR3wQQtl0b h3Z2M1ViJfJUiEY20keawmgV4AkR8n4KrAsYKBc8S9CVIKXT1+Hy3FE8Ak+0Nw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696255563; a=rsa-sha256; cv=none; b=OSlFOhDgJDRoITPoPc+xwWHBCwTKl7sry1cQt2mL6Sprs5CF26C6kScoJnozHfgS0DxxXy eGUwHypkgVK3a/gnkFjWBRDMX7gLysJAVAe2nLOORAFDRbaFgC5WSxoJtHalmBxfcPXSzj EZyw0lJh2pZ35H6d+2uzd3gjja+oiKslat8dkofpzGUIkPoq8VuVUKP43e/uoY7zNQpRcB BCOMpsJXg22bRU4XFaFxTiba/afSpQ+4FL334kef2I4E/3InmlQ+j0L1vA2t2rHZwcr/7j gJ0K9MFLtCqzjyEStczflbiO71D45FEFWnV8gct+RPjb/Xzo58djO/q8yUoPVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696255563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/YxTmVGFgkPF8qwsdIUa2KJYTj/LgcXAZZPg1ilfKj0=; b=gVr44jiOfeqQ6xk3/2AZmmih3uz/tpp0JkIidYDo8080I4xe3qh9Xifv3a5+l3Ss4mivT7 +Vxj992ZX+i2s3Pt8HHOWhS4G/M1Q/oSb8F5CQpi/q393GqohgYwBT//BxmNRt6iUCcNSz I3cgwP/9LUjzLaSR4x/Lu/teYvSDeggBSpk+uz4pR+IC5sN9JwE68kONmW67YpeinrFVYb 9sbFB0lGSFWl7EHSp6777SAkn3Fe+sGyfMZ2lhobYSB7UrIQUDcd0Gh/qyVVsO8PlALhz3 Xda1xHJ5hgycKSVLWbxS/Uqby/7lwJBwDe1zEmd8pQRPTkuoQOv+1UB+KZa/6w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RzjRG6NdLz17P; Mon, 2 Oct 2023 14:06:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 392E629r052508; Mon, 2 Oct 2023 14:06:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 392E62du052505; Mon, 2 Oct 2023 14:06:02 GMT (envelope-from git) Date: Mon, 2 Oct 2023 14:06:02 GMT Message-Id: <202310021406.392E62du052505@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: db195a523f9b - main - net80211: make ieee80211_alloc_node() private List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: db195a523f9bbeb111b621d2c2c7a46d8b921631 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=db195a523f9bbeb111b621d2c2c7a46d8b921631 commit db195a523f9bbeb111b621d2c2c7a46d8b921631 Author: Bjoern A. Zeeb AuthorDate: 2023-10-02 13:57:45 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-10-02 14:05:03 +0000 net80211: make ieee80211_alloc_node() private Looking through the allocation/free and reference cycle of nodes we have a few (publicly) (almost) unused macros and functions. Start making them private and reducing the amount of entry paths to the same/similar functionality. First is to make ieee80211_alloc_node() static as it is nowhere used in the tree outside this file. Sponsored by: The FreeBSD Foundation X-MFC: no --- sys/net80211/ieee80211_node.c | 5 ++++- sys/net80211/ieee80211_node.h | 3 --- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/net80211/ieee80211_node.c b/sys/net80211/ieee80211_node.c index 39b411059cf1..b7cdc5090c96 100644 --- a/sys/net80211/ieee80211_node.c +++ b/sys/net80211/ieee80211_node.c @@ -82,6 +82,9 @@ CTASSERT((IEEE80211_NODE_HASHSIZE & (IEEE80211_NODE_HASHSIZE-1)) == 0); static int ieee80211_sta_join1(struct ieee80211_node *); +static struct ieee80211_node *ieee80211_alloc_node( + struct ieee80211_node_table *, struct ieee80211vap *, + const uint8_t macaddr[IEEE80211_ADDR_LEN]); static struct ieee80211_node *node_alloc(struct ieee80211vap *, const uint8_t [IEEE80211_ADDR_LEN]); static int node_init(struct ieee80211_node *); @@ -1396,7 +1399,7 @@ ieee80211_del_node_nt(struct ieee80211_node_table *nt, ni->ni_table = NULL; } -struct ieee80211_node * +static struct ieee80211_node * ieee80211_alloc_node(struct ieee80211_node_table *nt, struct ieee80211vap *vap, const uint8_t macaddr[IEEE80211_ADDR_LEN]) { diff --git a/sys/net80211/ieee80211_node.h b/sys/net80211/ieee80211_node.h index 7c9ff70bcb71..826ecccb1238 100644 --- a/sys/net80211/ieee80211_node.h +++ b/sys/net80211/ieee80211_node.h @@ -395,9 +395,6 @@ struct ieee80211_node_table { int nt_inact_init; /* initial node inact setting */ }; -struct ieee80211_node *ieee80211_alloc_node(struct ieee80211_node_table *, - struct ieee80211vap *, - const uint8_t macaddr[IEEE80211_ADDR_LEN]); struct ieee80211_node *ieee80211_tmp_node(struct ieee80211vap *, const uint8_t macaddr[IEEE80211_ADDR_LEN]); struct ieee80211_node *ieee80211_dup_bss(struct ieee80211vap *,