From nobody Tue Nov 21 18:35:49 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SZY3T52XNz524my; Tue, 21 Nov 2023 18:35:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SZY3T2cssz4pM0; Tue, 21 Nov 2023 18:35:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700591749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RPdnHBmXuKirXziWIol9kKx4nYkCslQcTjSxcOTYYmI=; b=UtO6f0NI6GJtgJ+guMAPE9YVwQgIWGhNV1l9ZzEubJerwXlplB4AnwE1tOXeb6Ha/BrNa2 HN5dT7JImA4NqUQX0EWitM0fA1AfCBVle3j+jocAzE2b3KKdWFt6A1utTxGGZ9FlVX02dx t5UuW5XDX04vEUWZNrPr9ftZgFwOa4183c8QliaDAoXM2xs2mYhV+3imcCgF81EWgSCv5E 3ZJBOvtsv3I/WDlQr4IJMTpVmaWoHOp8Sie5bSDLvDnxAwJF1l7VPoNLi2xymMJZ4Cm++m zBgTgVtGaRRrDeISuiB4LRDqz1WGyXS2rZtUB5xXxSGW5ORiAte20YkPxELPDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700591749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RPdnHBmXuKirXziWIol9kKx4nYkCslQcTjSxcOTYYmI=; b=jc65WnH3YritMQULTui839qPKRUqQ29fWNGFCWtod/ad0GT3h4fnLRuPpdQZquq+OvI3Jj D7mKz6caH4STqL6zTR3cfnZ1qEsaH4vimg/7By51pBQFZr8ts/lRz15oig7SAFCneXfJCK 6Se0dz5iQLecClwBb4ZJXwf+i0WEHJnVYuLh1xIWUsSI8omUoZsWaHJaVNlibJhkgRRS5S dHoN0B17aFXxfkdX1lQZIYkThCa21EdnbpcxuWX2frwrDFnLOTRDHvqnQMByshyxqy4SGQ zEG/aDECB2UsSGHO339fmtV99x9XH73Bfj/knJuLoQLyd6G+fTdUpdDQ48KyjA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1700591749; a=rsa-sha256; cv=none; b=ZeKduLdasqyRdXAU5iwDekWK7Xw7kkOKxwUS3kJDCD1earPPwmq0q6aw8k5wdXsn3knwMC HaTBpWKMw82H95shMxZ+ZvboSh4PUamNhjXPy669EzWsRwI90P+VAfMAmfYN2s9xVwL2n5 2vvmYDypKFDTlVMMbOQktrh3iCqdLTN/A9glVSJvZw7UmZdh492P9F/E/ltzIOn1VLsdeT cjxDU/e9gAuMVdkV69/nft3zpP8X4dAr6bpKrnCcg/jn6FvJxMXFfx7FvGiuOzDJiCRJ17 Py+F7ZufqdpSRKK62cxOZ/KzgiF5b1AO64aouu/Sj9eYKzmpGSUYysayBg7eUA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SZY3T1ggJzmkL; Tue, 21 Nov 2023 18:35:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3ALIZnOE045743; Tue, 21 Nov 2023 18:35:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3ALIZnNi045740; Tue, 21 Nov 2023 18:35:49 GMT (envelope-from git) Date: Tue, 21 Nov 2023 18:35:49 GMT Message-Id: <202311211835.3ALIZnNi045740@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 9d882de2da20 - main - Remove sysctl 'kern.smp.forward_signal_enabled' List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9d882de2da2099f534776ba4a6278e8c0bc87660 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=9d882de2da2099f534776ba4a6278e8c0bc87660 commit 9d882de2da2099f534776ba4a6278e8c0bc87660 Author: Olivier Certner AuthorDate: 2023-10-20 13:43:29 +0000 Commit: Mark Johnston CommitDate: 2023-11-21 18:25:34 +0000 Remove sysctl 'kern.smp.forward_signal_enabled' It seems this was an "emergency" knob to revert a newly introduced behavior. Overall, we want better system-wide signal receive latency, and it doesn't seem that some contrary policy was ever needed (and if that comes up, it should rather be implemented, e.g., per-process). Suggested by: kib Reviewed by: kib, jhb Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D42315 --- sys/kern/subr_smp.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sys/kern/subr_smp.c b/sys/kern/subr_smp.c index 7cbf83928786..399665b47751 100644 --- a/sys/kern/subr_smp.c +++ b/sys/kern/subr_smp.c @@ -113,12 +113,6 @@ SYSCTL_INT(_kern_smp, OID_AUTO, topology, CTLFLAG_RDTUN, &smp_topology, 0, "Topology override setting; 0 is default provided by hardware."); #ifdef SMP -/* Enable forwarding of a signal to a process running on a different CPU */ -static int forward_signal_enabled = 1; -SYSCTL_INT(_kern_smp, OID_AUTO, forward_signal_enabled, CTLFLAG_RW, - &forward_signal_enabled, 0, - "Forwarding of a signal to a process on a different CPU"); - /* Variables needed for SMP rendezvous. */ static volatile int smp_rv_ncpus; static void (*volatile smp_rv_setup_func)(void *arg); @@ -205,8 +199,6 @@ forward_signal(struct thread *td) if (!smp_started || cold || KERNEL_PANICKED()) return; - if (!forward_signal_enabled) - return; /* No need to IPI ourself. */ if (td == curthread)