From nobody Sat Nov 04 16:39:43 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SN3HM4XvZz4ypFr; Sat, 4 Nov 2023 16:39:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SN3HM41v0z3KH8; Sat, 4 Nov 2023 16:39:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699115983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=piiNrwWfW/NOUceqInKjeKsdSNS3oxdLXJLjRw9Sh9w=; b=K+hMRdextFJaDT66VtxQZAFZLF8z3PH+2vukMnJaXe1OB11vqyO1kzJiSBjv4i2KJLsMMY Vn2PaHkhNJ186vAccWlL4/eAqHnjeAF26DmHfTeDITTPYwkroe28CbVJukizrCSBwpcAbW vKJXjaCne/98Q2xoaItVepPCiRx90fgqECIVj2ocQJDcE+GVAXphLJt9u+nnmJGvoJSYfi 4k/qEkG7+k47tpPmxstIm4zLfUFxb9qv8V3qzmFZMjVROZwCmM4ijjA3r9WdsCJKw3xej8 Z3QWzWsS7rh30sjYSKi3hdxkbbCU3JCTvWCCOym3wOYtHi55NtfcL3NCe021SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699115983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=piiNrwWfW/NOUceqInKjeKsdSNS3oxdLXJLjRw9Sh9w=; b=jaDS8acKOmqEsy4BFI3aGTDuJ1FNSg2R+uUcKcQXMAAHvIYzhrreCNuJhDpTW4y88sEZH+ R/yJaV1TGscWcUWAdq3OmxwsspuNG/zbulr3nVyHH0EBitchQKyIzzis6qfF/164cfH6O/ SbqZTNdkWZAsHJvg5UP9evmTjIFhzB9ZeC4H/kvD/0PPqfkMoIWv+9iHJfpqd+E7crE+aW iH18dFSM/tD0xQPIYqe3/+/cANFXCg6PzdKswEylMjhllUVrd+F4K0CJkbd0gKmMT2op0V 4xYKvfcKaOafB6YCbR6wjWyODH16kq0MRkTOyyRNivns36wjp71NKh+LvxjVdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699115983; a=rsa-sha256; cv=none; b=lcp0n+zaimEX3zkYjc19mpHie7UAvPMjc+kGRZXCiSYgQ6vACdh3seQmjVrE1Em6FoQEah 3sY5/nIFnEileltkmwZrNtt8c39W7pQ1TyjYt66lXP9E018XiUSQqwmPqlozSvbiBoQEZE HO5EvcSS/MI8hB3RPFq4eDQYpahcm71f2PWY/58l7BPV6VMGxh7/oDY0C0NmPiIuehtfoY /iT3AA+8SebQOND2ubXqCE7Ef9PwaqTVOdzX6IhxHhSKmK3tn4rG+JsbAwyQElKICGdDjs /fP7H0QeR0M+01QYbd/4p6M6hw9eoFitwPRzF91wqveR9KocYiiQ3eNF/Pci5Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SN3HM34r4z152m; Sat, 4 Nov 2023 16:39:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3A4GdhgR037210; Sat, 4 Nov 2023 16:39:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3A4GdhP5037207; Sat, 4 Nov 2023 16:39:43 GMT (envelope-from git) Date: Sat, 4 Nov 2023 16:39:43 GMT Message-Id: <202311041639.3A4GdhP5037207@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alexander Motin Subject: git: 939a62d673e6 - main - stand/zfs: Remove read-compatible features List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mav X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 939a62d673e6c340ee2b7243074a529919e39196 Auto-Submitted: auto-generated The branch main has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=939a62d673e6c340ee2b7243074a529919e39196 commit 939a62d673e6c340ee2b7243074a529919e39196 Author: Alexander Motin AuthorDate: 2023-11-04 16:26:25 +0000 Commit: Alexander Motin CommitDate: 2023-11-04 16:26:25 +0000 stand/zfs: Remove read-compatible features These features are marked as ZFEATURE_FLAG_READONLY_COMPAT and so irrelevant for read-only pool imports by the loader: "com.datto:resilver_defer", "com.delphix:obsolete_counts", "com.delphix:spacemap_histogram", "com.delphix:zpool_checkpoint", "com.intel:allocation_classes", "org.zfsonlinux:allocation_classes" This should cause no functional changes, just a code cleanup. MFC after: 2 months --- stand/libsa/zfs/zfsimpl.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/stand/libsa/zfs/zfsimpl.c b/stand/libsa/zfs/zfsimpl.c index b904ead24e1d..253cfd2f16e3 100644 --- a/stand/libsa/zfs/zfsimpl.c +++ b/stand/libsa/zfs/zfsimpl.c @@ -113,23 +113,19 @@ typedef struct indirect_vsd { static vdev_list_t zfs_vdevs; /* - * List of ZFS features supported for read + * List of supported read-incompatible ZFS features. Do not add here features + * marked as ZFEATURE_FLAG_READONLY_COMPAT, they are irrelevant for read-only! */ static const char *features_for_read[] = { "com.datto:bookmark_v2", "com.datto:encryption", - "com.datto:resilver_defer", "com.delphix:bookmark_written", "com.delphix:device_removal", "com.delphix:embedded_data", "com.delphix:extensible_dataset", "com.delphix:head_errlog", "com.delphix:hole_birth", - "com.delphix:obsolete_counts", - "com.delphix:spacemap_histogram", "com.delphix:spacemap_v2", - "com.delphix:zpool_checkpoint", - "com.intel:allocation_classes", "com.joyent:multi_vdev_crash_dump", "com.klarasystems:vdev_zaps_v2", "org.freebsd:zstd_compress", @@ -138,7 +134,6 @@ static const char *features_for_read[] = { "org.illumos:skein", "org.open-zfs:large_blocks", "org.openzfs:blake3", - "org.zfsonlinux:allocation_classes", "org.zfsonlinux:large_dnode", NULL };