From nobody Tue May 23 13:59:33 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QQbXn56DCz4CWMs for ; Tue, 23 May 2023 13:59:37 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QQbXm5Nk9z413R for ; Tue, 23 May 2023 13:59:36 +0000 (UTC) (envelope-from rrs@netflix.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=netflix.com header.s=google header.b=LPIt0kuh; spf=pass (mx1.freebsd.org: domain of rrs@netflix.com designates 2607:f8b0:4864:20::72b as permitted sender) smtp.mailfrom=rrs@netflix.com; dmarc=pass (policy=reject) header.from=netflix.com Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-75b050b4fa0so256991685a.0 for ; Tue, 23 May 2023 06:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; t=1684850376; x=1687442376; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=jeoSEAL6mLQTMBn4CGO2KmvRyxJOf97sBuJdGur4X1M=; b=LPIt0kuhYN4ZWIF6ZAZ3IS18TKaADFcAUlLNV90Nd5n5wjwu9jCv5Gmy+4SRcfSmSV VKvHBM9wAl7PZPjaPOLFPGqI9vVLfZaT3ZU90P2KV7idwbBsnPzmBEii/YyAudLLsJbY AqCmIJuo6USAKqNWee6WBGXDOgQ0rLSEond4w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684850376; x=1687442376; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jeoSEAL6mLQTMBn4CGO2KmvRyxJOf97sBuJdGur4X1M=; b=fNEAnF5wC8+Cpq5TeUzwJnU05NzoItF2JMNkCUDmxXk66yDr2oMBzCFw6QwqnYdRsV qlHHCr3BOgx0slcXjeAxWGQxQGWpoJQiNHyJInph74CknNJaOtGwAqHmzmgZyXK3UpGU p0Axj/cXJvOerHg1PXLqtDM87op1u7efCBPjPy5DbF+o9SsE6rZpLIAPUjlTrknmfEG7 af5HrCDKEtXr4ne14/QP7BU1UR6+A2shbO1J7EsMEhy3i8ppDx1ZNXoGSK3ppnYbxPlU 7az5YCavy0RECX/3/rghxJ72bJS7rh/XA5OkJ8OHneo6GmtTgR1R3BhHN8uYV7r/pKo4 YHcg== X-Gm-Message-State: AC+VfDzh4y6gRqbWmvMQ1TyquzBiUmrlMeWFAn3YD3ZYYqQNIvIIYq77 GJXqMl3c0V3h+OQzSyqZhKrgNjsErftPnj+ATKg= X-Google-Smtp-Source: ACHHUZ6pewfwCuFjOxLSL2QsRrsF2g3eQXgnEt1MTgfAdKyfBnxebQCpHJMRu3l801jpgiVxLBXLlg== X-Received: by 2002:a05:620a:2a52:b0:75b:23a1:47b with SMTP id q18-20020a05620a2a5200b0075b23a1047bmr4307784qkp.65.1684850375867; Tue, 23 May 2023 06:59:35 -0700 (PDT) Received: from smtpclient.apple ([2607:fb10:7061:101::637]) by smtp.gmail.com with ESMTPSA id x25-20020a05620a12b900b007576f08d3a0sm2534069qki.44.2023.05.23.06.59.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 May 2023 06:59:35 -0700 (PDT) From: Randall Stewart Message-Id: <1E5C3216-1A6F-43AC-AA91-24FA1EA18842@netflix.com> Content-Type: multipart/signed; boundary="Apple-Mail=_1025A52E-98E4-4DB8-85E6-BD39C353D7B1"; protocol="application/pkcs7-signature"; micalg=sha-256 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: git: 73ee5756dee6 - main - Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. Date: Tue, 23 May 2023 09:59:33 -0400 In-Reply-To: <20230522070643.99f8aa0c5509c0d3a5f2ae0b@dec.sakura.ne.jp> Cc: Randall Ray Stewart , Antoine Brodin , dev-commits-src-main@freebsd.org To: Tomoaki AOKI References: <20230522070643.99f8aa0c5509c0d3a5f2ae0b@dec.sakura.ne.jp> X-Mailer: Apple Mail (2.3696.120.41.1.3) X-Spamd-Result: default: False [-15.59 / 15.00]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; SIGNED_SMIME(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.20)[multipart/signed,multipart/alternative,text/plain]; HAS_GOOGLE_REDIR(0.01)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TO_MATCH_ENVRCPT_SOME(0.00)[]; HAS_ATTACHMENT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_DN_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::72b:from]; BLOCKLISTDE_FAIL(0.00)[2607:fb10:7061:101::637:server fail,2607:f8b0:4864:20::72b:server fail]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~,4:~]; FREEFALL_USER(0.00)[rrs]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 4QQbXm5Nk9z413R X-Spamd-Bar: --------------- X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_1025A52E-98E4-4DB8-85E6-BD39C353D7B1 Content-Type: multipart/alternative; boundary="Apple-Mail=_2CFBEC81-0A8F-4100-92B3-C15C10F11BC2" --Apple-Mail=_2CFBEC81-0A8F-4100-92B3-C15C10F11BC2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 https://reviews.freebsd.org/D40229 Should fix this :) R > On May 21, 2023, at 6:06 PM, Tomoaki AOKI = wrote: >=20 >> On Tue, Apr 4, 2023 at 12:31=E2=80=AFPM Randall Stewart = wrote: >>>=20 >>> The branch main has been updated by rrs: >>>=20 >>> URL: = https://www.google.com/url?q=3Dhttps://cgit.FreeBSD.org/src/commit/?id%3D7= 3ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f&source=3Dgmail-imap&ust=3D16853116= 14000000&usg=3DAOvVaw0HmtU6ylNo8jRrPgvtzIB0 >>>=20 >>> commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f >>> Author: Randall Stewart >>> AuthorDate: 2023-04-01 05:46:38 +0000 >>> Commit: Randall Stewart >>> CommitDate: 2023-04-01 05:46:38 +0000 >>>=20 >>> Fixes in the tcp infrastructure with respect to stack changes as = well as other infrastructure updates for incoming rack features. >>>=20 >>> So stack switching as always been a bit of a issue. We currently = use a break before make setup which means that >>> if something goes wrong you have to try to get back to a stack. = This patch among a lot of other things changes that so >>> that it is a make before break. We also expand some of the = function blocks in prep for new features in rack that will allow >>> more controlled pacing. We also add other abilities such as the = pathway for a stack to query a previous stack to acquire from >>> it critical state information so things in flight don't get = dropped or mis-handled when switching stacks. We also add the >>> concept of a timer granularity. This allows an alternate stack to = change from the old ticks granularity to microseconds and >>> of course this even gives us a pathway to go to nanosecond = timekeeping if we need to (something for the data center to consider >>> for sure). >>>=20 >>> Once all this lands I will then update rack to begin using all = these new features. >>>=20 >>> Reviewed by: tuexen >>> Sponsored by: Netflix Inc >>> Differential Revision: = https://www.google.com/url?q=3Dhttps://reviews.freebsd.org/D39210&source=3D= gmail-imap&ust=3D1685311614000000&usg=3DAOvVaw1ZouYiMywAnpdYyYCp9T9O >>=20 >> Hi, >>=20 >> Could you hide some stuff in netinet/tcp.h? >> struct http_req breaks curl 8.1.0. >>=20 >> Antoine >=20 > Please refer to Bug 271526 [1], especially Comment 4 [2] by Jonathan > Reynolds. > A patch is proposed there inline (not as an attachment). >=20 > [1] = https://www.google.com/url?q=3Dhttps://bugs.freebsd.org/bugzilla/show_bug.= cgi?id%3D271526&source=3Dgmail-imap&ust=3D1685311614000000&usg=3DAOvVaw2e-= 0D0bz7CAIVj6kvLZOJg >=20 > [2] = https://www.google.com/url?q=3Dhttps://bugs.freebsd.org/bugzilla/show_bug.= cgi?id%3D271526%23c4&source=3Dgmail-imap&ust=3D1685311614000000&usg=3DAOvV= aw154j12MkBXKn2z9_gepR1n >=20 > --=20 > Tomoaki AOKI ------ Randall Stewart rrs@netflix.com --Apple-Mail=_2CFBEC81-0A8F-4100-92B3-C15C10F11BC2 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

Should fix this :)

R
On May 21, 2023, at 6:06 PM, Tomoaki AOKI = <junchoon@dec.sakura.ne.jp> wrote:

On Tue, Apr 4, 2023 at = 12:31=E2=80=AFPM Randall Stewart <rrs@freebsd.org> wrote:

The branch main has been updated = by rrs:

URL: https://www.google.com/url?q=3Dhttps://cgit.FreeBSD.org/src/com= mit/?id%3D73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f&source=3Dgmail-imap= &ust=3D1685311614000000&usg=3DAOvVaw0HmtU6ylNo8jRrPgvtzIB0

commit = 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f
Author: =     Randall Stewart <rrs@FreeBSD.org>
AuthorDate: 2023-04-01 05:46:38 +0000
Commit: =     Randall Stewart <rrs@FreeBSD.org>
CommitDate: 2023-04-01 05:46:38 +0000

   Fixes in the tcp infrastructure with = respect to stack changes as well as other infrastructure updates for = incoming rack features.

=    So stack switching as always been a bit of a issue. We = currently use a break before make setup which means that
=    if something goes wrong you have to try to get back to = a stack. This patch among a lot of other things changes that so
   that it is a make before break. We also = expand some of the function blocks in prep for new features in rack that = will allow
   more controlled pacing. We = also add other abilities such as the pathway for a stack to query a = previous stack to acquire from
   it = critical state information so things in flight don't get dropped or = mis-handled when switching stacks. We also add the
=    concept of a timer granularity. This allows an = alternate stack to change from the old ticks granularity to microseconds = and
   of course this even gives us a = pathway to go to nanosecond timekeeping if we need to (something for the = data center to consider
   for sure).

   Once all this lands I will = then update rack to begin using all these new features.

   Reviewed by: tuexen
=    Sponsored by: Netflix Inc
=    Differential Revision: https://www.google.com/url?q=3Dhttps://reviews.freebsd.org/D392= 10&source=3Dgmail-imap&ust=3D1685311614000000&usg=3DAOvVaw1Zou= YiMywAnpdYyYCp9T9O

Hi,

Could you hide some stuff in netinet/tcp.h?
struct http_req breaks curl 8.1.0.

Antoine

Please = refer to Bug 271526 [1], especially Comment 4 [2] by Jonathan
Reynolds.
A patch is proposed there inline (not = as an attachment).

[1] https://www.google.com/url?q=3Dhttps://bugs.freebsd.org/bugzill= a/show_bug.cgi?id%3D271526&source=3Dgmail-imap&ust=3D1685311614000= 000&usg=3DAOvVaw2e-0D0bz7CAIVj6kvLZOJg

[2] https://www.google.com/url?q=3Dhttps://bugs.freebsd.org/bugzill= a/show_bug.cgi?id%3D271526%23c4&source=3Dgmail-imap&ust=3D16853116= 14000000&usg=3DAOvVaw154j12MkBXKn2z9_gepR1n

--
Tomoaki AOKI    <junchoon@dec.sakura.ne.jp>

------
Randall = Stewart



= --Apple-Mail=_2CFBEC81-0A8F-4100-92B3-C15C10F11BC2-- --Apple-Mail=_1025A52E-98E4-4DB8-85E6-BD39C353D7B1 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCAzYw ggMyMIICGqADAgECAgqxywKqrHPB2ybTMA0GCSqGSIb3DQEBCwUAMEcxGDAWBgNVBAMTD1JhbmRh bGwgU3Rld2FydDEeMBwGCSqGSIb3DQEJARYPcnJzQG5ldGZsaXguY29tMQswCQYDVQQGEwJVUzAe Fw0yMTAxMjQxMjIwMTRaFw0yNjAxMjQxMjIwMTRaMEcxGDAWBgNVBAMTD1JhbmRhbGwgU3Rld2Fy dDEeMBwGCSqGSIb3DQEJARYPcnJzQG5ldGZsaXguY29tMQswCQYDVQQGEwJVUzCCASIwDQYJKoZI hvcNAQEBBQADggEPADCCAQoCggEBAMUAht2nr/NFlK+tmmN9PdO3DBPfeYh9fLcbVihR+/dipO41 AsFy9y+2uDVaFhTEvp406P0o9PQQTuYXqrCr76eWQIj3V787e1WKjTup1mIyQeWHGf1gvb/7vmI2 zHg6QZEIC4W8xeO8SLKyHiwlFHZn8Rn1HxtB7Ge+NulygkgUgJYhXD5E29jVGXAc6Qn9Vr9AexPf KaOhHCaNB/Twcinayz6D8CO/Ym1LOs3+ceSOa4cB07fepmbqDSXDkOeA3U7KLaluHrRTlj6DO+JU nqKXX7jJ68KTYSZ0qH4fZsk8cxFkwYI/3HDJi+oF+FDkf7SRo1Q2w+e3M/5MReLIQ7sCAwEAAaMg MB4wDwYJKoZIhvcvAQEKBAIFADALBgNVHQ8EBAMCB4AwDQYJKoZIhvcNAQELBQADggEBAHJfum1j 1WIVFjOJT/hqMIN751aXkablmwesW94lNJKjslPULbbcP5nZGg2lGpHcZ+0I5F/1TTiEsT2H2rhA uAnSsUxTpxRA+aoe+xtJOa5vle3CprhFkHAvB7EIoLiNaPd0DNK6kKYsbvr5Z5Eq7TF3SIO77Qh9 /8VgUfOb0ARDgix59Q6MM0NmIabEwh0cDWQYlGgDDtN9DNk5PGM4pjs48suwEdLmFTMOmGTkCp7I Vq6iHDNinBiB6+BB4VYMAO1o9qS+0pnfdmPJybt0zVGrhm/c1Fmm3Jec7NEuiKeXmhPIwdwMkKyp AsX0sHuFCYwioBTHHZpvnir+H2rRakgxggHrMIIB5wIBATBVMEcxGDAWBgNVBAMTD1JhbmRhbGwg U3Rld2FydDEeMBwGCSqGSIb3DQEJARYPcnJzQG5ldGZsaXguY29tMQswCQYDVQQGEwJVUwIKscsC qqxzwdsm0zANBglghkgBZQMEAgEFAKBpMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZI hvcNAQkFMQ8XDTIzMDUyMzEzNTkzM1owLwYJKoZIhvcNAQkEMSIEIAbYQb7fTKF4Pexr1QJC+70g qQOunEr+EdpzNVV8zuEbMA0GCSqGSIb3DQEBCwUABIIBAKPBGO7X26mbuaKxnYl6ivOAtrO61moD G3s+Z3B9J7huKiT2fMnxDHLnir/Pj4VcYBJKzuI/nEgs5Y8TlP6+rrqjlUKkFckb7poGFyFt3uSK lz8tVA8dheiVisoIt4nOX6zQN/WyeCvp97oHT8KCjf2AQx4ms1DaeZldH5qCTF0kZKhXF6dHX3ET IYTtSHtZqLRh30Ibj2BFqlIKGaTGGuBVaE+kqLNk4RmG7zhSX1nu+JnJvffdERVZz6Jo7nioB+J5 0OudZOgqvOFCrd3JinhelYQg8mPjqc3VxO2poiYcEYOSHiWj1npnxn5dPCA72f/hsh1NOwITBDBK 2uvCCTYAAAAAAAA= --Apple-Mail=_1025A52E-98E4-4DB8-85E6-BD39C353D7B1--