From nobody Sun May 21 23:01:27 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QPbg83KK7z4Cbcv for ; Sun, 21 May 2023 23:01:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QPbg80PmZz3DRs for ; Sun, 21 May 2023 23:01:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5112cae8d82so4219882a12.2 for ; Sun, 21 May 2023 16:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1684710098; x=1687302098; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WDXuVcUKV5xprYfj4Rcf1PWf++KRG6LKG5uLMauKOPY=; b=ZZKKczf2+XDquw5lgxU1OaA/2isQ5TAIG7oyNwiHmMWNvUvnhSiF2oJV9kw8fd6baq RqlWuuBpI5V08h1QVZ8ALc3Nr1a1AGorTzSR1QtgA730GXSDbXSNFZdlFa+dM57F6rTW 8lAJmWv89SFfWGQNmg66n5UHmyq556nh68xKduUAn/Hb3VUdIx0ma8r1NiDZal7PW3EO wPGpg9s1ckIHjRlMdoE6+VYMF0GxZmna/cbMrNo47xiob2khX9Xv90dh7AAHACEhW/yG vh1cuvG7zN6CwUpjLGh81rmbkkvfNsoaWuN73FsS4aNdLWKGsbVeNzOXV2LYLVfGT4gg 1Ctw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684710098; x=1687302098; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WDXuVcUKV5xprYfj4Rcf1PWf++KRG6LKG5uLMauKOPY=; b=bgjg+3gBZdYBmiVz1/4Bh1kysDhGURNx+MBjGZtwOFZIeB/0ntVdZK79Xsp5LF8ZZ9 pdqAyhSrH/itFrtf1FpZxO3paqEAGrWrwixnEX4JQwBER8iH9rO5aEVUcDKgplkEjP+z n29gFSt7ocw997F3DZe50GFRjYde//PzUNPks+Hawt0EHnNBMQqWIdhqIjtPmntc50v+ T5tjWhX/riXsB0l6Pk9pS4XH0DUqwcHwwrUYhsEe9Tmp+O1SyGEND03ipyZTX4S6Nemy C78QQY8C1Eo+CrPtlS4B1Z3ZW1dmCrC5CRnzYGOLrQREOMS31yxTfGUWnqMgnbwhabHC 8iBw== X-Gm-Message-State: AC+VfDz9BnmdLMrq78SE7SHnCPFP2Kf5lGcuC/sRns7ytTkHtISUcx5m C2UHEtQudPqX0uXXioYaISbAUPb3e7x7H+NNAnvBew== X-Google-Smtp-Source: ACHHUZ4ODtiPVNukYnSR3YYddBRErquV4HFv1yyHu0KDOnM3QAHf0lEw3YCLOQftQDyoJ96wmTkdGaGwur3wRe38zp4= X-Received: by 2002:a50:ed8d:0:b0:510:55a3:97ad with SMTP id h13-20020a50ed8d000000b0051055a397admr7049655edr.0.1684710098254; Sun, 21 May 2023 16:01:38 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202305211621.34LGLsup059861@gitrepo.freebsd.org> <54EF67D8-2A79-4EAB-8EFB-232F14FFE792@freebsd.org> <21c9532e-4ca7-a7fe-1ff6-07a94cbad6ab@freebsd.org> <3066464F-E4C6-4B84-ADFF-E578AFAFE622@freebsd.org> <26465813-3B51-4E52-9E9D-F93A0F2AF6BD@freebsd.org> <2BF2F7CF-82E6-4D98-800D-C35D7C29E948@freebsd.org> <19a57dbf-81f0-8f57-554f-1791c5303088@freebsd.org> In-Reply-To: <19a57dbf-81f0-8f57-554f-1791c5303088@freebsd.org> From: Warner Losh Date: Sun, 21 May 2023 19:01:27 -0400 Message-ID: Subject: Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body. To: Hans Petter Selasky Cc: Jessica Clarke , src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000f4d7c205fc3c22b8" X-Rspamd-Queue-Id: 4QPbg80PmZz3DRs X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000f4d7c205fc3c22b8 Content-Type: text/plain; charset="UTF-8" On Sun, May 21, 2023, 4:32 PM Hans Petter Selasky wrote: > On 5/21/23 23:58, Jessica Clarke wrote: > > What I disputed was your commit message, which at best is extremely > misleading and at worst makes no sense, and the necessity of the change. > > Hi Jess, > > Your request for revert has been noted, but I see no urgency in such a > revert. The code is perfectly fine either way. > Now is not the time for stubbornness. This change is easy to bring back in if it proves to be what we want. Project custom dictates requests for back out be given strong consideration unless there's a really compelling reason why that's a bad idea. (And I don't see anything like that here). Just my suggestion... Also, I think time away from the keyboard would help de-escalate things. This change isn't worth getting so worked up over. Warner > --000000000000f4d7c205fc3c22b8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sun, May 21, 2023, 4:32 PM Hans Petter Selasky <= hselasky@freebsd.org> wrote:=
On 5/21/23 23:58, Jessica Clarke w= rote:
> What I disputed was your commit message, which at best is extremely mi= sleading and at worst makes no sense, and the necessity of the change.

Hi Jess,

Your request for revert has been noted, but I see no urgency in such a
revert. The code is perfectly fine either way.
=


N= ow is not the time for stubbornness. This change is easy to bring back in i= f it proves to be what we want. Project custom dictates requests for back o= ut be given strong consideration unless there's a really compelling rea= son why that's a bad idea. (And I don't see anything like that here= ).=C2=A0

Just my suggest= ion...

Also, I think tim= e away from the keyboard would help de-escalate things. This change isn'= ;t worth getting so worked up over.

Warner
--000000000000f4d7c205fc3c22b8--