From nobody Tue May 09 13:40:07 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QFzn03Lp0z4BCXW; Tue, 9 May 2023 13:40:20 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QFzn003lKz3H6s; Tue, 9 May 2023 13:40:20 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2ac8ee9cf7aso45688581fa.2; Tue, 09 May 2023 06:40:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683639618; x=1686231618; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IALsMxUbOk8JC7YnfU2HkmMi8NS5Pp/6dRLP326EnFc=; b=Ky7t9PHuztbaQ1S/CRrKlgOYB0C3wb9ZuW6yFwBKdr6QvVfSeFJbsWd1pgepV0Z4CX W0fgRgs3UfStKbCIan9tkzNXDipmj9gccx6pgJNy1MEy2Yk5tvmthVTKuM9ZWZE5lMAC FeTQ8MytdmrA0ffKZVF1ugozJgKYvXr8vpZzMbG6Q/cjsd/UAjwaOwZP8zApA7o3tZ1e jhByYFtQz72WitANrRVi59ef08vb3k/H9MBrnPeezRiZ00fglAn4W28pXt5F7VqN+HjY q3azjJt/Oeca6yQZDjZTz6aqK4N+/LhYm0GbwEYANYmVk+OMYCzaBDT8Bq6bh27izY12 X51w== X-Gm-Message-State: AC+VfDwocbdK1ub7BDuZYt1SPWykF5t8Z1LjbdjJF62SG9qP+oxbE0yF FpgiRjV/+nZydqmfx+9iyCdVIFs3VDCoqJq6yVlfN2v6wxQ= X-Google-Smtp-Source: ACHHUZ747Hv6jGzbIebSDk/tRvCwFwXhFE8rtOrjw6VMr8YRNv4aEas0nx1NwSPCwPtxrqyb5tsu7mMj1SH8rW6mBEs= X-Received: by 2002:a2e:3c07:0:b0:29a:9b26:4e25 with SMTP id j7-20020a2e3c07000000b0029a9b264e25mr840596lja.6.1683639617890; Tue, 09 May 2023 06:40:17 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202305081826.348IQm9N040108@gitrepo.freebsd.org> <0dadaa17917629e3399fe9acbab17eb60b63575d.camel@FreeBSD.org> <2f47388ab07eaeb820344e928adb96ff6f7a5916.camel@FreeBSD.org> <692e003e4b684c093b16048a4e12cc2dd8fc1fe0.camel@FreeBSD.org> In-Reply-To: From: Ed Maste Date: Tue, 9 May 2023 09:40:07 -0400 Message-ID: Subject: Re: git: 76887e84be97 - main - cpuset: increase userland maximum size to 1024 To: Mateusz Guzik Cc: =?UTF-8?Q?Corvin_K=C3=B6hne?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4QFzn003lKz3H6s X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N > > vmm kernel module and bhyve userland are sharing a cpuset_t. So, this > > commit introduces a mismatch in the ioctl signature of VM_RUN. Any > > advice how to fix this properly, would be appreciated. > > > > [1] > > https://github.com/freebsd/freebsd-src/blob/c543e09f1f8ef98f201f7dd3f34ae023d61dfa83/sys/amd64/include/vmm.h#L759 > > On one hand this really should not be a part of the abi (you could > have a pointer to cpuset and a a var stating the size). > > On the other hand, i suspect the least problematic long term solution > is to introduce usercpuset_t (or whatever the name) and have a > conversion func on import. This would still mean you need a kernel and > user variant of the vm_exit struct. Sorry about the breakage. I originally planned to bump both MAXCPU and cpuset_t size to 1024 in one commit, but split them in part to find unintended dependencies. I can revert the change for now and recommit it after one of the above is done.