From nobody Tue May 09 09:40:19 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QFtS604RPz49yS1; Tue, 9 May 2023 09:40:22 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QFtS56Chjz4875; Tue, 9 May 2023 09:40:21 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683625221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ej42SqORyGSDjaxJ0NzPQa4GJ1oOLw0k0UJ5+7HVoCo=; b=VAbzXjK644dH35pQ3PpJj/CJ3CTrNDc3kok+iXIKed3JB+p+UEhO5wfNqmyy+SVW6uduhs w5kAqrZtZ9Yd9gFwxnSA9pHXKRon/UU2olNb6++Xu16DH8rjoH0u0bHzAFiJsGW3yszGkC DYtBrsLo3NzR7XcDD142c6Dmaid8YlmsKPV0ql+VxaKs6WHR0QQybVbBS1E90SYuJwlT6P +G/IdBzC7OK+CqXNKikYQZcKDxK5y1HFvCIGSZhBr/AeRHWKAKPqw9XyinOJPAxpLcTgDs pPuihoRSCGa0Sh1oiKO90pvPF+hxzmj87k2T2XCLjoivqdo7ImbXCcCr1xbX8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683625221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ej42SqORyGSDjaxJ0NzPQa4GJ1oOLw0k0UJ5+7HVoCo=; b=T2cvBrJWRNaMlVwdNCuaakIUJlKN7s3VdAavF0THZEKuruZSqu56K2ZBiDnfaji3YFv/S1 uYQ7Z8QdHEWcM/j4Mkl3VOH+N/7NerSUCGctiWy7eyTRWhGgWOV5WNq4bCFb9P/ND6W6g4 rZH3j5cwMKaUW1gFBAPJdzw9JHqn9ZD20ClP4z22EYjnGNdYwdbFx/93kxRlzU17aAPr+f LM6UYDepu4mGEizmM2kmvsGRCCeh2d33NvGXwVkdjji01m81O8zCTFXA5ma1JwL0BGWknO A0UvFtQI8wgI1HMNOWfzZodtdUKI7b40cARMaP0ydteRR7+N6SvDcNmdJHPWxA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683625221; a=rsa-sha256; cv=none; b=WvWgwWfMRNbmcUV63geGlzLyKuAIQlXCkL2yS+oPw4f97nguHnPQ5+Gg4071o92bclfpqs SwCzh0pE4UMWk1TwtqERGYkSW3edeoBq5v/MKFg46LsfVlHrRaJSv4DTN42u748BQVLa+/ okK5kY61rY27ujg8dFVGkt1mTmvN7w8NUtZvX59+DrUK6yJtS6c/KxkTnPjm1gLPoExdAC SeyoVU8snhyoQT+dhdf1u445PKi2uxo58ychNH2QE0xJLTdfbYBd2WbyHfERvGBnzFd26u G//TkpCG3yHyGzj5DPO5tC5BXMJMElBATs0h3yY5b+sSW/dro4v2h5fEFBi0aw== Received: from [IPv6:2001:9e8:da68:a900:1652:753a:5d26:8439] (unknown [IPv6:2001:9e8:da68:a900:1652:753a:5d26:8439]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QFtS513S7zFkY; Tue, 9 May 2023 09:40:21 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: <692e003e4b684c093b16048a4e12cc2dd8fc1fe0.camel@FreeBSD.org> Subject: Re: git: 76887e84be97 - main - cpuset: increase userland maximum size to 1024 From: Corvin =?ISO-8859-1?Q?K=F6hne?= To: Ed Maste , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Date: Tue, 09 May 2023 11:40:19 +0200 In-Reply-To: <2f47388ab07eaeb820344e928adb96ff6f7a5916.camel@FreeBSD.org> References: <202305081826.348IQm9N040108@gitrepo.freebsd.org> <0dadaa17917629e3399fe9acbab17eb60b63575d.camel@FreeBSD.org> <2f47388ab07eaeb820344e928adb96ff6f7a5916.camel@FreeBSD.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-5GKFb5d4tJu3UV9BqS7A" User-Agent: Evolution 3.46.4 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N --=-5GKFb5d4tJu3UV9BqS7A Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2023-05-09 at 09:43 +0200, Corvin K=C3=B6hne wrote: > On Tue, 2023-05-09 at 08:59 +0200, Corvin K=C3=B6hne wrote: > > On Mon, 2023-05-08 at 18:26 +0000, Ed Maste wrote: > > > The branch main has been updated by emaste: > > >=20 > > > URL: > > > https://cgit.FreeBSD.org/src/commit/?id=3D76887e84be975698b14699d7d0d= fb157d73e9990 > > >=20 > > > commit 76887e84be975698b14699d7d0dfb157d73e9990 > > > Author:=C2=A0=C2=A0=C2=A0=C2=A0 Ed Maste > > > AuthorDate: 2023-05-02 20:57:12 +0000 > > > Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Ed Maste > > > CommitDate: 2023-05-08 18:25:15 +0000 > > >=20 > > > =C2=A0=C2=A0=C2=A0 cpuset: increase userland maximum size to 1024 > > > =C2=A0=C2=A0=C2=A0=20 > > > =C2=A0=C2=A0=C2=A0 Hardware with more than 256 CPU cores is now avail= able and > > > will > > > become > > > =C2=A0=C2=A0=C2=A0 increasingly common.=C2=A0 Bump CPU_MAXSIZE (used = for userland > > > cpuset_t > > > =C2=A0=C2=A0=C2=A0 sizing) to 1024 to define the ABI for FreeBSD 14. > > > =C2=A0=C2=A0=C2=A0=20 > > > =C2=A0=C2=A0=C2=A0 PR:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 269572, 271213 [exp-run] > > > =C2=A0=C2=A0=C2=A0 Reviewed by:=C2=A0=C2=A0=C2=A0 mjg, jhb > > > =C2=A0=C2=A0=C2=A0 Relnotes:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 yes > > > =C2=A0=C2=A0=C2=A0 Sponsored by:=C2=A0=C2=A0 The FreeBSD Foundation > > > =C2=A0=C2=A0=C2=A0 Differential Revision: https://reviews.freebsd.org= /D39941 > > > --- > > > =C2=A0sys/sys/_cpuset.h | 2 +- > > > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/sys/sys/_cpuset.h b/sys/sys/_cpuset.h > > > index b75ee595da3c..676f9855f384 100644 > > > --- a/sys/sys/_cpuset.h > > > +++ b/sys/sys/_cpuset.h > > > @@ -40,7 +40,7 @@ > > > =C2=A0#define=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_SETS= IZE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0MAXCPU > > > =C2=A0#endif > > > =C2=A0 > > > -#define=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_MAXSIZE= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0256 > > > +#define=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_MAXSIZE= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A01024 > > > =C2=A0 > > > =C2=A0#ifndef=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_SETS= IZE > > > =C2=A0#define=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_SETS= IZE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CPU_MAXSIZE > >=20 > > Hi Ed, > >=20 > > this somehow breaks bhyve on my system. It immediately exits with > > "vm_run error -1" on startup. > >=20 > >=20 >=20 > Setting MAXCPU [1] to 1024 as well, solves the issue. Not sure if > it's > a regression of your commit or a bhyve bug. >=20 > [1] > https://github.com/freebsd/freebsd-src/blob/20d8d9809a8c0a3ddd1d0156e77ec= 53a1ed95747/sys/amd64/include/param.h#L68 >=20 >=20 vmm kernel module and bhyve userland are sharing a cpuset_t. So, this commit introduces a mismatch in the ioctl signature of VM_RUN. Any advice how to fix this properly, would be appreciated. [1] https://github.com/freebsd/freebsd-src/blob/c543e09f1f8ef98f201f7dd3f34ae02= 3d61dfa83/sys/amd64/include/vmm.h#L759 --=20 Kind regards, Corvin --=-5GKFb5d4tJu3UV9BqS7A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmRaFQMACgkQ2FTaVjFe AmqSgRAAsc9eC27fDMjNs3xavwGN8NNEcoR+hq8MKa8R3NqHflO73aEBcqks5K03 twvPUgr/1VehMWEN7ELssIZydEsVguFVExyUy5JdlObd8LvDIfpKeHTGh1falhXS 7uHuuaBfQb6YCQi1/+6ow9iGoQPMNmdYVaEHMwAec+Iy4lqxPlCgOQPv6YC0lGZ2 PZe8nNt3OJlMr+GsJyK/vj74a0dj9eHOWG/OL+scGN7Zgs0jwsvITIOwZyblcdx4 +a3ZLUZpj9RkbmEVc3oQzMfryJgfaGcPsWkx2XEUmt9JFcilVYeMMZ9CQJWmcyyA iqqeYaVySEaI2OiZ3qpYjGGwASoRWHcBwZMEBWxOkvjaMQr9oPeEDCgj8iFGWb5J 82LTSdq7tsSqD/7IgmqwTAU8eee8kDT4+z2b1STUzqeExGA4Mm+FqVAMN7PPmPTe cErJDXENWCVmz9QDESSu/bgVySrvI9F3JWEs3+rhfstDIAdQ6Wd3wxOa0O3IoLUV Wj3e7coVKjsVEtnyQAaLIkmNK6Izjp731ApE5D8v7eLntjdvLE8C2dZ4N2MrYc+B Ev5muvmF1kf7OwiVqkp4OF47PHTDDot44FYs4JhG74WUB1oZ1Jp6XZAwFX/tc4uW 5ynB/vLL0xx9j+DbZBSr097QnJ0c6MZWpwxfr40hKi/9EGLoiNk= =oifI -----END PGP SIGNATURE----- --=-5GKFb5d4tJu3UV9BqS7A--