From nobody Tue May 09 08:32:43 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QFry35Rfsz49v3s; Tue, 9 May 2023 08:32:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QFry34n4Xz44C7; Tue, 9 May 2023 08:32:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683621163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DKqlmGdwPBNg8wDE5RB9q7lJ5JNcPyorxJYadNdQ9aA=; b=F3lZsdEiXP0UIk8YdILdIMcoGEPFSD7xreijXzClr5R/rqOdQ2jngCoYGofhG4bzl+wp4f TE2oTZ7LPpb7dOgsJklgejBV0vI+9Xt9yIE95jGbemkMQxRu13un9zsySsFL+BdhTZGLzg 3Q6k8jnmhfjIOvDMjf6nzjRnZFyCvkqV2TnMOL9aJVffIPDAfSEj9Y2hkmyA79uqQEA7CC BMZpx7DqUVEO34ZkUwSsQSkoUkb5p1/lKl3MOLZeRY1QPKjnfMQTZYHViPIQmm3V66r5l7 hbNf5JLklc1RiVnyFhrcdPYjODeybja4iGmTzbZ05CBRYoaMN4XxCEJb4hOwGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683621163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DKqlmGdwPBNg8wDE5RB9q7lJ5JNcPyorxJYadNdQ9aA=; b=vf3QXMpwYskY80e/BaTSwhT0D9PBQAnfEbHXB9wmbju16vReCn9z1MpuLknyp70OOQ4F/n FAxg5NkO0EOsDiZGjoQEHms/FeLyvCuK2yeYJILWR04VaxqQMqWel7yIxJf+gH1Ogri5Ia 3ipu4eChGeLwu0spx0uL7hqv0W7NWTflXzV4/PiDvELx4cKjQjacjZxOv01rJXNjvKlAe4 aPL4LVe+0aSGLxd3Lh1yRqOwCKnBK7jLITGTLSvDnu02x0c1d1t/IAAPqpaRfsMkQLN6c/ 3p2mZiqxAxhhn1e3AOBjIPSHYXuQ7389i6K/VbKa/JkmzKoJEdb7vpSLs3Y5IA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683621163; a=rsa-sha256; cv=none; b=LrlO2IF7RkD1FaT1ewqmM9Mcnr4DmNuu6CCbGnj9nCECIApT1miC2mmmcM2hFFI0jMlQvY T4YTgO6zVv8/++eVsXY9dI14x1F57tMq0N1CUH06ft/AvhaaYSjcjhrnSAFgncsk8Xg5M/ TGAvNAiw3b02QqbVFhuUKrUad2Q0N0+yvuL/CdhTt15HtQACZ+BCC73aS3juA6aQSl1iz2 Rl1acD3SaW1VPV2tlUk4Uhn2H7rUcWJtePjFUraflsCslooyUhM025Sl0qfdD50CLcRrYi yBOdt+EWIxGJJ9Gf1vIgOBuRIeCm+tFBkN/2BrTTkhF2IuHd1vV7D5izYthCHA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QFry33rFSzLkT; Tue, 9 May 2023 08:32:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 3498Whh6039159; Tue, 9 May 2023 08:32:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 3498WhvJ039158; Tue, 9 May 2023 08:32:43 GMT (envelope-from git) Date: Tue, 9 May 2023 08:32:43 GMT Message-Id: <202305090832.3498WhvJ039158@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: =?utf-8?Q?Corvin=20K=C3=B6hne?= Subject: git: c543e09f1f8e - main - bhyve: save/restore pir_desc List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: corvink X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c543e09f1f8ef98f201f7dd3f34ae023d61dfa83 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by corvink: URL: https://cgit.FreeBSD.org/src/commit/?id=c543e09f1f8ef98f201f7dd3f34ae023d61dfa83 commit c543e09f1f8ef98f201f7dd3f34ae023d61dfa83 Author: Vitaliy Gusev AuthorDate: 2023-05-09 08:27:29 +0000 Commit: Corvin Köhne CommitDate: 2023-05-09 08:31:27 +0000 bhyve: save/restore pir_desc Failing to preserve pir_desc can result in pending interrupts being lost on resume leading to a hung VM. Reviewed by: corvink, jhb MFC after: 1 week Sponsored by: vStack Differential Revision: https://reviews.freebsd.org/D35447 --- sys/amd64/vmm/intel/vmx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/amd64/vmm/intel/vmx.c b/sys/amd64/vmm/intel/vmx.c index 69391f5b77de..ec54273caaaa 100644 --- a/sys/amd64/vmm/intel/vmx.c +++ b/sys/amd64/vmm/intel/vmx.c @@ -4179,6 +4179,9 @@ vmx_vcpu_snapshot(void *vcpui, struct vm_snapshot_meta *meta) SNAPSHOT_BUF_OR_LEAVE(vcpu->guest_msrs, sizeof(vcpu->guest_msrs), meta, err, done); + SNAPSHOT_BUF_OR_LEAVE(vcpu->pir_desc, + sizeof(*vcpu->pir_desc), meta, err, done); + vmxctx = &vcpu->ctx; SNAPSHOT_VAR_OR_LEAVE(vmxctx->guest_rdi, meta, err, done); SNAPSHOT_VAR_OR_LEAVE(vmxctx->guest_rsi, meta, err, done);