From nobody Wed Mar 29 13:42:21 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PmnmJ3yQCz42ZVB; Wed, 29 Mar 2023 13:42:24 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PmnmJ3RRcz4JRV; Wed, 29 Mar 2023 13:42:24 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680097344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PHB2Sg9d6AZRbRgJlZ8Cbkq15EW+z/azvoQJEUi5HEk=; b=M9itabS6GhsmQMXpXw0yoqjpAmr4qRiHJLyiLxSRWJRwFMotoqA3lwtFRZ9AJgnIhf2aSb MXfxBiI7w/fOCtsw5oRf8cPPUv15x5JdzRfi9or1Zk29JHApRptJCHySY2/8Io1RrXsfwC q+gKuBXhw3jL9oFLVinagzU3mbCcAEwZUZ52W9ZSFnX9K4K3hbMWaVKQDZcLuyjdB8xN7q MurNmkylKzndLxafzgpadlOxgfQvidoafRd8p7+TrOyZl0SBwVcIRHqMtQ6AWOOPjmH5cI pOBIGS27TUf9e1jvZKJ9o2ZNZ0zGqRJSNYALejP2jECmjwNgasb/czK2oxsOVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680097344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PHB2Sg9d6AZRbRgJlZ8Cbkq15EW+z/azvoQJEUi5HEk=; b=PLQPw3IheCbPuv+J08fmN6naYwlpBt76DvU7uIbm/vl+8XRRgsn2e3I7qmv2R2eynZ8Ovt Ed6H7RWBeB2p0968eFCBdNX9872vqQplkK0r36pPp/bApiapBFUzD7u0dalRXZwf1BxGAw ML3r2ZIAb+nSL/HQE34tkjcF7yVivorMvQAo0UhGy02EnSiR7S+7i2GxrAbjTCijQCmkeD h+38F4mz1EAE5m14Trd1O7GEDPOaU5zxN8RaC/cRHX8YscgdqvOtRJxndVU25nP2CA3Nc8 laKxOssnWIuD3+Jimr2AL2z+JwV9HqNAMp0rU/dSZhcfT3XPcNl0CnwpF1x6xA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680097344; a=rsa-sha256; cv=none; b=UwB4YxvolULkNXLst3mupmdRKKM2jMOFfELD29xS66msUohhxngBAMxSP46Bg9M3tjxmA1 NEYmBnmOSQK5fQQVP1hdxeg2GKu3h6dVNCnDHT5VNE/9n34fGZTz8VfQTyeJ3osC//ugFp qhmt1DFTfeOMqCojnlcPQ10aYjSRFuSUyl2yMhQX3dUWNLFD6gD38nuL7j0LUdxmQMB2OG 0lJqrRInjcTm3VT2TI6nKQ5fXS7p7xCaTxzZ/Xfbhbwbur2mHMwmbgL6tPrnZ5ZHk7wQWk qLIXVWsh6eD0eXq/nt7pS010ae7KAQ2PsP9VrpwfNEFbOPJQA+o74tHvWHmx4A== Received: from [IPv6:2001:9e8:da6e:3a00:eeb6:2c69:e8e0:7741] (unknown [IPv6:2001:9e8:da6e:3a00:eeb6:2c69:e8e0:7741]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PmnmH5bTcz17j1; Wed, 29 Mar 2023 13:42:23 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: <18d0b6ee177ba4d84f0f355c06707f494e99f640.camel@FreeBSD.org> Subject: Re: git: cff482380436 - main - bhyve: Move libcasper dependecy to lib9p From: Corvin =?ISO-8859-1?Q?K=F6hne?= To: Mark Johnston Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Date: Wed, 29 Mar 2023 15:42:21 +0200 In-Reply-To: <202303071613.327GDYuO057215@gitrepo.freebsd.org> References: <202303071613.327GDYuO057215@gitrepo.freebsd.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-HBwsCK6gBwcTCG6lpwON" User-Agent: Evolution 3.46.4 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N --=-HBwsCK6gBwcTCG6lpwON Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2023-03-07 at 16:13 +0000, Mark Johnston wrote: > The branch main has been updated by markj: >=20 > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Dcff4823804363cf199c7c87eed8870a= d014066cc >=20 > commit cff4823804363cf199c7c87eed8870ad014066cc > Author:=C2=A0=C2=A0=C2=A0=C2=A0 Vitaliy Gusev > AuthorDate: 2023-03-07 16:09:22 +0000 > Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Mark Johnston > CommitDate: 2023-03-07 16:09:22 +0000 >=20 > =C2=A0=C2=A0=C2=A0 bhyve: Move libcasper dependecy to lib9p > =C2=A0=C2=A0=C2=A0=20 > =C2=A0=C2=A0=C2=A0 libcasper(3) is not used in bhyve. So move dependency = to the > appropriate > =C2=A0=C2=A0=C2=A0 place. > =C2=A0=C2=A0=C2=A0=20 > =C2=A0=C2=A0=C2=A0 Reviewed by:=C2=A0=C2=A0=C2=A0 markj > =C2=A0=C2=A0=C2=A0 MFC after:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 1 week > =C2=A0=C2=A0=C2=A0 Sponsored by:=C2=A0=C2=A0 vStack > =C2=A0=C2=A0=C2=A0 Differential Revision:=C2=A0 https://reviews.freebsd.o= rg/D38905 > --- > =C2=A0lib/lib9p/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 5 +++-- > =C2=A0share/mk/src.libnames.mk | 4 ++++ > =C2=A0usr.sbin/bhyve/Makefile=C2=A0 | 8 -------- > =C2=A03 files changed, 7 insertions(+), 10 deletions(-) >=20 > diff --git a/lib/lib9p/Makefile b/lib/lib9p/Makefile > index c810ccd79e64..5d3681104d8c 100644 > --- a/lib/lib9p/Makefile > +++ b/lib/lib9p/Makefile > @@ -6,8 +6,11 @@ > =C2=A0CFLAGS+=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-I${.CURDIR} > =C2=A0CFLAGS+=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-I${.CURDIR}/..= /../contrib/lib9p > =C2=A0 > +LIBADD=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sbuf > + > =C2=A0.if ${MK_CASPER} !=3D "no" > =C2=A0CFLAGS+=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-DWITH_CASPER > +LIBADD+=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0casper cap_pwd cap_g= rp > =C2=A0.endif > =C2=A0 > =C2=A0LIB=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A09p > @@ -28,6 +31,4 @@ SRCS=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0connection.c \ > =C2=A0INCSDIR=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0${INCLUDEDIR}/l= ib9p > =C2=A0INCS=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= fid.h lib9p.h backend/fs.h > =C2=A0 > -LIBADD=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sbuf > - > =C2=A0.include > diff --git a/share/mk/src.libnames.mk b/share/mk/src.libnames.mk > index dd1bc78b1f1a..15971189306a 100644 > --- a/share/mk/src.libnames.mk > +++ b/share/mk/src.libnames.mk > @@ -271,6 +271,10 @@ > LIBVERIEXEC?=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0${LIBVERIEXECDIR}/libv= eriexec.a > =C2=A0# 2nd+ order consumers.=C2=A0 Auto-generating this would be better. > =C2=A0_DP_80211=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sbuf bsdxml > =C2=A0_DP_9p=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sbuf > +.if ${MK_CASPER} !=3D "no" > +_DP_9p+=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0casper cap_pwd cap_g= rp > +.endif > + > =C2=A0# XXX: Not bootstrapped so uses host version on non-FreeBSD, so > don't use a > =C2=A0# FreeBSD-specific dependency list > =C2=A0.if ${.MAKE.OS} =3D=3D "FreeBSD" || !defined(BOOTSTRAPPING) > diff --git a/usr.sbin/bhyve/Makefile b/usr.sbin/bhyve/Makefile > index bf0a17edc59e..1c679a3c1578 100644 > --- a/usr.sbin/bhyve/Makefile > +++ b/usr.sbin/bhyve/Makefile > @@ -89,14 +89,6 @@ SRCS+=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0vmm_= instruction_emul.c > =C2=A0 > =C2=A0LIBADD=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0vmmapi md = nv pthread z util sbuf cam 9p > =C2=A0 > -.if ${MK_CASPER} !=3D "no" > -LIBADD+=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0casper > -LIBADD+=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cap_pwd > -LIBADD+=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cap_grp > -# Temporary disable capsicum, until we integrate checkpoint code > with it. > -#CFLAGS+=3D-DWITH_CASPER > -.endif > - > =C2=A0.if ${MK_BHYVE_SNAPSHOT} !=3D "no" > =C2=A0LIBADD+=3D ucl xo > =C2=A0.endif Hi Mark, I do get build failures for my latest commits. The build log contains: /usr/local/bin/x86_64-unknown-freebsd13.1-ld: /tmp/obj/workspace/src/amd64.amd64/tmp/usr/lib/lib9p.so: undefined reference to `cap_setpassent' /usr/local/bin/x86_64-unknown-freebsd13.1-ld: /tmp/obj/workspace/src/amd64.amd64/tmp/usr/lib/lib9p.so: undefined reference to `cap_getgrgid_r' /usr/local/bin/x86_64-unknown-freebsd13.1-ld: /tmp/obj/workspace/src/amd64.amd64/tmp/usr/lib/lib9p.so: undefined reference to `cap_setgroupent' /usr/local/bin/x86_64-unknown-freebsd13.1-ld: /tmp/obj/workspace/src/amd64.amd64/tmp/usr/lib/lib9p.so: undefined reference to `cap_getpwnam' /usr/local/bin/x86_64-unknown-freebsd13.1-ld: /tmp/obj/workspace/src/amd64.amd64/tmp/usr/lib/lib9p.so: undefined reference to `cap_getpwuid_r' collect2: error: ld returned 1 exit status See https://ci.FreeBSD.org/job/FreeBSD-main-amd64-gcc12_build/701/console It seems to be related to this commit. Any ideas how to fix it? --=20 Kind regards, Corvin --=-HBwsCK6gBwcTCG6lpwON Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmQkQD0ACgkQ2FTaVjFe AmrSRQ//fKt5cZ09ApET7esqdorRSh+TXV3In3TUdHqUmWagzUkS0Ei9I7C0m7iX pt3vYMZNYYHPbjllrra8ynACvrpDHQZaltstpFR2xP1hXs1SncYmq09CHes+EzIl 6giyHNuAPH4wfXhDGyGGiojZnqidwODLz0eoP/GpdtbvCWiK2GjBfc9kSo6bPE8A xkIzaoMCv+nKQEkSP/k3jXpDmSbVYHgZIaWTCszzTuHrxPBRhHmLv+ABO0mqbkGq QYRTieP7T3N1LVPQcba+u1ds1q6RQSvQaosfKA6KuBhKEmqYstNr3BxgbZdqC56t AFRiJ5lDBMSSZbhM4SUSXiZ2suKqW0xVbIta27H8OiQe9xpyR825HNnV9cFNJNcp 2lcsfZlbtSsAvqX4aopg4cec5mKx5y9AaiIubvmM3Io0qkbF4QcqJkgvy76dI68Y rYhC+jARmxqahH0BmgJf29vVOISOarZWsVX0bj8erMYCptA8MWLBVZHXo4TxLVIH wt1FiE4DrMt+LswU2Yf18LVvnxclIKL2h9gySA9STanKN51ejmLv4W4Ap6FDyAgO MLbQKwDcPtvDAvViHSRLLjXE9XCQmX+Br4vxkNYqw1ONtPauRpFdKma5H1B1mJ0m SxGaiCvhTxVXa9ABSa5Dhmla63ZgmHkX0w/ZQvYLVPQVRp+YjYU= =y9td -----END PGP SIGNATURE----- --=-HBwsCK6gBwcTCG6lpwON--