From nobody Mon Mar 27 15:39:34 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PlcST2jpbz41h4T for ; Mon, 27 Mar 2023 15:39:37 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PlcST0cpKz4D6m for ; Mon, 27 Mar 2023 15:39:37 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-x82d.google.com with SMTP id ga7so8986711qtb.2 for ; Mon, 27 Mar 2023 08:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1679931576; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZNlWFqYNlflEd0gKtsuc4ObowCzuJq03RvwW/UcW37A=; b=ka7wgafskm1WhU9S5zwZk/cIidnDpR5gG/hEd0RvFns4NKCzH1/NakRt914iNJ6OCS jt4HCB2ZPM0Bez8hvJZVfXBrSR6c4EU5uC/N10576rw3mvpLSg+/9k83Sb/+H01o5PmQ 2NUHhdZm8laqyXJN7tDcnujgnTXNrNCduBBYf3PywHfgCm0DV8jjAk7aVxa6SDcQSXfw Tos+lC4S7K0UyjFIXoTkqoevoWwsPPfrSYI5R23+HGbpr4d/lFceO+9o+znFKiEHNnGK CEnTb5KTcsuzS/Fgu4V/ydQ4iElmChhnmvYiM5/ZGW12PtX6J1hN3ViKfe7KMKshq80f mqqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679931576; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZNlWFqYNlflEd0gKtsuc4ObowCzuJq03RvwW/UcW37A=; b=2+l1md7Vq1g+9d5aTKpKGVJA+tkwBx8qYNoeH8uyni1zxqCQGBeyJ24PdOUjgSUllv 6RVAPWOc81eYKmai7U/h/c44aHUkBWikzd5Q+hk4uLtRnQw470o9lJo+r7wgaKhvEAv6 9UadRZ2QYTabUc7qgQmWIDiCTKrc9Kp6jLxEoi/2SLVylzPkmP0WnUv3vxhFSCjhsnjd pkFNrckS3qpBQz4E0soSlXQmS03b0mwGIGRP2wNh0kknB6PieLYnTEXUQsc/8GGx+n8X sjpcdYU41/ENkqV4CouhrhTGFj9Wxal1R53dnGB6m/nwi1yuDvDnI4aG/mo0iCPqpwDB INoA== X-Gm-Message-State: AO0yUKUsGlIiUNNB1XkTuAFI3TbWu40boHTbf7iy3Iy6MAq91vMPyzYz v620LL56W0ZTSEh4+BeHjl6Mbw== X-Google-Smtp-Source: AK7set8Pm6mtgqd9Era6s5Y1oG5wXa9WDqlFbj+zSITRkUMyhZm4fTkOEdFoqp6bVOo7CEfPSx9spQ== X-Received: by 2002:ac8:5f0b:0:b0:3e1:c341:f618 with SMTP id x11-20020ac85f0b000000b003e1c341f618mr19382390qta.65.1679931576375; Mon, 27 Mar 2023 08:39:36 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-219-215.bltmmd.fios.verizon.net. [100.16.219.215]) by smtp.gmail.com with ESMTPSA id q43-20020a05620a2a6b00b0074860fcfc00sm1463055qkp.136.2023.03.27.08.39.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 08:39:35 -0700 (PDT) Date: Mon, 27 Mar 2023 11:39:34 -0400 From: Shawn Webb To: "Alexander V. Chernikov" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 19e43c163c64 - main - netlink: add netlink KPI to the kernel by default Message-ID: <20230327153934.6lghvi7cnqodhig3@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202303271355.32RDtqJ9006858@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a7lhvfo6fvqg6fvl" Content-Disposition: inline In-Reply-To: <202303271355.32RDtqJ9006858@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4PlcST0cpKz4D6m X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --a7lhvfo6fvqg6fvl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 27, 2023 at 01:55:52PM +0000, Alexander V. Chernikov wrote: > The branch main has been updated by melifaro: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D19e43c163c64636d2590dca006= e22f18d22f48b2 >=20 > commit 19e43c163c64636d2590dca006e22f18d22f48b2 > Author: Alexander V. Chernikov > AuthorDate: 2023-03-27 11:59:30 +0000 > Commit: Alexander V. Chernikov > CommitDate: 2023-03-27 13:55:44 +0000 >=20 > netlink: add netlink KPI to the kernel by default > =20 > This change does the following: > =20 > Base Netlink KPIs (ability to register the family, parse and/or > write a Netlink message) are always present in the kernel. Specifica= lly, > * Implementation of genetlink family/group registration/removal, > some base accessors (netlink_generic_kpi.c, 260 LoC) are compiled in > unconditionally. > * Basic TLV parser functions (netlink_message_parser.c, 507 LoC) are > compiled in unconditionally. > * Glue functions (netlink<>rtsock), malloc/core sysctl definitions > (netlink_glue.c, 259 LoC) are compiled in unconditionally. > * The rest of the KPI _functions_ are defined in the netlink_glue.c, > but their implementation calls a pointer to either the stub function > or the actual function, depending on whether the module is loaded or= not. > =20 > This approach allows to have only 1k LoC out of ~3.7k LoC (current > sys/netlink implementation) in the kernel, which will not grow furth= er. > It also allows for the generic netlink kernel customers to load > successfully without requiring Netlink module and operate correctly > once Netlink module is loaded. > =20 > Reviewed by: imp > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D39269 > --- > sys/conf/files | 4 +- > sys/conf/options | 2 +- > sys/modules/carp/Makefile | 2 +- > sys/modules/netlink/Makefile | 6 +- > sys/net/route.c | 19 --- > sys/netinet/ip_carp.c | 2 + > sys/netlink/netlink_ctl.h | 10 +- > sys/netlink/netlink_domain.c | 24 --- > sys/netlink/netlink_generic.c | 282 +++--------------------------= ------ > sys/netlink/netlink_generic_kpi.c | 279 +++++++++++++++++++++++++++++= +++++ > sys/netlink/netlink_io.c | 2 + > sys/netlink/netlink_message_writer.c | 22 +-- > sys/netlink/netlink_message_writer.h | 86 +++++++++++ > sys/netlink/netlink_module.c | 26 +++- > sys/netlink/netlink_var.h | 44 ++++++ > sys/netlink/route/iface.c | 2 + > sys/netlink/route/neigh.c | 2 + > sys/netlink/route/nexthop.c | 2 + > sys/netlink/route/rt.c | 2 + > 19 files changed, 497 insertions(+), 321 deletions(-) >=20 > diff --git a/sys/conf/files b/sys/conf/files > index 629283f7c071..94cd7135b277 100644 > --- a/sys/conf/files > +++ b/sys/conf/files > @@ -4424,10 +4424,12 @@ netipsec/xform_ipcomp.c optional ipsec inet | ip= sec inet6 > netipsec/xform_tcp.c optional ipsec inet tcp_signature | \ > ipsec inet6 tcp_signature | ipsec_support inet tcp_signature | \ > ipsec_support inet6 tcp_signature > +netlink/netlink_generic_kpi.c standard > +netlink/netlink_glue.c standard It appears netlink/netlink_glue.c was missed from this commit: cc: error: no such file or directory: '/usr/src/sys/netlink/netlink_glue.c' cc: error: no input files Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --a7lhvfo6fvqg6fvl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmQhuLAACgkQ/y5nonf4 4frv3A//dsAJVKnPGvH1exicW85aL88IGZUtzMlns+z0gz5oaE5swn/Y2suo1h9p gbA5Ah29R01Know3qsRmxqhzA8EAXwoDqEeKydfpBKh2Yrl75a1RnPMnrUh2xdc8 nHsRtpSj7W3fhPDRF3SD/hXnmWlkuEsMWLW6i45kkzEBg1xs26ol8WOpTlXXYnPS VGqddTXqhU0oI9RM/8scaGSZYSirkIV4z30n+oo52tQrayJi/Gg5C/O+OZU6bLXM v2h9lmVJTsdVqKZs5Cq9V6Y4qGNK+xxMc4KUhetyEeJTcvPUrRbEXfFfdLfGW3q4 jOmFTV9iAqG3JdFPOw+N0ncJ5JChHe3u/R+BSSaxxgcEq2Vd6+G//O+I7L1lXr2j JklMJohXF45EGRHIplkuouujcO6YDkqDrfperQJ/PFIJPhE2n6fY0xQXtE+e4sAJ ohyyqpSu6m3IeE8In1VmKUTxGz4qoc4EJcgzkN0DESRTJJMIJn9Fcfibbh93FeS4 AfixY84LkmR+3L9IEZRF0wB32FUyCjUpmO0IUivdtra1t4zn8SbYnXhz7V+HH5Pk 09c3KQRNRfjqH5fWXyzadpLVnZhf9aBzy4YdWkuY6gLJM0oC3vrX+ImUFZfvZQrt sMwURdC7QrvBwaTK0QS6eO7W7qm1YBUDyJJ5lLIWzdFCWi+tKHY= =jfyF -----END PGP SIGNATURE----- --a7lhvfo6fvqg6fvl--