From nobody Tue Mar 21 14:02:23 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PgtbD4wShz40M4t; Tue, 21 Mar 2023 14:02:32 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PgtbD2cm2z3Djr; Tue, 21 Mar 2023 14:02:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.17.1/8.17.1) with ESMTPS id 32LE2N60012231 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 21 Mar 2023 16:02:26 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 32LE2N60012231 Received: (from kostik@localhost) by tom.home (8.17.1/8.17.1/Submit) id 32LE2Nsf012230; Tue, 21 Mar 2023 16:02:23 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 21 Mar 2023 16:02:23 +0200 From: Konstantin Belousov To: =?utf-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d780c6a6abb5 - main - x86/pci_early_quirks: Support Intel 11th+ gen Message-ID: References: <202303202047.32KKlrbx083372@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202303202047.32KKlrbx083372@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Queue-Id: 4PgtbD2cm2z3Djr X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Mon, Mar 20, 2023 at 08:47:53PM +0000, Jean-Sébastien Pédron wrote: > The branch main has been updated by dumbbell: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d780c6a6abb5275c8c7219539553d51ac94a023e > > commit d780c6a6abb5275c8c7219539553d51ac94a023e > Author: Jean-Sébastien Pédron > AuthorDate: 2023-03-13 14:28:22 +0000 > Commit: Jean-Sébastien Pédron > CommitDate: 2023-03-20 20:47:36 +0000 > > x86/pci_early_quirks: Support Intel 11th+ gen > > Newer Intel CPUs/iGPUs use a new method to determine the base address of > the stolen memory. This code was ported from Linux. > > Reviewed by: manu > Approved by: manu > Differential Revision: https://reviews.freebsd.org/D39057 > --- > sys/x86/pci/pci_early_quirks.c | 26 ++++++++++++ > sys/x86/pci/pci_early_quirks.h | 95 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 121 insertions(+) Is this stuff still needed or useful? When it was added, the claim was that it would be soon used to reserve regions of physical memory that buggy BIOSes did not. That never happen. If the only current consumer of the stolen memory calculations are in drm kmods, wouldn't it be better to move the code there?