From nobody Sat Mar 18 06:36:34 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PdrrB5v7qz3yBmP; Sat, 18 Mar 2023 06:36:42 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PdrrB1rw1z3M1g; Sat, 18 Mar 2023 06:36:42 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.17.1/8.17.1) with ESMTPS id 32I6aZfb034099 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 18 Mar 2023 08:36:38 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 32I6aZfb034099 Received: (from kostik@localhost) by tom.home (8.17.1/8.17.1/Submit) id 32I6aYx3034098; Sat, 18 Mar 2023 08:36:34 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 18 Mar 2023 08:36:34 +0200 From: Konstantin Belousov To: Jessica Clarke Cc: Charlie Li , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: c5c9d980c4b0 - main - libc/csu: rename ignore_init.c to libc_start1.c Message-ID: References: <202303112320.32BNKoJe039514@gitrepo.freebsd.org> <8d3503f3-fd05-5f1c-7470-48cef3c9bd2d@freebsd.org> <137554A7-8067-4E77-96A8-A0B4BF813184@freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <137554A7-8067-4E77-96A8-A0B4BF813184@freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Queue-Id: 4PdrrB1rw1z3M1g X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Sat, Mar 18, 2023 at 03:46:36AM +0000, Jessica Clarke wrote: > On 18 Mar 2023, at 03:44, Charlie Li wrote: > > > > Konstantin Belousov wrote: > >> libc/csu: rename ignore_init.c to libc_start1.c > >> The current name was a historical curiosity that started when init array > >> support was added, and then the file appeared a convenient place for the > >> addition of the MI common code to csu. It is now referenced by name in > >> single place and the rename is easy, so do it. > >> Sponsored by: The FreeBSD Foundation > >> MFC after: 3 weeks > >> --- > >> lib/libc/csu/Makefile.inc | 2 +- > >> lib/libc/csu/{ignore_init.c => libc_start1.c} | 0 > >> 2 files changed, 1 insertion(+), 1 deletion(-) > > Seems like an ABI break. Anything compiled after this but ran on an earlier-by-revision-but-same __FreeBSD_version complains with 'Undefined symbol "__libc_start1@FBSD_1.7"' > > It’s not a break, just new ABI. Same as adding a new function, just > everything automatically uses it. Well it is break of ABI indeed, but it is backward-compatible. We never guaranteed forward-compatibility, and hopefully never will. Doing so would mean that FreeBSD is frozen. > > It’s true that __FreeBSD_version needs bumping if it hasn’t already > been though. > I bumped the version to please the public, but I do not see much use for this bump, same as for many other instances of the bump. The new interface presence is declared by the export of specifically-versioned symbol in libc, and really this export, instead of some random osversion reported from unrelated software artifact (kernel) is what important.